From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>
Subject: [PATCH v2 24/25] ASoC: pcm: Drop obsoleted PCM copy_user ops
Date: Tue, 15 Aug 2023 21:01:35 +0200 [thread overview]
Message-ID: <20230815190136.8987-25-tiwai@suse.de> (raw)
In-Reply-To: <20230815190136.8987-1-tiwai@suse.de>
Now all ASoC users have been replaced to use the new PCM copy ops,
let's drop the obsoleted copy_user ops and its helper function.
Reviewed-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
include/sound/soc-component.h | 7 -------
sound/soc/soc-component.c | 20 --------------------
sound/soc/soc-pcm.c | 2 --
3 files changed, 29 deletions(-)
diff --git a/include/sound/soc-component.h b/include/sound/soc-component.h
index 8040f001f2fb..17bea3144551 100644
--- a/include/sound/soc-component.h
+++ b/include/sound/soc-component.h
@@ -137,10 +137,6 @@ struct snd_soc_component_driver {
struct timespec64 *audio_ts,
struct snd_pcm_audio_tstamp_config *audio_tstamp_config,
struct snd_pcm_audio_tstamp_report *audio_tstamp_report);
- int (*copy_user)(struct snd_soc_component *component,
- struct snd_pcm_substream *substream, int channel,
- unsigned long pos, void __user *buf,
- unsigned long bytes);
int (*copy)(struct snd_soc_component *component,
struct snd_pcm_substream *substream, int channel,
unsigned long pos, struct iov_iter *buf,
@@ -513,9 +509,6 @@ int snd_soc_pcm_component_pointer(struct snd_pcm_substream *substream);
int snd_soc_pcm_component_ioctl(struct snd_pcm_substream *substream,
unsigned int cmd, void *arg);
int snd_soc_pcm_component_sync_stop(struct snd_pcm_substream *substream);
-int snd_soc_pcm_component_copy_user(struct snd_pcm_substream *substream,
- int channel, unsigned long pos,
- void __user *buf, unsigned long bytes);
int snd_soc_pcm_component_copy(struct snd_pcm_substream *substream,
int channel, unsigned long pos,
struct iov_iter *buf, unsigned long bytes);
diff --git a/sound/soc/soc-component.c b/sound/soc/soc-component.c
index ffa2dd8a21ba..f18406dfa1e4 100644
--- a/sound/soc/soc-component.c
+++ b/sound/soc/soc-component.c
@@ -1070,26 +1070,6 @@ int snd_soc_pcm_component_copy(struct snd_pcm_substream *substream,
return -EINVAL;
}
-int snd_soc_pcm_component_copy_user(struct snd_pcm_substream *substream,
- int channel, unsigned long pos,
- void __user *buf, unsigned long bytes)
-{
- struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
- struct snd_soc_component *component;
- int i;
-
- /* FIXME. it returns 1st copy now */
- for_each_rtd_components(rtd, i, component)
- if (component->driver->copy_user)
- return soc_component_ret(
- component,
- component->driver->copy_user(
- component, substream, channel,
- pos, buf, bytes));
-
- return -EINVAL;
-}
-
struct page *snd_soc_pcm_component_page(struct snd_pcm_substream *substream,
unsigned long offset)
{
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 71403da28d37..ae02d1d80c88 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -2975,8 +2975,6 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
rtd->ops.sync_stop = snd_soc_pcm_component_sync_stop;
if (drv->copy)
rtd->ops.copy = snd_soc_pcm_component_copy;
- else if (drv->copy_user)
- rtd->ops.copy_user = snd_soc_pcm_component_copy_user;
if (drv->page)
rtd->ops.page = snd_soc_pcm_component_page;
if (drv->mmap)
--
2.35.3
next prev parent reply other threads:[~2023-08-15 19:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 19:01 [PATCH v2 00/25] ALSA: Generic PCM copy ops using iov_iter Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 01/25] iov_iter: Export import_ubuf() Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 02/25] ALSA: pcm: Add copy ops with iov_iter Takashi Iwai
2023-09-02 5:30 ` Al Viro
2023-09-02 6:00 ` Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 03/25] ALSA: core: Add memory copy helpers between iov_iter and iomem Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 04/25] ALSA: dummy: Convert to generic PCM copy ops Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 05/25] ALSA: gus: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 06/25] ALSA: emu8000: " Takashi Iwai
2023-09-02 5:36 ` Al Viro
2023-09-02 6:01 ` Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 07/25] ALSA: es1938: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 08/25] ALSA: korg1212: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 09/25] ALSA: nm256: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 10/25] ALSA: rme32: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 11/25] ALSA: rme96: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 12/25] ALSA: hdsp: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 13/25] ALSA: rme9652: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 14/25] ALSA: sh: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 15/25] ALSA: xen: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 16/25] ALSA: pcmtest: Update comment about " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 17/25] media: solo6x10: Convert to generic " Takashi Iwai
2023-08-18 7:48 ` Hans Verkuil
2023-08-15 19:01 ` [PATCH v2 18/25] ASoC: component: Add " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 19/25] ASoC: mediatek: Convert to " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 20/25] ASoC: qcom: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 21/25] ASoC: dmaengine: " Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 22/25] ASoC: dmaengine: Use iov_iter for process callback, too Takashi Iwai
2023-08-15 19:01 ` [PATCH v2 23/25] ALSA: doc: Update description for the new PCM copy ops Takashi Iwai
2023-08-15 19:01 ` Takashi Iwai [this message]
2023-08-15 19:01 ` [PATCH v2 25/25] ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel ops Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815190136.8987-25-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®