* [paulmck-rcu:dev.2023.08.14a 49/51] kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory
@ 2023-08-16 1:55 kernel test robot
2023-08-16 2:19 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2023-08-16 1:55 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: oe-kbuild-all, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2023.08.14a
head: a90c4cbc91475bd5df35f712a954972fbfff40a1
commit: 37730a9ba11627b63d8108dd8b3061ea2ee04df9 [49/51] rcutorture: Add test of RCU CPU stall notifiers
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230816/202308160930.YEekR3Wf-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230816/202308160930.YEekR3Wf-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308160930.YEekR3Wf-lkp@intel.com/
All errors (new ones prefixed by >>):
>> kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory
24 | #include <linux/rcu_notifier.h>
| ^~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +24 kernel/rcu/rcutorture.c
14
15 #include <linux/types.h>
16 #include <linux/kernel.h>
17 #include <linux/init.h>
18 #include <linux/module.h>
19 #include <linux/kthread.h>
20 #include <linux/err.h>
21 #include <linux/spinlock.h>
22 #include <linux/smp.h>
23 #include <linux/rcupdate_wait.h>
> 24 #include <linux/rcu_notifier.h>
25 #include <linux/interrupt.h>
26 #include <linux/sched/signal.h>
27 #include <uapi/linux/sched/types.h>
28 #include <linux/atomic.h>
29 #include <linux/bitops.h>
30 #include <linux/completion.h>
31 #include <linux/moduleparam.h>
32 #include <linux/percpu.h>
33 #include <linux/notifier.h>
34 #include <linux/reboot.h>
35 #include <linux/freezer.h>
36 #include <linux/cpu.h>
37 #include <linux/delay.h>
38 #include <linux/stat.h>
39 #include <linux/srcu.h>
40 #include <linux/slab.h>
41 #include <linux/trace_clock.h>
42 #include <asm/byteorder.h>
43 #include <linux/torture.h>
44 #include <linux/vmalloc.h>
45 #include <linux/sched/debug.h>
46 #include <linux/sched/sysctl.h>
47 #include <linux/oom.h>
48 #include <linux/tick.h>
49 #include <linux/rcupdate_trace.h>
50 #include <linux/nmi.h>
51
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [paulmck-rcu:dev.2023.08.14a 49/51] kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory
2023-08-16 1:55 [paulmck-rcu:dev.2023.08.14a 49/51] kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory kernel test robot
@ 2023-08-16 2:19 ` Paul E. McKenney
2023-08-17 8:05 ` Liu, Yujie
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2023-08-16 2:19 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, linux-kernel
On Wed, Aug 16, 2023 at 09:55:30AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2023.08.14a
> head: a90c4cbc91475bd5df35f712a954972fbfff40a1
> commit: 37730a9ba11627b63d8108dd8b3061ea2ee04df9 [49/51] rcutorture: Add test of RCU CPU stall notifiers
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230816/202308160930.YEekR3Wf-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 12.3.0
> reproduce: (https://download.01.org/0day-ci/archive/20230816/202308160930.YEekR3Wf-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202308160930.YEekR3Wf-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory
> 24 | #include <linux/rcu_notifier.h>
> | ^~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
You would think that I would remember "git add". ;-)
Does the patch below fix things up?
Thanx, Paul
------------------------------------------------------------------------
commit 2b7e462695eee212f81f7000af4f4af2523ece35
Author: Paul E. McKenney <paulmck@kernel.org>
Date: Tue Aug 15 19:17:50 2023 -0700
fixup! rcu: Add RCU CPU stall notifier
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
diff --git a/include/linux/rcu_notifier.h b/include/linux/rcu_notifier.h
new file mode 100644
index 000000000000..ebf371364581
--- /dev/null
+++ b/include/linux/rcu_notifier.h
@@ -0,0 +1,32 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Read-Copy Update notifiers, initially RCU CPU stall notifier.
+ * Separate from rcupdate.h to avoid #include loops.
+ *
+ * Copyright (C) 2023 Paul E. McKenney.
+ */
+
+#ifndef __LINUX_RCU_NOTIFIER_H
+#define __LINUX_RCU_NOTIFIER_H
+
+// Actions for RCU CPU stall notifier calls.
+#define RCU_STALL_NOTIFY_NORM 1
+#define RCU_STALL_NOTIFY_EXP 2
+
+#ifdef CONFIG_RCU_STALL_COMMON
+
+#include <linux/notifier.h>
+#include <linux/types.h>
+
+int rcu_stall_chain_notifier_register(struct notifier_block *n);
+int rcu_stall_chain_notifier_unregister(struct notifier_block *n);
+
+#else // #ifdef CONFIG_RCU_STALL_COMMON
+
+// No RCU CPU stall warnings in Tiny RCU.
+static inline int rcu_stall_chain_notifier_register(struct notifier_block *n) { return -EEXIST; }
+static inline int rcu_stall_chain_notifier_unregister(struct notifier_block *n) { return -ENOENT; }
+
+#endif // #else // #ifdef CONFIG_RCU_STALL_COMMON
+
+#endif /* __LINUX_RCU_NOTIFIER_H */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [paulmck-rcu:dev.2023.08.14a 49/51] kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory
2023-08-16 2:19 ` Paul E. McKenney
@ 2023-08-17 8:05 ` Liu, Yujie
2023-08-18 0:14 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Liu, Yujie @ 2023-08-17 8:05 UTC (permalink / raw)
To: paulmck; +Cc: linux-kernel, lkp, oe-kbuild-all
On Tue, 2023-08-15 at 19:19 -0700, Paul E. McKenney wrote:
> On Wed, Aug 16, 2023 at 09:55:30AM +0800, kernel test robot wrote:
> > tree:
> > https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> > dev.2023.08.14a
> > head: a90c4cbc91475bd5df35f712a954972fbfff40a1
> > commit: 37730a9ba11627b63d8108dd8b3061ea2ee04df9 [49/51]
> > rcutorture: Add test of RCU CPU stall notifiers
> > config: sh-allmodconfig
> > (https://download.01.org/0day-ci/archive/20230816/202308160930.YEek
> > R3Wf-lkp@intel.com/config)
> > compiler: sh4-linux-gcc (GCC) 12.3.0
> > reproduce:
> > (https://download.01.org/0day-ci/archive/20230816/202308160930.YEek
> > R3Wf-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a
> > new version of
> > the same patch/commit), kindly add following tags
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes:
> > > https://lore.kernel.org/oe-kbuild-all/202308160930.YEekR3Wf-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>):
> >
> > > > kernel/rcu/rcutorture.c:24:10: fatal error:
> > > > linux/rcu_notifier.h: No such file or directory
> > 24 | #include <linux/rcu_notifier.h>
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated.
>
> You would think that I would remember "git add". ;-)
>
> Does the patch below fix things up?
Yes, the build error is gone after adding the new header file. Seems
this fixup patch is already included in dev.2023.08.15a branch :)
Thanks,
Yujie
> Thanx, Paul
>
> ---------------------------------------------------------------------
> ---
>
> commit 2b7e462695eee212f81f7000af4f4af2523ece35
> Author: Paul E. McKenney <paulmck@kernel.org>
> Date: Tue Aug 15 19:17:50 2023 -0700
>
> fixup! rcu: Add RCU CPU stall notifier
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> diff --git a/include/linux/rcu_notifier.h
> b/include/linux/rcu_notifier.h
> new file mode 100644
> index 000000000000..ebf371364581
> --- /dev/null
> +++ b/include/linux/rcu_notifier.h
> @@ -0,0 +1,32 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Read-Copy Update notifiers, initially RCU CPU stall notifier.
> + * Separate from rcupdate.h to avoid #include loops.
> + *
> + * Copyright (C) 2023 Paul E. McKenney.
> + */
> +
> +#ifndef __LINUX_RCU_NOTIFIER_H
> +#define __LINUX_RCU_NOTIFIER_H
> +
> +// Actions for RCU CPU stall notifier calls.
> +#define RCU_STALL_NOTIFY_NORM 1
> +#define RCU_STALL_NOTIFY_EXP 2
> +
> +#ifdef CONFIG_RCU_STALL_COMMON
> +
> +#include <linux/notifier.h>
> +#include <linux/types.h>
> +
> +int rcu_stall_chain_notifier_register(struct notifier_block *n);
> +int rcu_stall_chain_notifier_unregister(struct notifier_block *n);
> +
> +#else // #ifdef CONFIG_RCU_STALL_COMMON
> +
> +// No RCU CPU stall warnings in Tiny RCU.
> +static inline int rcu_stall_chain_notifier_register(struct
> notifier_block *n) { return -EEXIST; }
> +static inline int rcu_stall_chain_notifier_unregister(struct
> notifier_block *n) { return -ENOENT; }
> +
> +#endif // #else // #ifdef CONFIG_RCU_STALL_COMMON
> +
> +#endif /* __LINUX_RCU_NOTIFIER_H */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [paulmck-rcu:dev.2023.08.14a 49/51] kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory
2023-08-17 8:05 ` Liu, Yujie
@ 2023-08-18 0:14 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2023-08-18 0:14 UTC (permalink / raw)
To: Liu, Yujie; +Cc: linux-kernel, lkp, oe-kbuild-all
On Thu, Aug 17, 2023 at 08:05:10AM +0000, Liu, Yujie wrote:
> On Tue, 2023-08-15 at 19:19 -0700, Paul E. McKenney wrote:
> > On Wed, Aug 16, 2023 at 09:55:30AM +0800, kernel test robot wrote:
> > > tree:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git
> > > dev.2023.08.14a
> > > head: a90c4cbc91475bd5df35f712a954972fbfff40a1
> > > commit: 37730a9ba11627b63d8108dd8b3061ea2ee04df9 [49/51]
> > > rcutorture: Add test of RCU CPU stall notifiers
> > > config: sh-allmodconfig
> > > (https://download.01.org/0day-ci/archive/20230816/202308160930.YEek
> > > R3Wf-lkp@intel.com/config)
> > > compiler: sh4-linux-gcc (GCC) 12.3.0
> > > reproduce:
> > > (https://download.01.org/0day-ci/archive/20230816/202308160930.YEek
> > > R3Wf-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a
> > > new version of
> > > the same patch/commit), kindly add following tags
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > Closes:
> > > > https://lore.kernel.org/oe-kbuild-all/202308160930.YEekR3Wf-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > > > kernel/rcu/rcutorture.c:24:10: fatal error:
> > > > > linux/rcu_notifier.h: No such file or directory
> > > 24 | #include <linux/rcu_notifier.h>
> > > | ^~~~~~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> >
> > You would think that I would remember "git add". ;-)
> >
> > Does the patch below fix things up?
>
> Yes, the build error is gone after adding the new header file. Seems
> this fixup patch is already included in dev.2023.08.15a branch :)
Something about my having hit it when pulling the commits onto the
test systems. ;-)
Thanx, Paul
> Thanks,
> Yujie
>
> > Thanx, Paul
> >
> > ---------------------------------------------------------------------
> > ---
> >
> > commit 2b7e462695eee212f81f7000af4f4af2523ece35
> > Author: Paul E. McKenney <paulmck@kernel.org>
> > Date: Tue Aug 15 19:17:50 2023 -0700
> >
> > fixup! rcu: Add RCU CPU stall notifier
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> >
> > diff --git a/include/linux/rcu_notifier.h
> > b/include/linux/rcu_notifier.h
> > new file mode 100644
> > index 000000000000..ebf371364581
> > --- /dev/null
> > +++ b/include/linux/rcu_notifier.h
> > @@ -0,0 +1,32 @@
> > +/* SPDX-License-Identifier: GPL-2.0+ */
> > +/*
> > + * Read-Copy Update notifiers, initially RCU CPU stall notifier.
> > + * Separate from rcupdate.h to avoid #include loops.
> > + *
> > + * Copyright (C) 2023 Paul E. McKenney.
> > + */
> > +
> > +#ifndef __LINUX_RCU_NOTIFIER_H
> > +#define __LINUX_RCU_NOTIFIER_H
> > +
> > +// Actions for RCU CPU stall notifier calls.
> > +#define RCU_STALL_NOTIFY_NORM 1
> > +#define RCU_STALL_NOTIFY_EXP 2
> > +
> > +#ifdef CONFIG_RCU_STALL_COMMON
> > +
> > +#include <linux/notifier.h>
> > +#include <linux/types.h>
> > +
> > +int rcu_stall_chain_notifier_register(struct notifier_block *n);
> > +int rcu_stall_chain_notifier_unregister(struct notifier_block *n);
> > +
> > +#else // #ifdef CONFIG_RCU_STALL_COMMON
> > +
> > +// No RCU CPU stall warnings in Tiny RCU.
> > +static inline int rcu_stall_chain_notifier_register(struct
> > notifier_block *n) { return -EEXIST; }
> > +static inline int rcu_stall_chain_notifier_unregister(struct
> > notifier_block *n) { return -ENOENT; }
> > +
> > +#endif // #else // #ifdef CONFIG_RCU_STALL_COMMON
> > +
> > +#endif /* __LINUX_RCU_NOTIFIER_H */
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-18 0:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-16 1:55 [paulmck-rcu:dev.2023.08.14a 49/51] kernel/rcu/rcutorture.c:24:10: fatal error: linux/rcu_notifier.h: No such file or directory kernel test robot
2023-08-16 2:19 ` Paul E. McKenney
2023-08-17 8:05 ` Liu, Yujie
2023-08-18 0:14 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®