From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Nikolay Borisov <nik.borisov@suse.com>, X86 ML <x86@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/srso: Correct the mitigation status when SMT is disabled
Date: Wed, 16 Aug 2023 11:29:40 -0700 [thread overview]
Message-ID: <20230816182940.xw67h5xbilqpb5au@treble> (raw)
In-Reply-To: <20230816173531.GMZN0I40DEFE38Zxuz@fat_crate.local>
On Wed, Aug 16, 2023 at 07:35:31PM +0200, Borislav Petkov wrote:
> On Wed, Aug 16, 2023 at 09:07:57AM -0700, Josh Poimboeuf wrote:
> > In this case srso_show_state() is never called, so the following code
> > can't run:
> >
> > + if (boot_cpu_has(X86_FEATURE_SRSO_NO)) {
> > + if (sched_smt_active())
> > + return sysfs_emit(buf, "Not affected\n");
>
> Ofc it can. If something has set X86_FEATURE_SRSO_NO early, before the
> bug bits detection happens, then you get:
>
> $ cat /sys/devices/system/cpu/vulnerabilities/spec_rstack_overflow
> Not affected
No, if the bug bit isn't set then that comes from cpu_show_common():
static ssize_t cpu_show_common(struct device *dev, struct device_attribute *attr,
char *buf, unsigned int bug)
{
if (!boot_cpu_has_bug(bug))
return sysfs_emit(buf, "Not affected\n");
--
Josh
next prev parent reply other threads:[~2023-08-16 18:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 10:45 [PATCH] x86/srso: Disable the mitigation on unaffected configurations Borislav Petkov
2023-08-14 6:39 ` Nikolay Borisov
2023-08-14 20:08 ` Josh Poimboeuf
2023-08-14 20:25 ` Borislav Petkov
2023-08-14 20:53 ` Josh Poimboeuf
2023-08-14 21:17 ` Borislav Petkov
2023-08-15 9:57 ` [PATCH] x86/srso: Correct the mitigation status when SMT is disabled Borislav Petkov
2023-08-15 19:58 ` Josh Poimboeuf
2023-08-15 20:17 ` Borislav Petkov
2023-08-15 21:27 ` Josh Poimboeuf
2023-08-16 8:30 ` Borislav Petkov
2023-08-16 16:07 ` Josh Poimboeuf
2023-08-16 17:35 ` Borislav Petkov
2023-08-16 18:29 ` Josh Poimboeuf [this message]
2023-08-16 18:58 ` Borislav Petkov
2023-08-17 9:07 ` Borislav Petkov
2023-08-17 14:54 ` Josh Poimboeuf
2023-08-18 10:59 ` [tip: x86/urgent] " tip-bot2 for Borislav Petkov (AMD)
2023-08-14 9:37 ` [tip: x86/urgent] x86/srso: Disable the mitigation on unaffected configurations tip-bot2 for Borislav Petkov (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816182940.xw67h5xbilqpb5au@treble \
--to=jpoimboe@kernel.org \
--cc=bp@alien8.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®