From: Viresh Kumar <viresh.kumar@linaro.org>
To: Liao Chang <liaochang1@huawei.com>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] cpufreq: cppc: Set fie_disabled to FIE_DISABLED if fails to create kworker_fie
Date: Thu, 17 Aug 2023 14:26:24 +0530 [thread overview]
Message-ID: <20230817085624.dfevjozfpmmxcldn@vireshk-i7> (raw)
In-Reply-To: <20230817074756.883380-1-liaochang1@huawei.com>
On 17-08-23, 07:47, Liao Chang wrote:
> The function cppc_freq_invariance_init() may failed to create
> kworker_fie, make it more robust by setting fie_disabled to FIE_DISBALED
> to prevent an invalid pointer dereference in kthread_destroy_worker(),
> which called from cppc_freq_invariance_exit().
Btw, this version information present below should be added ... (see later)
> v3:
> Simplify cleanup code when invariance initialization fails.
>
> v2:
> Set fie_disabled to FIE_DISABLED when invariance initialization fails.
>
> Link: https://lore.kernel.org/all/20230816034630.a4hvsj373q6aslk3@vireshk-i7/
>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> ---
... here after the "---" line, this way this not-so-useful information will not
be committed while applying the patch.
> drivers/cpufreq/cppc_cpufreq.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
--
viresh
next prev parent reply other threads:[~2023-08-17 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 7:47 Liao Chang
2023-08-17 8:43 ` Viresh Kumar
2023-08-17 8:56 ` Viresh Kumar [this message]
2023-08-17 10:44 ` Liao, Chang
2023-08-17 10:48 ` Viresh Kumar
2023-08-18 1:09 ` Liao, Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817085624.dfevjozfpmmxcldn@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=liaochang1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®