* [PATCH] kunit: fix struct kunit_attr header
@ 2023-08-17 19:14 Rae Moar
2023-08-17 22:14 ` David Gow
0 siblings, 1 reply; 2+ messages in thread
From: Rae Moar @ 2023-08-17 19:14 UTC (permalink / raw)
To: shuah, davidgow, brendan.higgins
Cc: linux-kselftest, kunit-dev, linux-kernel, Rae Moar, kernel test robot
Add parameter descriptions to struct kunit_attr header for the
parameters attr_default and print.
Fixes: 39e92cb1e4a1 ("kunit: Add test attributes API structure")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308180127.VD7YRPGa-lkp@intel.com/
Signed-off-by: Rae Moar <rmoar@google.com>
---
lib/kunit/attributes.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/kunit/attributes.c b/lib/kunit/attributes.c
index 5e3034b6be99..1b512f7e1838 100644
--- a/lib/kunit/attributes.c
+++ b/lib/kunit/attributes.c
@@ -30,6 +30,8 @@ enum print_ops {
* attribute value
* @filter: function to indicate whether a given attribute value passes a
* filter
+ * @attr_default: default attribute value used during filtering
+ * @print: value of enum print_ops to indicate when to print attribute
*/
struct kunit_attr {
const char *name;
base-commit: 582eb3aeed2d06b122fba95518b84506d3d4ceb9
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kunit: fix struct kunit_attr header
2023-08-17 19:14 [PATCH] kunit: fix struct kunit_attr header Rae Moar
@ 2023-08-17 22:14 ` David Gow
0 siblings, 0 replies; 2+ messages in thread
From: David Gow @ 2023-08-17 22:14 UTC (permalink / raw)
To: Rae Moar
Cc: shuah, brendan.higgins, linux-kselftest, kunit-dev, linux-kernel,
kernel test robot
[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]
On Fri, 18 Aug 2023 at 03:15, Rae Moar <rmoar@google.com> wrote:
>
> Add parameter descriptions to struct kunit_attr header for the
> parameters attr_default and print.
>
> Fixes: 39e92cb1e4a1 ("kunit: Add test attributes API structure")
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308180127.VD7YRPGa-lkp@intel.com/
>
> Signed-off-by: Rae Moar <rmoar@google.com>
> ---
LGTM, Thanks.
Reviewed-by: David Gow <davidgow@google.com>
Cheers,
-- David
> lib/kunit/attributes.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/kunit/attributes.c b/lib/kunit/attributes.c
> index 5e3034b6be99..1b512f7e1838 100644
> --- a/lib/kunit/attributes.c
> +++ b/lib/kunit/attributes.c
> @@ -30,6 +30,8 @@ enum print_ops {
> * attribute value
> * @filter: function to indicate whether a given attribute value passes a
> * filter
> + * @attr_default: default attribute value used during filtering
> + * @print: value of enum print_ops to indicate when to print attribute
> */
> struct kunit_attr {
> const char *name;
>
> base-commit: 582eb3aeed2d06b122fba95518b84506d3d4ceb9
> --
> 2.42.0.rc1.204.g551eb34607-goog
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-17 22:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-17 19:14 [PATCH] kunit: fix struct kunit_attr header Rae Moar
2023-08-17 22:14 ` David Gow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®