* [PATCH] softirq: Adjust comment for CONFIG_PREEMPT_RT in #else
@ 2023-08-18 8:47 Jesper Dangaard Brouer
2023-08-18 9:05 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Dangaard Brouer @ 2023-08-18 8:47 UTC (permalink / raw)
To: linux-kernel, Thomas Gleixner
Cc: Jesper Dangaard Brouer, Sebastian Andrzej Siewior, Paolo Abeni,
Peter Zijlstra, netdev
The #ifdef CONFIG_PREEMPT_RT #else statement had a comment
that made me think the code below #else statement was RT code.
After reading the code closer I realized it was not RT code.
Adjust comment to !RT to helper future readers of the code.
Fixes: 8b1c04acad08 ("softirq: Make softirq control and processing RT aware")
Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
---
kernel/softirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index 807b34ccd797..b9a8384821b9 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -292,7 +292,7 @@ void do_softirq_post_smp_call_flush(unsigned int was_pending)
invoke_softirq();
}
-#else /* CONFIG_PREEMPT_RT */
+#else /* !CONFIG_PREEMPT_RT */
/*
* This one is for softirq.c-internal use, where hardirqs are disabled
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] softirq: Adjust comment for CONFIG_PREEMPT_RT in #else
2023-08-18 8:47 [PATCH] softirq: Adjust comment for CONFIG_PREEMPT_RT in #else Jesper Dangaard Brouer
@ 2023-08-18 9:05 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Andrzej Siewior @ 2023-08-18 9:05 UTC (permalink / raw)
To: Jesper Dangaard Brouer
Cc: linux-kernel, Thomas Gleixner, Paolo Abeni, Peter Zijlstra, netdev
On 2023-08-18 10:47:35 [+0200], Jesper Dangaard Brouer wrote:
> The #ifdef CONFIG_PREEMPT_RT #else statement had a comment
> that made me think the code below #else statement was RT code.
> After reading the code closer I realized it was not RT code.
> Adjust comment to !RT to helper future readers of the code.
indeed.
> Fixes: 8b1c04acad08 ("softirq: Make softirq control and processing RT aware")
> Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-18 9:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-18 8:47 [PATCH] softirq: Adjust comment for CONFIG_PREEMPT_RT in #else Jesper Dangaard Brouer
2023-08-18 9:05 ` Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®