* [PATCH] ubifs: fix missing error code err
@ 2023-08-18 9:18 Ferry Meng
2023-08-19 2:24 ` Zhihao Cheng
0 siblings, 1 reply; 2+ messages in thread
From: Ferry Meng @ 2023-08-18 9:18 UTC (permalink / raw)
To: Richard Weinberger, linux-mtd; +Cc: linux-kernel, Ferry Meng
Fix smatch warning:
fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code
'err'
Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index dc52ac0f4a34..ab837b73d4b9 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
ubifs_err(c, "bad data node (block %u, inode %lu)",
blk, inode->i_ino);
ubifs_dump_node(c, dn, dn_size);
+ err = -EUCLEAN;
goto out_free;
}
--
2.19.1.6.gb485710b
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ubifs: fix missing error code err
2023-08-18 9:18 [PATCH] ubifs: fix missing error code err Ferry Meng
@ 2023-08-19 2:24 ` Zhihao Cheng
0 siblings, 0 replies; 2+ messages in thread
From: Zhihao Cheng @ 2023-08-19 2:24 UTC (permalink / raw)
To: Ferry Meng, Richard Weinberger, linux-mtd; +Cc: linux-kernel
在 2023/8/18 17:18, Ferry Meng 写道:
> Fix smatch warning:
>
> fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code
> 'err'
>
> Signed-off-by: Ferry Meng <mengferry@linux.alibaba.com>
>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
> index dc52ac0f4a34..ab837b73d4b9 100644
> --- a/fs/ubifs/journal.c
> +++ b/fs/ubifs/journal.c
> @@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
> ubifs_err(c, "bad data node (block %u, inode %lu)",
> blk, inode->i_ino);
> ubifs_dump_node(c, dn, dn_size);
> + err = -EUCLEAN;
> goto out_free;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-19 2:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-18 9:18 [PATCH] ubifs: fix missing error code err Ferry Meng
2023-08-19 2:24 ` Zhihao Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®