From: Guru Das Srinagesh <quic_gurus@quicinc.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Guru Das Srinagesh <quic_gurus@quicinc.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nicolas Schier <nicolas@fjasle.eu>,
Kees Cook <keescook@chromium.org>,
Bjorn Andersson <andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
Will Deacon <will@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<quic_pkondeti@quicinc.com>, <u.kleine-koenig@pengutronix.de>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2 0/1] Add add-maintainer.py script
Date: Fri, 18 Aug 2023 18:48:13 -0700 [thread overview]
Message-ID: <20230819014813.GB22393@quicinc.com> (raw)
In-Reply-To: <077c330d-5b86-4797-b69d-0ad02f49978f@linaro.org>
On Aug 18 2023 10:33, Neil Armstrong wrote:
> My opinion is that it would be a better idea to add a new output mode
> to scripts/get_maintainer.pl than adding another script on top of it.
Sorry, I don't follow. The problem that this script is solving is getting the
output of `get_maintainer.pl` neatly into a patch according to this scheme:
1. Generate patches using `git format-patch`
2. Run `add-maintainer.py` on the above patches
3. `git send-email` the patches.
Not sure how adding a new output mode to `get_maintainer.pl` fits in this
problem space.
Unless you mean to add a switch to it so that it automatically
edits the patch in-place (like `add-maintainer.py` does) and adds all the
addresses directly to the patch - in which case, that would be feature creep.
> Or document somewhere how to use get_maintainer.pl with git-format-patch
> without any additional scripts.
IMHO, `Documentation/process/submitting-patches.rst` should be updated with at
least one or two options addressing how to get from the aforementioned
step #1 -> step #3 addressing the problem that is being solved by step #2. In
this vacuum, every developer and maintainer appears to have their own solution
that works for them.
Thank you.
Guru Das.
next prev parent reply other threads:[~2023-08-19 1:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 8:23 Guru Das Srinagesh
2023-08-03 8:23 ` [PATCH v2 1/1] scripts: Add add-maintainer.py Guru Das Srinagesh
2023-08-03 9:04 ` Pavan Kondeti
2023-08-10 18:52 ` Guru Das Srinagesh
2023-08-23 15:14 ` Nicolas Schier
2023-08-24 21:44 ` Guru Das Srinagesh
2023-08-25 11:44 ` Nicolas Schier
2023-08-25 17:00 ` Guru Das Srinagesh
2023-08-27 5:52 ` Nicolas Schier
2023-08-03 9:16 ` [PATCH v2 0/1] Add add-maintainer.py script Neil Armstrong
2023-08-10 18:49 ` Guru Das Srinagesh
2023-08-19 2:23 ` Guru Das Srinagesh
2023-08-10 18:55 ` Guru Das Srinagesh
2023-08-15 21:06 ` Krzysztof Kozlowski
2023-08-16 17:15 ` Guru Das Srinagesh
2023-08-18 8:33 ` Neil Armstrong
2023-08-19 1:48 ` Guru Das Srinagesh [this message]
2023-08-18 8:43 ` Krzysztof Kozlowski
2023-08-18 19:46 ` Bjorn Andersson
2023-08-19 7:50 ` Krzysztof Kozlowski
2023-08-19 1:33 ` Guru Das Srinagesh
2023-08-19 7:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230819014813.GB22393@quicinc.com \
--to=quic_gurus@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas@fjasle.eu \
--cc=quic_pkondeti@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®