From: Ming Qian <ming.qian@nxp.com>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, eagle.zhou@nxp.com, tao.jiang_2@nxp.com,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH] wait: don't wake up freezable wait by freezing fake signal
Date: Tue, 22 Aug 2023 15:45:47 +0800 [thread overview]
Message-ID: <20230822074547.8037-1-ming.qian@nxp.com> (raw)
kernel may try to wake up task with fake signal when freezing task,
if the task is waiting event using wait_event_freezable,
it's better to freeze the wait, instead of breaking it.
otherwise the caller may need to retry the wait,
maybe like below code:
if (rc == -ERESTARTSYS && freezing(current)) {
clear_thread_flag(TIF_SIGPENDING);
goto again;
}
Signed-off-by: TaoJiang <tao.jiang_2@nxp.com>
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
include/linux/wait.h | 9 +++++++--
kernel/sched/wait.c | 14 ++++++++++++++
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/include/linux/wait.h b/include/linux/wait.h
index 5ec7739400f4..975ee67f259a 100644
--- a/include/linux/wait.h
+++ b/include/linux/wait.h
@@ -287,6 +287,7 @@ static inline void wake_up_pollfree(struct wait_queue_head *wq_head)
(state & (TASK_INTERRUPTIBLE | TASK_WAKEKILL)))
extern void init_wait_entry(struct wait_queue_entry *wq_entry, int flags);
+bool freezing_wait(struct wait_queue_entry *wq_entry, int state);
/*
* The below macro ___wait_event() has an explicit shadow of the __ret
@@ -314,8 +315,12 @@ extern void init_wait_entry(struct wait_queue_entry *wq_entry, int flags);
break; \
\
if (___wait_is_interruptible(state) && __int) { \
- __ret = __int; \
- goto __out; \
+ if (unlikely(freezing_wait(&__wq_entry, state))) { \
+ clear_thread_flag(TIF_SIGPENDING); \
+ } else { \
+ __ret = __int; \
+ goto __out; \
+ } \
} \
\
cmd; \
diff --git a/kernel/sched/wait.c b/kernel/sched/wait.c
index 802d98cf2de3..37c3b2bc1fc9 100644
--- a/kernel/sched/wait.c
+++ b/kernel/sched/wait.c
@@ -5,6 +5,8 @@
* (C) 2004 Nadia Yvette Chambers, Oracle
*/
+#include <linux/freezer.h>
+
void __init_waitqueue_head(struct wait_queue_head *wq_head, const char *name, struct lock_class_key *key)
{
spin_lock_init(&wq_head->lock);
@@ -484,3 +486,15 @@ int woken_wake_function(struct wait_queue_entry *wq_entry, unsigned mode, int sy
return default_wake_function(wq_entry, mode, sync, key);
}
EXPORT_SYMBOL(woken_wake_function);
+
+bool freezing_wait(struct wait_queue_entry *wq_entry, int state)
+{
+ if (!(state & TASK_FREEZABLE))
+ return false;
+ if (fatal_signal_pending(wq_entry->private))
+ return false;
+ if (unlikely(freezing(wq_entry->private)))
+ return true;
+ return false;
+}
+EXPORT_SYMBOL(freezing_wait);
--
2.38.1
next reply other threads:[~2023-08-22 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 7:45 Ming Qian [this message]
2023-09-25 10:08 ` Peter Zijlstra
2023-09-26 2:43 ` [EXT] " Ming Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822074547.8037-1-ming.qian@nxp.com \
--to=ming.qian@nxp.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=eagle.zhou@nxp.com \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tao.jiang_2@nxp.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®