From: Peter Zijlstra <peterz@infradead.org>
To: Ming Qian <ming.qian@nxp.com>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com, eagle.zhou@nxp.com,
tao.jiang_2@nxp.com, linux-imx@nxp.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] wait: don't wake up freezable wait by freezing fake signal
Date: Mon, 25 Sep 2023 12:08:14 +0200 [thread overview]
Message-ID: <20230925100814.GA31921@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20230822074547.8037-1-ming.qian@nxp.com>
On Tue, Aug 22, 2023 at 03:45:47PM +0800, Ming Qian wrote:
> kernel may try to wake up task with fake signal when freezing task,
> if the task is waiting event using wait_event_freezable,
> it's better to freeze the wait, instead of breaking it.
>
> otherwise the caller may need to retry the wait,
> maybe like below code:
>
> if (rc == -ERESTARTSYS && freezing(current)) {
> clear_thread_flag(TIF_SIGPENDING);
> goto again;
> }
I'm not sure I get it -- is there an actual problem, or are you trying
to optimize something?
next prev parent reply other threads:[~2023-09-25 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 7:45 Ming Qian
2023-09-25 10:08 ` Peter Zijlstra [this message]
2023-09-26 2:43 ` [EXT] " Ming Qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230925100814.GA31921@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=eagle.zhou@nxp.com \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=ming.qian@nxp.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tao.jiang_2@nxp.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®