* [PATCH 0/2] Small fixes for block t10-pi [not found] <CGME20230811101910epcas5p30f4711f8d7da7bcb716d3a4d71978859@epcas5p3.samsung.com> @ 2023-08-11 15:33 ` Ankit Kumar [not found] ` <CGME20230811101911epcas5p1b090eea2adf03e143ef6445a32278295@epcas5p1.samsung.com> ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Ankit Kumar @ 2023-08-11 15:33 UTC (permalink / raw) To: Jens Axboe, Keith Busch, Martin K. Petersen Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel This series has two patches that: - Removes redundant T10_PI_TYPE2_PROTECTION condition check during t10_pi_verify. - Removes duplicate module license introduced in an earlier commit. Ankit Kumar (2): block:t10-pi: remove redundant Type2 check during t10 PI verify block:t10-pi: remove duplicate module license block/t10-pi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20230811101911epcas5p1b090eea2adf03e143ef6445a32278295@epcas5p1.samsung.com>]
* [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify [not found] ` <CGME20230811101911epcas5p1b090eea2adf03e143ef6445a32278295@epcas5p1.samsung.com> @ 2023-08-11 15:33 ` Ankit Kumar 2023-08-14 1:19 ` Martin K. Petersen 0 siblings, 1 reply; 6+ messages in thread From: Ankit Kumar @ 2023-08-11 15:33 UTC (permalink / raw) To: Jens Axboe, Martin K. Petersen, Keith Busch Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel T10_PI_TYPE2_PROTECTION is neither used to generate nor verify crc and ip. Remove this redundant check. Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> --- block/t10-pi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/t10-pi.c b/block/t10-pi.c index 914d8cddd43a..bf0bba01417f 100644 --- a/block/t10-pi.c +++ b/block/t10-pi.c @@ -64,8 +64,7 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter, struct t10_pi_tuple *pi = iter->prot_buf; __be16 csum; - if (type == T10_PI_TYPE1_PROTECTION || - type == T10_PI_TYPE2_PROTECTION) { + if (type == T10_PI_TYPE1_PROTECTION) { if (pi->app_tag == T10_PI_APP_ESCAPE) goto next; -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify 2023-08-11 15:33 ` [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify Ankit Kumar @ 2023-08-14 1:19 ` Martin K. Petersen 0 siblings, 0 replies; 6+ messages in thread From: Martin K. Petersen @ 2023-08-14 1:19 UTC (permalink / raw) To: Ankit Kumar Cc: Jens Axboe, Martin K. Petersen, Keith Busch, gost.dev, linux-block, linux-kernel Ankit, > T10_PI_TYPE2_PROTECTION is neither used to generate nor verify > crc and ip. Remove this redundant check. Remnant from when this code was moved out of SCSI. Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20230811101913epcas5p3a007d4594f5313a04ed5b6414aeb5b61@epcas5p3.samsung.com>]
* [PATCH 2/2] block:t10-pi: remove duplicate module license [not found] ` <CGME20230811101913epcas5p3a007d4594f5313a04ed5b6414aeb5b61@epcas5p3.samsung.com> @ 2023-08-11 15:33 ` Ankit Kumar 2023-08-14 1:19 ` Martin K. Petersen 0 siblings, 1 reply; 6+ messages in thread From: Ankit Kumar @ 2023-08-11 15:33 UTC (permalink / raw) To: Jens Axboe, Martin K. Petersen, Keith Busch Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel Remove duplicate MODULE_LICENSE("GPL") from t10-pi.c Fixes: a7d4383f17e1 ("block: add pi for extended integrity") Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com> --- block/t10-pi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/t10-pi.c b/block/t10-pi.c index bf0bba01417f..042f21b0e2e5 100644 --- a/block/t10-pi.c +++ b/block/t10-pi.c @@ -471,4 +471,3 @@ const struct blk_integrity_profile ext_pi_type3_crc64 = { EXPORT_SYMBOL_GPL(ext_pi_type3_crc64); MODULE_LICENSE("GPL"); -MODULE_LICENSE("GPL"); -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] block:t10-pi: remove duplicate module license 2023-08-11 15:33 ` [PATCH 2/2] block:t10-pi: remove duplicate module license Ankit Kumar @ 2023-08-14 1:19 ` Martin K. Petersen 0 siblings, 0 replies; 6+ messages in thread From: Martin K. Petersen @ 2023-08-14 1:19 UTC (permalink / raw) To: Ankit Kumar Cc: Jens Axboe, Martin K. Petersen, Keith Busch, gost.dev, linux-block, linux-kernel Ankit, > Remove duplicate MODULE_LICENSE("GPL") from t10-pi.c > Fixes: a7d4383f17e1 ("block: add pi for extended integrity") Looks fine. Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com> -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Small fixes for block t10-pi 2023-08-11 15:33 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar [not found] ` <CGME20230811101911epcas5p1b090eea2adf03e143ef6445a32278295@epcas5p1.samsung.com> [not found] ` <CGME20230811101913epcas5p3a007d4594f5313a04ed5b6414aeb5b61@epcas5p3.samsung.com> @ 2023-08-22 11:52 ` Ankit Kumar 2 siblings, 0 replies; 6+ messages in thread From: Ankit Kumar @ 2023-08-22 11:52 UTC (permalink / raw) To: Jens Axboe, Martin K. Petersen Cc: kbusch, linux-block, linux-kernel, gost.dev [-- Attachment #1: Type: text/plain, Size: 595 bytes --] On Fri, Aug 11, 2023 at 09:03:11PM +0530, Ankit Kumar wrote: > This series has two patches that: > - Removes redundant T10_PI_TYPE2_PROTECTION condition check during > t10_pi_verify. > - Removes duplicate module license introduced in an earlier commit. > > Ankit Kumar (2): > block:t10-pi: remove redundant Type2 check during t10 PI verify > block:t10-pi: remove duplicate module license > > block/t10-pi.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > -- > 2.25.1 > > Hi Jens, These two patches have been reviewed by Martin. Can you please take a look. Ankit [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-23 6:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20230811101910epcas5p30f4711f8d7da7bcb716d3a4d71978859@epcas5p3.samsung.com>
2023-08-11 15:33 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar
[not found] ` <CGME20230811101911epcas5p1b090eea2adf03e143ef6445a32278295@epcas5p1.samsung.com>
2023-08-11 15:33 ` [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify Ankit Kumar
2023-08-14 1:19 ` Martin K. Petersen
[not found] ` <CGME20230811101913epcas5p3a007d4594f5313a04ed5b6414aeb5b61@epcas5p3.samsung.com>
2023-08-11 15:33 ` [PATCH 2/2] block:t10-pi: remove duplicate module license Ankit Kumar
2023-08-14 1:19 ` Martin K. Petersen
2023-08-22 11:52 ` [PATCH 0/2] Small fixes for block t10-pi Ankit Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®