mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] media: i2c: max9286: Remove an incorrect fwnode_handle_put() call
@ 2023-08-30 20:57 Christophe JAILLET
  2023-08-31  7:13 ` Laurent Pinchart
  2023-08-31  8:10 ` Jacopo Mondi
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2023-08-30 20:57 UTC (permalink / raw)
  To: Jacopo Mondi, Kieran Bingham, Laurent Pinchart,
	Niklas Söderlund, Mauro Carvalho Chehab, Sakari Ailus
  Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-media

The commit in Fixes has removed an fwnode_handle_put() call in the error
handling path of max9286_v4l2_register().

Remove the same call from max9286_v4l2_unregister().

Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/media/i2c/max9286.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index f27a69b1b727..fc1cf196ef01 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1110,7 +1110,6 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
 
 static void max9286_v4l2_unregister(struct max9286_priv *priv)
 {
-	fwnode_handle_put(priv->sd.fwnode);
 	v4l2_ctrl_handler_free(&priv->ctrls);
 	v4l2_async_unregister_subdev(&priv->sd);
 	max9286_v4l2_notifier_unregister(priv);
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: i2c: max9286: Remove an incorrect fwnode_handle_put() call
  2023-08-30 20:57 [PATCH] media: i2c: max9286: Remove an incorrect fwnode_handle_put() call Christophe JAILLET
@ 2023-08-31  7:13 ` Laurent Pinchart
  2023-08-31  8:10 ` Jacopo Mondi
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2023-08-31  7:13 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: Jacopo Mondi, Kieran Bingham, Niklas Söderlund,
	Mauro Carvalho Chehab, Sakari Ailus, linux-kernel,
	kernel-janitors, linux-media

Hi Christophe,

Thank you for the patch.

On Wed, Aug 30, 2023 at 10:57:36PM +0200, Christophe JAILLET wrote:
> The commit in Fixes has removed an fwnode_handle_put() call in the error
> handling path of max9286_v4l2_register().
> 
> Remove the same call from max9286_v4l2_unregister().
> 
> Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
>  drivers/media/i2c/max9286.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index f27a69b1b727..fc1cf196ef01 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1110,7 +1110,6 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
>  
>  static void max9286_v4l2_unregister(struct max9286_priv *priv)
>  {
> -	fwnode_handle_put(priv->sd.fwnode);
>  	v4l2_ctrl_handler_free(&priv->ctrls);
>  	v4l2_async_unregister_subdev(&priv->sd);
>  	max9286_v4l2_notifier_unregister(priv);

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] media: i2c: max9286: Remove an incorrect fwnode_handle_put() call
  2023-08-30 20:57 [PATCH] media: i2c: max9286: Remove an incorrect fwnode_handle_put() call Christophe JAILLET
  2023-08-31  7:13 ` Laurent Pinchart
@ 2023-08-31  8:10 ` Jacopo Mondi
  1 sibling, 0 replies; 3+ messages in thread
From: Jacopo Mondi @ 2023-08-31  8:10 UTC (permalink / raw)
  To: Christophe JAILLET
  Cc: Jacopo Mondi, Kieran Bingham, Laurent Pinchart,
	Niklas Söderlund, Mauro Carvalho Chehab, Sakari Ailus,
	linux-kernel, kernel-janitors, linux-media

Hi Christophe,

On Wed, Aug 30, 2023 at 10:57:36PM +0200, Christophe JAILLET wrote:
> The commit in Fixes has removed an fwnode_handle_put() call in the error
> handling path of max9286_v4l2_register().
>
> Remove the same call from max9286_v4l2_unregister().
>
> Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>

Thanks
  j

> ---
>  drivers/media/i2c/max9286.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index f27a69b1b727..fc1cf196ef01 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1110,7 +1110,6 @@ static int max9286_v4l2_register(struct max9286_priv *priv)
>
>  static void max9286_v4l2_unregister(struct max9286_priv *priv)
>  {
> -	fwnode_handle_put(priv->sd.fwnode);
>  	v4l2_ctrl_handler_free(&priv->ctrls);
>  	v4l2_async_unregister_subdev(&priv->sd);
>  	max9286_v4l2_notifier_unregister(priv);
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-31  8:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 20:57 [PATCH] media: i2c: max9286: Remove an incorrect fwnode_handle_put() call Christophe JAILLET
2023-08-31  7:13 ` Laurent Pinchart
2023-08-31  8:10 ` Jacopo Mondi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®