mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Small fixes for block t10-pi
       [not found] <CGME20230908063508epcas5p12fbca2a5723fa518489cb223ba24ccae@epcas5p1.samsung.com>
@ 2023-09-08 11:52 ` Ankit Kumar
       [not found]   ` <CGME20230908063510epcas5p46aa338154cc48041c5d28dbead88c97c@epcas5p4.samsung.com>
       [not found]   ` <CGME20230908063512epcas5p42b8a72d4001d041ed15ee559ee61f4c8@epcas5p4.samsung.com>
  0 siblings, 2 replies; 3+ messages in thread
From: Ankit Kumar @ 2023-09-08 11:52 UTC (permalink / raw)
  To: Jens Axboe, Keith Busch, Martin K. Petersen
  Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel

This series has two patches that:
 - Removes redundant T10_PI_TYPE2_PROTECTION condition check during
   t10_pi_verify.
 - Removes duplicate module license introduced in an earlier commit.

v2:
 - Added Reviewed-by tag for Martin K. Petersen.

Ankit Kumar (2):
  block:t10-pi: remove redundant Type2 check during t10 PI verify
  block:t10-pi: remove duplicate module license

 block/t10-pi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify
       [not found]   ` <CGME20230908063510epcas5p46aa338154cc48041c5d28dbead88c97c@epcas5p4.samsung.com>
@ 2023-09-08 11:52     ` Ankit Kumar
  0 siblings, 0 replies; 3+ messages in thread
From: Ankit Kumar @ 2023-09-08 11:52 UTC (permalink / raw)
  To: Jens Axboe, Martin K. Petersen, Keith Busch
  Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel

T10_PI_TYPE2_PROTECTION is neither used to generate nor verify
crc and ip. This remained since T10 PI code was moved out of SCSI.

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/t10-pi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/t10-pi.c b/block/t10-pi.c
index 914d8cddd43a..bf0bba01417f 100644
--- a/block/t10-pi.c
+++ b/block/t10-pi.c
@@ -64,8 +64,7 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter,
 		struct t10_pi_tuple *pi = iter->prot_buf;
 		__be16 csum;
 
-		if (type == T10_PI_TYPE1_PROTECTION ||
-		    type == T10_PI_TYPE2_PROTECTION) {
+		if (type == T10_PI_TYPE1_PROTECTION) {
 			if (pi->app_tag == T10_PI_APP_ESCAPE)
 				goto next;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 2/2] block:t10-pi: remove duplicate module license
       [not found]   ` <CGME20230908063512epcas5p42b8a72d4001d041ed15ee559ee61f4c8@epcas5p4.samsung.com>
@ 2023-09-08 11:52     ` Ankit Kumar
  0 siblings, 0 replies; 3+ messages in thread
From: Ankit Kumar @ 2023-09-08 11:52 UTC (permalink / raw)
  To: Jens Axboe, Martin K. Petersen, Keith Busch
  Cc: gost.dev, Ankit Kumar, linux-block, linux-kernel

Remove duplicate MODULE_LICENSE("GPL") from t10-pi.c
Fixes: a7d4383f17e1 ("block: add pi for extended integrity")

Signed-off-by: Ankit Kumar <ankit.kumar@samsung.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
---
 block/t10-pi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/block/t10-pi.c b/block/t10-pi.c
index bf0bba01417f..042f21b0e2e5 100644
--- a/block/t10-pi.c
+++ b/block/t10-pi.c
@@ -471,4 +471,3 @@ const struct blk_integrity_profile ext_pi_type3_crc64 = {
 EXPORT_SYMBOL_GPL(ext_pi_type3_crc64);
 
 MODULE_LICENSE("GPL");
-MODULE_LICENSE("GPL");
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-08  7:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20230908063508epcas5p12fbca2a5723fa518489cb223ba24ccae@epcas5p1.samsung.com>
2023-09-08 11:52 ` [PATCH v2 0/2] Small fixes for block t10-pi Ankit Kumar
     [not found]   ` <CGME20230908063510epcas5p46aa338154cc48041c5d28dbead88c97c@epcas5p4.samsung.com>
2023-09-08 11:52     ` [PATCH v2 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify Ankit Kumar
     [not found]   ` <CGME20230908063512epcas5p42b8a72d4001d041ed15ee559ee61f4c8@epcas5p4.samsung.com>
2023-09-08 11:52     ` [PATCH v2 2/2] block:t10-pi: remove duplicate module license Ankit Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®