* [PATCH] signal: complete_signal: use __for_each_thread()
@ 2023-09-09 16:45 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2023-09-09 16:45 UTC (permalink / raw)
To: Andrew Morton; +Cc: Eric W. Biederman, linux-kernel
do/while_each_thread should be avoided when possible.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
kernel/signal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/signal.c b/kernel/signal.c
index fc276fc07d87..ccfc3ded5672 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1058,12 +1058,11 @@ static void complete_signal(int sig, struct task_struct *p, enum pid_type type)
signal->flags = SIGNAL_GROUP_EXIT;
signal->group_exit_code = sig;
signal->group_stop_count = 0;
- t = p;
- do {
+ __for_each_thread(signal, t) {
task_clear_jobctl_pending(t, JOBCTL_PENDING_MASK);
sigaddset(&t->pending.signal, SIGKILL);
signal_wake_up(t, 1);
- } while_each_thread(p, t);
+ }
return;
}
}
--
2.25.1.362.g51ebf55
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-09-09 16:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-09 16:45 [PATCH] signal: complete_signal: use __for_each_thread() Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®