* [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode
@ 2023-09-12 13:27 Richard Fitzgerald
2023-09-13 7:42 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Richard Fitzgerald @ 2023-09-12 13:27 UTC (permalink / raw)
To: tiwai; +Cc: alsa-devel, patches, linux-kernel, Richard Fitzgerald
Do not allow the CS35L56 to be put into its lowest power
"hibernation" mode. This only affects I2C because "hibernation"
is already disabled on SPI.
Recent firmwares need a different wake-up sequence. Until
that sequence has been specified, the chip "hibernation" mode
must be disabled otherwise it can intermittently fail to wake.
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
---
sound/pci/hda/cs35l56_hda_i2c.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/cs35l56_hda_i2c.c b/sound/pci/hda/cs35l56_hda_i2c.c
index 83e4acdd89ac..757a4d193e0f 100644
--- a/sound/pci/hda/cs35l56_hda_i2c.c
+++ b/sound/pci/hda/cs35l56_hda_i2c.c
@@ -21,7 +21,6 @@ static int cs35l56_hda_i2c_probe(struct i2c_client *clt)
return -ENOMEM;
cs35l56->base.dev = &clt->dev;
- cs35l56->base.can_hibernate = true;
cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c);
if (IS_ERR(cs35l56->base.regmap)) {
ret = PTR_ERR(cs35l56->base.regmap);
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode
2023-09-12 13:27 [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode Richard Fitzgerald
@ 2023-09-13 7:42 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2023-09-13 7:42 UTC (permalink / raw)
To: Richard Fitzgerald; +Cc: tiwai, alsa-devel, patches, linux-kernel
On Tue, 12 Sep 2023 15:27:39 +0200,
Richard Fitzgerald wrote:
>
> Do not allow the CS35L56 to be put into its lowest power
> "hibernation" mode. This only affects I2C because "hibernation"
> is already disabled on SPI.
>
> Recent firmwares need a different wake-up sequence. Until
> that sequence has been specified, the chip "hibernation" mode
> must be disabled otherwise it can intermittently fail to wake.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-13 7:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-12 13:27 [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode Richard Fitzgerald
2023-09-13 7:42 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®