* [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2
@ 2023-09-18 10:07 Markus Schneider-Pargmann
2023-09-19 12:02 ` AngeloGioacchino Del Regno
2023-10-17 8:43 ` Markus Schneider-Pargmann
0 siblings, 2 replies; 3+ messages in thread
From: Markus Schneider-Pargmann @ 2023-09-18 10:07 UTC (permalink / raw)
To: Daniel Lezcano, Rafael J . Wysocki, Amit Kucheria, Zhang Rui,
Matthias Brugger
Cc: AngeloGioacchino Del Regno, Frank Wunderlich, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek,
Markus Schneider-Pargmann, Frank Wunderlich
Fix the probe function to call mtk_thermal_release_periodic_ts for
everything != MTK_THERMAL_V1. This was accidentally changed from V1
to V2 in the original patch.
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Closes: https://lore.kernel.org/lkml/B0B3775B-B8D1-4284-814F-4F41EC22F532@public-files.de/
Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Closes: https://lore.kernel.org/lkml/07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org/
Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
---
drivers/thermal/mediatek/auxadc_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
index 843214d30bd8..8b0edb204844 100644
--- a/drivers/thermal/mediatek/auxadc_thermal.c
+++ b/drivers/thermal/mediatek/auxadc_thermal.c
@@ -1267,7 +1267,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
mtk_thermal_turn_on_buffer(mt, apmixed_base);
- if (mt->conf->version != MTK_THERMAL_V2)
+ if (mt->conf->version != MTK_THERMAL_V1)
mtk_thermal_release_periodic_ts(mt, auxadc_base);
if (mt->conf->version == MTK_THERMAL_V1)
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2
2023-09-18 10:07 [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2 Markus Schneider-Pargmann
@ 2023-09-19 12:02 ` AngeloGioacchino Del Regno
2023-10-17 8:43 ` Markus Schneider-Pargmann
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-09-19 12:02 UTC (permalink / raw)
To: Markus Schneider-Pargmann, Daniel Lezcano, Rafael J . Wysocki,
Amit Kucheria, Zhang Rui, Matthias Brugger
Cc: Frank Wunderlich, linux-pm, linux-kernel, linux-arm-kernel,
linux-mediatek, Frank Wunderlich
Il 18/09/23 12:07, Markus Schneider-Pargmann ha scritto:
> Fix the probe function to call mtk_thermal_release_periodic_ts for
> everything != MTK_THERMAL_V1. This was accidentally changed from V1
> to V2 in the original patch.
>
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Closes: https://lore.kernel.org/lkml/B0B3775B-B8D1-4284-814F-4F41EC22F532@public-files.de/
> Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Closes: https://lore.kernel.org/lkml/07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org/
> Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
I have no idea how it happened that I didn't notice that mistake.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2
2023-09-18 10:07 [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2 Markus Schneider-Pargmann
2023-09-19 12:02 ` AngeloGioacchino Del Regno
@ 2023-10-17 8:43 ` Markus Schneider-Pargmann
1 sibling, 0 replies; 3+ messages in thread
From: Markus Schneider-Pargmann @ 2023-10-17 8:43 UTC (permalink / raw)
To: Daniel Lezcano, Rafael J . Wysocki, Amit Kucheria, Zhang Rui,
Matthias Brugger
Cc: AngeloGioacchino Del Regno, Frank Wunderlich, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek, Frank Wunderlich
Hi Daniel,
On Mon, Sep 18, 2023 at 12:07:06PM +0200, Markus Schneider-Pargmann wrote:
> Fix the probe function to call mtk_thermal_release_periodic_ts for
> everything != MTK_THERMAL_V1. This was accidentally changed from V1
> to V2 in the original patch.
>
> Reported-by: Frank Wunderlich <frank-w@public-files.de>
> Closes: https://lore.kernel.org/lkml/B0B3775B-B8D1-4284-814F-4F41EC22F532@public-files.de/
> Reported-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Closes: https://lore.kernel.org/lkml/07a569b9-e691-64ea-dd65-3b49842af33d@linaro.org/
> Fixes: 33140e668b10 ("thermal/drivers/mediatek: Control buffer enablement tweaks")
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Did you have a chance to have a look at this fix and the other one for
auxadc_thermal?
https://lore.kernel.org/linux-arm-kernel/20230907112018.52811-1-linux@fw-web.de/
Thanks!
Best,
Markus
> ---
> drivers/thermal/mediatek/auxadc_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/mediatek/auxadc_thermal.c b/drivers/thermal/mediatek/auxadc_thermal.c
> index 843214d30bd8..8b0edb204844 100644
> --- a/drivers/thermal/mediatek/auxadc_thermal.c
> +++ b/drivers/thermal/mediatek/auxadc_thermal.c
> @@ -1267,7 +1267,7 @@ static int mtk_thermal_probe(struct platform_device *pdev)
>
> mtk_thermal_turn_on_buffer(mt, apmixed_base);
>
> - if (mt->conf->version != MTK_THERMAL_V2)
> + if (mt->conf->version != MTK_THERMAL_V1)
> mtk_thermal_release_periodic_ts(mt, auxadc_base);
>
> if (mt->conf->version == MTK_THERMAL_V1)
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-17 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 10:07 [PATCH] thermal/drivers/mediatek: Fix probe for THERMAL_V2 Markus Schneider-Pargmann
2023-09-19 12:02 ` AngeloGioacchino Del Regno
2023-10-17 8:43 ` Markus Schneider-Pargmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®