mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: <linux-kernel@vger.kernel.org>,
	James Schulman <james.schulman@cirrus.com>,
	David Rhodes <david.rhodes@cirrus.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	<alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
	Lee Jones <lee@kernel.org>
Subject: Re: [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement
Date: Tue, 19 Sep 2023 08:50:57 +0000	[thread overview]
Message-ID: <20230919085057.GA103419@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20230918193042.31524-1-rdunlap@infradead.org>

On Mon, Sep 18, 2023 at 12:30:42PM -0700, Randy Dunlap wrote:
> The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ
> to what the core driver selects in order to provide this API.
> This fixes a build error:
> 
> aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work':
> cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
> 
> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
> Cc: James Schulman <james.schulman@cirrus.com>
> Cc: David Rhodes <david.rhodes@cirrus.com>
> Cc: Richard Fitzgerald <rf@opensource.cirrus.com>
> Cc: alsa-devel@alsa-project.org
> Cc: patches@opensource.cirrus.com
> Cc: Lee Jones <lee@kernel.org>
> ---

Someone already sent a fix for this, that is awaiting review:

https://lore.kernel.org/lkml/tencent_E54C7156F583E15FFE320E576E3389C39A08@qq.com/

But just incase this one gets picked up:

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

      reply	other threads:[~2023-09-19  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 19:30 Randy Dunlap
2023-09-19  8:50 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230919085057.GA103419@ediswmail.ad.cirrus.com \
    --to=ckeepax@opensource.cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.rhodes@cirrus.com \
    --cc=james.schulman@cirrus.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=rdunlap@infradead.org \
    --cc=rf@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®