* [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement
@ 2023-09-18 19:30 Randy Dunlap
2023-09-19 8:50 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-09-18 19:30 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Charles Keepax, James Schulman, David Rhodes,
Richard Fitzgerald, alsa-devel, patches, Lee Jones
The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ
to what the core driver selects in order to provide this API.
This fixes a build error:
aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work':
cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: James Schulman <james.schulman@cirrus.com>
Cc: David Rhodes <david.rhodes@cirrus.com>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: alsa-devel@alsa-project.org
Cc: patches@opensource.cirrus.com
Cc: Lee Jones <lee@kernel.org>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -- a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -241,6 +241,7 @@ config MFD_CS42L43
tristate
select MFD_CORE
select REGMAP
+ select REGMAP_IRQ
config MFD_CS42L43_I2C
tristate "Cirrus Logic CS42L43 (I2C)"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement
2023-09-18 19:30 [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement Randy Dunlap
@ 2023-09-19 8:50 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2023-09-19 8:50 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, James Schulman, David Rhodes, Richard Fitzgerald,
alsa-devel, patches, Lee Jones
On Mon, Sep 18, 2023 at 12:30:42PM -0700, Randy Dunlap wrote:
> The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ
> to what the core driver selects in order to provide this API.
> This fixes a build error:
>
> aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work':
> cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
>
> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Charles Keepax <ckeepax@opensource.cirrus.com>
> Cc: James Schulman <james.schulman@cirrus.com>
> Cc: David Rhodes <david.rhodes@cirrus.com>
> Cc: Richard Fitzgerald <rf@opensource.cirrus.com>
> Cc: alsa-devel@alsa-project.org
> Cc: patches@opensource.cirrus.com
> Cc: Lee Jones <lee@kernel.org>
> ---
Someone already sent a fix for this, that is awaiting review:
https://lore.kernel.org/lkml/tencent_E54C7156F583E15FFE320E576E3389C39A08@qq.com/
But just incase this one gets picked up:
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-19 8:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-18 19:30 [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement Randy Dunlap
2023-09-19 8:50 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®