* [PATCH] kprobes: Remove unnecessary initial values of variables
@ 2023-09-19 1:28 Li zeming
2023-09-19 5:19 ` Masami Hiramatsu
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2023-09-19 1:28 UTC (permalink / raw)
To: naveen.n.rao, anil.s.keshavamurthy, davem, mhiramat
Cc: linux-kernel, linux-trace-kernel, Li zeming
ri and sym is assigned first, so it does not need to initialize the
assignment.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
kernel/kprobes.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index ca385b61d546..82b2a366d496 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -1990,7 +1990,7 @@ NOKPROBE_SYMBOL(__kretprobe_find_ret_addr);
unsigned long kretprobe_find_ret_addr(struct task_struct *tsk, void *fp,
struct llist_node **cur)
{
- struct kretprobe_instance *ri = NULL;
+ struct kretprobe_instance *ri;
kprobe_opcode_t *ret;
if (WARN_ON_ONCE(!cur))
@@ -2817,7 +2817,7 @@ static int show_kprobe_addr(struct seq_file *pi, void *v)
{
struct hlist_head *head;
struct kprobe *p, *kp;
- const char *sym = NULL;
+ const char *sym;
unsigned int i = *(loff_t *) v;
unsigned long offset = 0;
char *modname, namebuf[KSYM_NAME_LEN];
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] kprobes: Remove unnecessary initial values of variables
2023-09-19 1:28 [PATCH] kprobes: Remove unnecessary initial values of variables Li zeming
@ 2023-09-19 5:19 ` Masami Hiramatsu
0 siblings, 0 replies; 2+ messages in thread
From: Masami Hiramatsu @ 2023-09-19 5:19 UTC (permalink / raw)
To: Li zeming
Cc: naveen.n.rao, anil.s.keshavamurthy, davem, linux-kernel,
linux-trace-kernel
On Tue, 19 Sep 2023 09:28:23 +0800
Li zeming <zeming@nfschina.com> wrote:
> ri and sym is assigned first, so it does not need to initialize the
> assignment.
>
Yes, thanks for fixing!
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
> kernel/kprobes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index ca385b61d546..82b2a366d496 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1990,7 +1990,7 @@ NOKPROBE_SYMBOL(__kretprobe_find_ret_addr);
> unsigned long kretprobe_find_ret_addr(struct task_struct *tsk, void *fp,
> struct llist_node **cur)
> {
> - struct kretprobe_instance *ri = NULL;
> + struct kretprobe_instance *ri;
> kprobe_opcode_t *ret;
>
> if (WARN_ON_ONCE(!cur))
> @@ -2817,7 +2817,7 @@ static int show_kprobe_addr(struct seq_file *pi, void *v)
> {
> struct hlist_head *head;
> struct kprobe *p, *kp;
> - const char *sym = NULL;
> + const char *sym;
> unsigned int i = *(loff_t *) v;
> unsigned long offset = 0;
> char *modname, namebuf[KSYM_NAME_LEN];
> --
> 2.18.2
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-19 5:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-19 1:28 [PATCH] kprobes: Remove unnecessary initial values of variables Li zeming
2023-09-19 5:19 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome