* [PATCH] sched: fix warning in bandwidth distribution
@ 2023-09-20 0:05 Josh Don
2023-09-20 1:14 ` kernel test robot
2023-09-20 19:28 ` kernel test robot
0 siblings, 2 replies; 3+ messages in thread
From: Josh Don @ 2023-09-20 0:05 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot
Cc: Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider, linux-kernel,
Josh Don
We've observed the following warning being hit in
distribute_cfs_runtime():
SCHED_WARN_ON(cfs_rq->runtime_remaining > 0)
We have the following race:
- cpu0: running bandwidth distribution (distribute_cfs_runtime).
Inspects the local cfs_rq and makes its runtime_remaining positive.
However, we defer unthrottling the local cfs_rq until after
considering all remote cfs_rq's.
- cpu1: starts running bandwidth distribution from the slack timer. When
it finds the cfs_rq for cpu 0 on the throttled list, it observers the
that the cfs_rq is throttled, yet is not on the CSD list, and has a
positive runtime_remaining, thus triggering the warning in
distribute_cfs_runtime.
To fix this, we can rework the local unthrottling logic to put the local
cfs_rq on a local list, so that any future bandwidth distributions will
realize that the cfs_rq is about to be unthrottled.
Signed-off-by: Josh Don <joshdon@google.com>
---
kernel/sched/fair.c | 36 +++++++++++++++++++++++++-----------
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 384900bf87eb..509bc74262ad 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5743,13 +5743,13 @@ static void unthrottle_cfs_rq_async(struct cfs_rq *cfs_rq)
static bool distribute_cfs_runtime(struct cfs_bandwidth *cfs_b)
{
- struct cfs_rq *local_unthrottle = NULL;
int this_cpu = smp_processor_id();
u64 runtime, remaining = 1;
bool throttled = false;
- struct cfs_rq *cfs_rq;
+ struct cfs_rq *cfs_rq, *tmp;
struct rq_flags rf;
struct rq *rq;
+ LIST_HEAD(local_unthrottle);
rcu_read_lock();
list_for_each_entry_rcu(cfs_rq, &cfs_b->throttled_cfs_rq,
@@ -5786,11 +5786,17 @@ static bool distribute_cfs_runtime(struct cfs_bandwidth *cfs_b)
/* we check whether we're throttled above */
if (cfs_rq->runtime_remaining > 0) {
- if (cpu_of(rq) != this_cpu ||
- SCHED_WARN_ON(local_unthrottle))
+ if (cpu_of(rq) != this_cpu) {
unthrottle_cfs_rq_async(cfs_rq);
- else
- local_unthrottle = cfs_rq;
+ } else {
+ /*
+ * We currently only expect to be unthrottling
+ * a single cfs_rq locally.
+ */
+ SCHED_WARN_ON(!list_empty(&local_unthrottle));
+ list_add_tail(&cfs_rq->throttled_csd_list,
+ &local_unthrottle);
+ }
} else {
throttled = true;
}
@@ -5798,15 +5804,23 @@ static bool distribute_cfs_runtime(struct cfs_bandwidth *cfs_b)
next:
rq_unlock_irqrestore(rq, &rf);
}
- rcu_read_unlock();
- if (local_unthrottle) {
- rq = cpu_rq(this_cpu);
+ list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
+ throttled_csd_list) {
+ struct rq *rq = rq_of(cfs_rq);
+
rq_lock_irqsave(rq, &rf);
- if (cfs_rq_throttled(local_unthrottle))
- unthrottle_cfs_rq(local_unthrottle);
+
+ list_del_init(&cfs_rq->throttled_csd_list);
+
+ if (cfs_rq_throttled(cfs_rq))
+ unthrottle_cfs_rq(cfs_rq);
+
rq_unlock_irqrestore(rq, &rf);
}
+ SCHED_WARN_ON(!list_empty(&local_unthrottle));
+
+ rcu_read_unlock();
return throttled;
}
--
2.42.0.459.ge4e396fd5e-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: fix warning in bandwidth distribution
2023-09-20 0:05 [PATCH] sched: fix warning in bandwidth distribution Josh Don
@ 2023-09-20 1:14 ` kernel test robot
2023-09-20 19:28 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-09-20 1:14 UTC (permalink / raw)
To: Josh Don, Ingo Molnar, Juri Lelli, Vincent Guittot
Cc: oe-kbuild-all, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Daniel Bristot de Oliveira, Valentin Schneider,
linux-kernel, Josh Don
Hi Josh,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on tip/master tip/auto-latest linus/master v6.6-rc2 next-20230919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Josh-Don/sched-fix-warning-in-bandwidth-distribution/20230920-080712
base: tip/sched/core
patch link: https://lore.kernel.org/r/20230920000559.3872416-1-joshdon%40google.com
patch subject: [PATCH] sched: fix warning in bandwidth distribution
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230920/202309200825.vOa3t8Sx-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230920/202309200825.vOa3t8Sx-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309200825.vOa3t8Sx-lkp@intel.com/
All warnings (new ones prefixed by >>):
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:21:23: note: in expansion of macro '__same_type'
21 | __same_type(*(ptr), void), \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/compiler_types.h:366:27: error: expression in static assertion is not an integer
366 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
| ^~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/preempt.h:12,
from arch/m68k/include/asm/irqflags.h:6,
from include/linux/irqflags.h:17,
from arch/m68k/include/asm/atomic.h:6,
from include/linux/atomic.h:7,
from include/linux/cpumask.h:13:
>> include/linux/list.h:857:64: warning: left-hand operand of comma expression has no effect [-Wunused-value]
857 | for (pos = list_first_entry(head, typeof(*pos), member), \
| ^
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/list.h:761:16: note: in definition of macro 'list_entry_is_head'
761 | (&pos->member == (head))
| ^~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/container_of.h:19:33: note: in definition of macro 'container_of'
19 | void *__mptr = (void *)(ptr); \
| ^~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:21:23: note: in expansion of macro '__same_type'
21 | __same_type(*(ptr), void), \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
vim +857 include/linux/list.h
4d70c74659d974 Andy Shevchenko 2022-11-30 753
e130816164e244 Andy Shevchenko 2020-10-15 754 /**
e130816164e244 Andy Shevchenko 2020-10-15 755 * list_entry_is_head - test if the entry points to the head of the list
e130816164e244 Andy Shevchenko 2020-10-15 756 * @pos: the type * to cursor
e130816164e244 Andy Shevchenko 2020-10-15 757 * @head: the head for your list.
e130816164e244 Andy Shevchenko 2020-10-15 758 * @member: the name of the list_head within the struct.
e130816164e244 Andy Shevchenko 2020-10-15 759 */
e130816164e244 Andy Shevchenko 2020-10-15 760 #define list_entry_is_head(pos, head, member) \
e130816164e244 Andy Shevchenko 2020-10-15 761 (&pos->member == (head))
e130816164e244 Andy Shevchenko 2020-10-15 762
^1da177e4c3f41 Linus Torvalds 2005-04-16 763 /**
^1da177e4c3f41 Linus Torvalds 2005-04-16 764 * list_for_each_entry - iterate over list of given type
8e3a67a99231f9 Randy Dunlap 2006-06-25 765 * @pos: the type * to use as a loop cursor.
^1da177e4c3f41 Linus Torvalds 2005-04-16 766 * @head: the head for your list.
3943f42c11896c Andrey Utkin 2014-11-14 767 * @member: the name of the list_head within the struct.
^1da177e4c3f41 Linus Torvalds 2005-04-16 768 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 769 #define list_for_each_entry(pos, head, member) \
93be3c2eb3371f Oleg Nesterov 2013-11-12 770 for (pos = list_first_entry(head, typeof(*pos), member); \
e130816164e244 Andy Shevchenko 2020-10-15 771 !list_entry_is_head(pos, head, member); \
8120e2e5141a42 Oleg Nesterov 2013-11-12 772 pos = list_next_entry(pos, member))
^1da177e4c3f41 Linus Torvalds 2005-04-16 773
^1da177e4c3f41 Linus Torvalds 2005-04-16 774 /**
^1da177e4c3f41 Linus Torvalds 2005-04-16 775 * list_for_each_entry_reverse - iterate backwards over list of given type.
8e3a67a99231f9 Randy Dunlap 2006-06-25 776 * @pos: the type * to use as a loop cursor.
^1da177e4c3f41 Linus Torvalds 2005-04-16 777 * @head: the head for your list.
3943f42c11896c Andrey Utkin 2014-11-14 778 * @member: the name of the list_head within the struct.
^1da177e4c3f41 Linus Torvalds 2005-04-16 779 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 780 #define list_for_each_entry_reverse(pos, head, member) \
93be3c2eb3371f Oleg Nesterov 2013-11-12 781 for (pos = list_last_entry(head, typeof(*pos), member); \
e130816164e244 Andy Shevchenko 2020-10-15 782 !list_entry_is_head(pos, head, member); \
8120e2e5141a42 Oleg Nesterov 2013-11-12 783 pos = list_prev_entry(pos, member))
^1da177e4c3f41 Linus Torvalds 2005-04-16 784
^1da177e4c3f41 Linus Torvalds 2005-04-16 785 /**
72fd4a35a82433 Robert P. J. Day 2007-02-10 786 * list_prepare_entry - prepare a pos entry for use in list_for_each_entry_continue()
^1da177e4c3f41 Linus Torvalds 2005-04-16 787 * @pos: the type * to use as a start point
^1da177e4c3f41 Linus Torvalds 2005-04-16 788 * @head: the head of the list
3943f42c11896c Andrey Utkin 2014-11-14 789 * @member: the name of the list_head within the struct.
fe96e57d77481c Randy Dunlap 2006-06-25 790 *
72fd4a35a82433 Robert P. J. Day 2007-02-10 791 * Prepares a pos entry for use as a start point in list_for_each_entry_continue().
^1da177e4c3f41 Linus Torvalds 2005-04-16 792 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 793 #define list_prepare_entry(pos, head, member) \
^1da177e4c3f41 Linus Torvalds 2005-04-16 794 ((pos) ? : list_entry(head, typeof(*pos), member))
^1da177e4c3f41 Linus Torvalds 2005-04-16 795
^1da177e4c3f41 Linus Torvalds 2005-04-16 796 /**
fe96e57d77481c Randy Dunlap 2006-06-25 797 * list_for_each_entry_continue - continue iteration over list of given type
8e3a67a99231f9 Randy Dunlap 2006-06-25 798 * @pos: the type * to use as a loop cursor.
^1da177e4c3f41 Linus Torvalds 2005-04-16 799 * @head: the head for your list.
3943f42c11896c Andrey Utkin 2014-11-14 800 * @member: the name of the list_head within the struct.
fe96e57d77481c Randy Dunlap 2006-06-25 801 *
fe96e57d77481c Randy Dunlap 2006-06-25 802 * Continue to iterate over list of given type, continuing after
fe96e57d77481c Randy Dunlap 2006-06-25 803 * the current position.
^1da177e4c3f41 Linus Torvalds 2005-04-16 804 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 805 #define list_for_each_entry_continue(pos, head, member) \
8120e2e5141a42 Oleg Nesterov 2013-11-12 806 for (pos = list_next_entry(pos, member); \
e130816164e244 Andy Shevchenko 2020-10-15 807 !list_entry_is_head(pos, head, member); \
8120e2e5141a42 Oleg Nesterov 2013-11-12 808 pos = list_next_entry(pos, member))
^1da177e4c3f41 Linus Torvalds 2005-04-16 809
768f3591e2b1cc Pavel Emelyanov 2007-09-18 810 /**
768f3591e2b1cc Pavel Emelyanov 2007-09-18 811 * list_for_each_entry_continue_reverse - iterate backwards from the given point
768f3591e2b1cc Pavel Emelyanov 2007-09-18 812 * @pos: the type * to use as a loop cursor.
768f3591e2b1cc Pavel Emelyanov 2007-09-18 813 * @head: the head for your list.
3943f42c11896c Andrey Utkin 2014-11-14 814 * @member: the name of the list_head within the struct.
768f3591e2b1cc Pavel Emelyanov 2007-09-18 815 *
768f3591e2b1cc Pavel Emelyanov 2007-09-18 816 * Start to iterate over list of given type backwards, continuing after
768f3591e2b1cc Pavel Emelyanov 2007-09-18 817 * the current position.
768f3591e2b1cc Pavel Emelyanov 2007-09-18 818 */
768f3591e2b1cc Pavel Emelyanov 2007-09-18 819 #define list_for_each_entry_continue_reverse(pos, head, member) \
8120e2e5141a42 Oleg Nesterov 2013-11-12 820 for (pos = list_prev_entry(pos, member); \
e130816164e244 Andy Shevchenko 2020-10-15 821 !list_entry_is_head(pos, head, member); \
8120e2e5141a42 Oleg Nesterov 2013-11-12 822 pos = list_prev_entry(pos, member))
768f3591e2b1cc Pavel Emelyanov 2007-09-18 823
e229c2fb3370a0 Arnaldo Carvalho de Melo 2006-03-20 824 /**
fe96e57d77481c Randy Dunlap 2006-06-25 825 * list_for_each_entry_from - iterate over list of given type from the current point
8e3a67a99231f9 Randy Dunlap 2006-06-25 826 * @pos: the type * to use as a loop cursor.
e229c2fb3370a0 Arnaldo Carvalho de Melo 2006-03-20 827 * @head: the head for your list.
3943f42c11896c Andrey Utkin 2014-11-14 828 * @member: the name of the list_head within the struct.
fe96e57d77481c Randy Dunlap 2006-06-25 829 *
fe96e57d77481c Randy Dunlap 2006-06-25 830 * Iterate over list of given type, continuing from current position.
e229c2fb3370a0 Arnaldo Carvalho de Melo 2006-03-20 831 */
e229c2fb3370a0 Arnaldo Carvalho de Melo 2006-03-20 832 #define list_for_each_entry_from(pos, head, member) \
e130816164e244 Andy Shevchenko 2020-10-15 833 for (; !list_entry_is_head(pos, head, member); \
8120e2e5141a42 Oleg Nesterov 2013-11-12 834 pos = list_next_entry(pos, member))
e229c2fb3370a0 Arnaldo Carvalho de Melo 2006-03-20 835
b862815c3ee7b4 Jiri Pirko 2017-02-03 836 /**
b862815c3ee7b4 Jiri Pirko 2017-02-03 837 * list_for_each_entry_from_reverse - iterate backwards over list of given type
b862815c3ee7b4 Jiri Pirko 2017-02-03 838 * from the current point
b862815c3ee7b4 Jiri Pirko 2017-02-03 839 * @pos: the type * to use as a loop cursor.
b862815c3ee7b4 Jiri Pirko 2017-02-03 840 * @head: the head for your list.
b862815c3ee7b4 Jiri Pirko 2017-02-03 841 * @member: the name of the list_head within the struct.
b862815c3ee7b4 Jiri Pirko 2017-02-03 842 *
b862815c3ee7b4 Jiri Pirko 2017-02-03 843 * Iterate backwards over list of given type, continuing from current position.
b862815c3ee7b4 Jiri Pirko 2017-02-03 844 */
b862815c3ee7b4 Jiri Pirko 2017-02-03 845 #define list_for_each_entry_from_reverse(pos, head, member) \
e130816164e244 Andy Shevchenko 2020-10-15 846 for (; !list_entry_is_head(pos, head, member); \
b862815c3ee7b4 Jiri Pirko 2017-02-03 847 pos = list_prev_entry(pos, member))
b862815c3ee7b4 Jiri Pirko 2017-02-03 848
^1da177e4c3f41 Linus Torvalds 2005-04-16 849 /**
^1da177e4c3f41 Linus Torvalds 2005-04-16 850 * list_for_each_entry_safe - iterate over list of given type safe against removal of list entry
8e3a67a99231f9 Randy Dunlap 2006-06-25 851 * @pos: the type * to use as a loop cursor.
^1da177e4c3f41 Linus Torvalds 2005-04-16 852 * @n: another type * to use as temporary storage
^1da177e4c3f41 Linus Torvalds 2005-04-16 853 * @head: the head for your list.
3943f42c11896c Andrey Utkin 2014-11-14 854 * @member: the name of the list_head within the struct.
^1da177e4c3f41 Linus Torvalds 2005-04-16 855 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 856 #define list_for_each_entry_safe(pos, n, head, member) \
93be3c2eb3371f Oleg Nesterov 2013-11-12 @857 for (pos = list_first_entry(head, typeof(*pos), member), \
8120e2e5141a42 Oleg Nesterov 2013-11-12 858 n = list_next_entry(pos, member); \
e130816164e244 Andy Shevchenko 2020-10-15 859 !list_entry_is_head(pos, head, member); \
8120e2e5141a42 Oleg Nesterov 2013-11-12 860 pos = n, n = list_next_entry(n, member))
^1da177e4c3f41 Linus Torvalds 2005-04-16 861
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched: fix warning in bandwidth distribution
2023-09-20 0:05 [PATCH] sched: fix warning in bandwidth distribution Josh Don
2023-09-20 1:14 ` kernel test robot
@ 2023-09-20 19:28 ` kernel test robot
1 sibling, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-09-20 19:28 UTC (permalink / raw)
To: Josh Don, Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot
Cc: oe-kbuild-all, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Daniel Bristot de Oliveira, Valentin Schneider,
linux-kernel, Josh Don
Hi Josh,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master tip/auto-latest linus/master v6.6-rc2 next-20230920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Josh-Don/sched-fix-warning-in-bandwidth-distribution/20230920-080712
base: tip/sched/core
patch link: https://lore.kernel.org/r/20230920000559.3872416-1-joshdon%40google.com
patch subject: [PATCH] sched: fix warning in bandwidth distribution
config: arm-bcm2835_defconfig (https://download.01.org/0day-ci/archive/20230921/202309210339.XihTnzE3-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230921/202309210339.XihTnzE3-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309210339.XihTnzE3-lkp@intel.com/
All errors (new ones prefixed by >>):
kernel/sched/fair.c: In function 'distribute_cfs_runtime':
kernel/sched/fair.c:5808:56: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5808 | list_add_tail(&cfs_rq->throttled_csd_list,
| ^~~~~~~~~~~~~~~~~~
| throttled_list
In file included from include/linux/container_of.h:5,
from include/linux/kernel.h:21,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:612:9: note: in expansion of macro 'list_entry'
612 | list_entry((ptr)->next, type, member)
| ^~~~~~~~~~
include/linux/list.h:857:20: note: in expansion of macro 'list_first_entry'
857 | for (pos = list_first_entry(head, typeof(*pos), member), \
| ^~~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/compiler_types.h:366:27: error: expression in static assertion is not an integer
366 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:612:9: note: in expansion of macro 'list_entry'
612 | list_entry((ptr)->next, type, member)
| ^~~~~~~~~~
include/linux/list.h:857:20: note: in expansion of macro 'list_first_entry'
857 | for (pos = list_first_entry(head, typeof(*pos), member), \
| ^~~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/limits.h:6,
from include/linux/kernel.h:16,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
| ^~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:612:9: note: in expansion of macro 'list_entry'
612 | list_entry((ptr)->next, type, member)
| ^~~~~~~~~~
include/linux/list.h:857:20: note: in expansion of macro 'list_first_entry'
857 | for (pos = list_first_entry(head, typeof(*pos), member), \
| ^~~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/kernel.h:21,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/container_of.h:19:33: note: in definition of macro 'container_of'
19 | void *__mptr = (void *)(ptr); \
| ^~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/container_of.h:5,
from include/linux/kernel.h:21,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:21:23: note: in expansion of macro '__same_type'
21 | __same_type(*(ptr), void), \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/compiler_types.h:366:27: error: expression in static assertion is not an integer
366 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/limits.h:6,
from include/linux/kernel.h:16,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
| ^~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:858:21: note: in expansion of macro 'list_next_entry'
858 | n = list_next_entry(pos, member); \
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/rculist.h:10,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/energy_model.h:5,
from kernel/sched/fair.c:23:
include/linux/list.h:857:64: warning: left-hand operand of comma expression has no effect [-Wunused-value]
857 | for (pos = list_first_entry(head, typeof(*pos), member), \
| ^
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/list.h:761:16: note: in definition of macro 'list_entry_is_head'
761 | (&pos->member == (head))
| ^~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/kernel.h:21,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/container_of.h:19:33: note: in definition of macro 'container_of'
19 | void *__mptr = (void *)(ptr); \
| ^~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/container_of.h:5,
from include/linux/kernel.h:21,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:21:23: note: in expansion of macro '__same_type'
21 | __same_type(*(ptr), void), \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/compiler_types.h:366:27: error: expression in static assertion is not an integer
366 | #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:78:56: note: in definition of macro '__static_assert'
78 | #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
| ^~~~
include/linux/container_of.h:20:9: note: in expansion of macro 'static_assert'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~~~
include/linux/container_of.h:20:23: note: in expansion of macro '__same_type'
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) || \
| ^~~~~~~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/limits.h:6,
from include/linux/kernel.h:16,
from include/linux/cpumask.h:10,
from include/linux/energy_model.h:4,
from kernel/sched/fair.c:23:
kernel/sched/fair.c:5820:34: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5820 | throttled_csd_list) {
| ^~~~~~~~~~~~~~~~~~
include/linux/stddef.h:16:58: note: in definition of macro 'offsetof'
16 | #define offsetof(TYPE, MEMBER) __builtin_offsetof(TYPE, MEMBER)
| ^~~~~~
include/linux/list.h:601:9: note: in expansion of macro 'container_of'
601 | container_of(ptr, type, member)
| ^~~~~~~~~~~~
include/linux/list.h:645:9: note: in expansion of macro 'list_entry'
645 | list_entry((pos)->member.next, typeof(*(pos)), member)
| ^~~~~~~~~~
include/linux/list.h:860:27: note: in expansion of macro 'list_next_entry'
860 | pos = n, n = list_next_entry(n, member))
| ^~~~~~~~~~~~~~~
kernel/sched/fair.c:5819:9: note: in expansion of macro 'list_for_each_entry_safe'
5819 | list_for_each_entry_safe(cfs_rq, tmp, &local_unthrottle,
| ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5825:40: error: 'struct cfs_rq' has no member named 'throttled_csd_list'; did you mean 'throttled_list'?
5825 | list_del_init(&cfs_rq->throttled_csd_list);
| ^~~~~~~~~~~~~~~~~~
| throttled_list
vim +366 include/linux/compiler_types.h
eb111869301e15 Rasmus Villemoes 2019-09-13 364
d15155824c5014 Will Deacon 2017-10-24 365 /* Are two types/vars the same type (ignoring qualifiers)? */
d15155824c5014 Will Deacon 2017-10-24 @366 #define __same_type(a, b) __builtin_types_compatible_p(typeof(a), typeof(b))
d15155824c5014 Will Deacon 2017-10-24 367
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-20 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-20 0:05 [PATCH] sched: fix warning in bandwidth distribution Josh Don
2023-09-20 1:14 ` kernel test robot
2023-09-20 19:28 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®