From: Greg KH <gregkh@linuxfoundation.org>
To: "Gupta, Nipun" <nipun.gupta@amd.com>
Cc: maz@kernel.org, tglx@linutronix.de, jgg@ziepe.ca,
linux-kernel@vger.kernel.org, git@amd.com,
harpreet.anand@amd.com, pieter.jansen-van-vuuren@amd.com,
nikhil.agarwal@amd.com, michal.simek@amd.com,
abhijit.gangurde@amd.com, srivatsa@csail.mit.edu
Subject: Re: [PATCH v4] cdx: add MSI support for CDX bus
Date: Tue, 26 Sep 2023 11:55:17 +0200 [thread overview]
Message-ID: <2023092602-zen-legal-4910@gregkh> (raw)
In-Reply-To: <6127727d-cb4e-7729-5216-83c93fbb22ee@amd.com>
On Tue, Sep 26, 2023 at 03:18:58PM +0530, Gupta, Nipun wrote:
> Hi Greg,
>
> On 9/11/2023 7:22 PM, Nipun Gupta wrote:
> > Add CDX-MSI domain per CDX controller with gic-its domain as
> > a parent, to support MSI for CDX devices. CDX devices allocate
> > MSIs from the CDX domain. Also, introduce APIs to alloc and free
> > IRQs for CDX domain.
> >
> > In CDX subsystem firmware is a controller for all devices and
> > their configuration. CDX bus controller sends all the write_msi_msg
> > commands to firmware running on RPU and the firmware interfaces with
> > actual devices to pass this information to devices
> >
> > Since, CDX controller is the only way to communicate with the Firmware
> > for MSI write info, CDX domain per controller required in contrast to
> > having a CDX domain per device.
> >
> > Co-developed-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> > Signed-off-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> > Co-developed-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> > Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
> > Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
>
> Please help in making progress on this patch. Is there anything that needs
> to be updated in this patch for CDX bus?
$ mdfrm -c ~/mail/todo/
2031 messages in /home/gregkh/mail/todo/
So perhaps help in reviewing other pending patches for other subsystems?
It's in my queue, but have been traveling for 2 weeks for conferences,
will be catching up next week when I get a chance.
Also, you need to get the msi/interrupt developers to agree with this,
why not get their review and acceptance first?
thanks,
greg k-h
next prev parent reply other threads:[~2023-09-26 9:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 13:52 Nipun Gupta
2023-09-26 9:48 ` Gupta, Nipun
2023-09-26 9:55 ` Greg KH [this message]
2023-09-26 13:06 ` Gupta, Nipun
2023-09-26 13:10 ` Gupta, Nipun
2023-10-05 10:24 ` Greg KH
2023-10-05 13:46 ` Thomas Gleixner
2023-10-05 14:00 ` Greg KH
2023-10-05 14:37 ` Gupta, Nipun
2023-10-05 14:54 ` Greg KH
2023-10-05 15:05 ` Gupta, Nipun
2023-10-07 8:43 ` Gupta, Nipun
2023-10-07 8:51 ` Greg KH
2023-10-09 4:53 ` Gupta, Nipun
2023-10-17 11:24 ` Gangurde, Abhijit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023092602-zen-legal-4910@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhijit.gangurde@amd.com \
--cc=git@amd.com \
--cc=harpreet.anand@amd.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.simek@amd.com \
--cc=nikhil.agarwal@amd.com \
--cc=nipun.gupta@amd.com \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=srivatsa@csail.mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®