From: "Gupta, Nipun" <nipun.gupta@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
maz@kernel.org, jgg@ziepe.ca, linux-kernel@vger.kernel.org,
git@amd.com, harpreet.anand@amd.com,
pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
michal.simek@amd.com, abhijit.gangurde@amd.com,
srivatsa@csail.mit.edu
Subject: Re: [PATCH v4] cdx: add MSI support for CDX bus
Date: Thu, 5 Oct 2023 20:35:28 +0530 [thread overview]
Message-ID: <99d707a3-5274-1603-d0ed-f67ce83b7e29@amd.com> (raw)
In-Reply-To: <2023100531-stick-cupped-78f6@gregkh>
On 10/5/2023 8:24 PM, Greg KH wrote:
> On Thu, Oct 05, 2023 at 08:07:35PM +0530, Gupta, Nipun wrote:
>> Hi Greg,
>>
>> On 10/5/2023 7:30 PM, Greg KH wrote:
>>> On Thu, Oct 05, 2023 at 03:46:34PM +0200, Thomas Gleixner wrote:
>>>> On Thu, Oct 05 2023 at 12:24, Greg KH wrote:
>>>>>> diff --git a/drivers/cdx/Kconfig b/drivers/cdx/Kconfig
>>>>>> index a08958485e31..86df7ccb76bb 100644
>>>>>> --- a/drivers/cdx/Kconfig
>>>>>> +++ b/drivers/cdx/Kconfig
>>>>>> @@ -8,6 +8,7 @@
>>>>>> config CDX_BUS
>>>>>> bool "CDX Bus driver"
>>>>>> depends on OF && ARM64
>>>>>> + select GENERIC_MSI_IRQ_DOMAIN
>>>>>
>>>>> This config option isn't in my tree anywhere, where did it come from?
>>>>> What is it supposed to do?
>>>>
>>>> 13e7accb81d6 ("genirq: Get rid of GENERIC_MSI_IRQ_DOMAIN") :)
>>>
>>> Ok, so this hasn't been tested since the 6.2 release? Wow, I think
>>> someone from AMD needs to take a deep look at this and verify that it
>>> actually is doing what it is supposed to be doing...
>>
>> The patch Thomas mentioned renames "GENERIC_MSI_IRQ_DOMAIN" to
>> "GENERIC_MSI_IRQ"; and in our testing "GENERIC_MSI_IRQ" is also selected as
>> 'ARM64' is enabled which enables 'ARM_GIC_V3_ITS' which in-turn selects
>> 'GENERIC_MSI_IRQ'.
>
> Ok, but that's not what this patch "selects" at all :(
"GENERIC_MSI_IRQ" gets enabled because of enabling "ARM64", and you are
right that what we are selecting here does not have any meaning now
(after 6.2).
>
>> The patch is tested for MSI functionality on 6.6-rc1. We will re-look into
>> the config dependencies to avoid such issues, but please be assured that the
>> patch has been validated.
>
> How has the dependancy been validated as correct if there is no such
> thing in this kernel?
Apology for the confusion. By validated I meant tested for MSI
functionality in CDX. Agree that "select GENERIC_MSI_IRQ_DOMAIN" needs
to be fixed here. Will update in next spin. :)
Thanks,
Nipun
>
> confused,
>
> greg k-h
next prev parent reply other threads:[~2023-10-05 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 13:52 Nipun Gupta
2023-09-26 9:48 ` Gupta, Nipun
2023-09-26 9:55 ` Greg KH
2023-09-26 13:06 ` Gupta, Nipun
2023-09-26 13:10 ` Gupta, Nipun
2023-10-05 10:24 ` Greg KH
2023-10-05 13:46 ` Thomas Gleixner
2023-10-05 14:00 ` Greg KH
2023-10-05 14:37 ` Gupta, Nipun
2023-10-05 14:54 ` Greg KH
2023-10-05 15:05 ` Gupta, Nipun [this message]
2023-10-07 8:43 ` Gupta, Nipun
2023-10-07 8:51 ` Greg KH
2023-10-09 4:53 ` Gupta, Nipun
2023-10-17 11:24 ` Gangurde, Abhijit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99d707a3-5274-1603-d0ed-f67ce83b7e29@amd.com \
--to=nipun.gupta@amd.com \
--cc=abhijit.gangurde@amd.com \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=harpreet.anand@amd.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=michal.simek@amd.com \
--cc=nikhil.agarwal@amd.com \
--cc=pieter.jansen-van-vuuren@amd.com \
--cc=srivatsa@csail.mit.edu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®