From: Hugo Villeneuve <hugo@hugovil.com>
To: Rob Herring <robh@kernel.org>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
hvilleneuve@dimonoff.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property
Date: Wed, 27 Sep 2023 10:28:18 -0400 [thread overview]
Message-ID: <20230927102818.27b0beff6006392e91380ecd@hugovil.com> (raw)
In-Reply-To: <CAL_JsqLpJuxJ1ZbMkwXPrzUAK3Xhfr4zFgSYvmFufyDRF1QjpQ@mail.gmail.com>
On Fri, 22 Sep 2023 14:52:06 -0500
Rob Herring <robh@kernel.org> wrote:
> On Thu, Sep 21, 2023 at 11:32 AM Hugo Villeneuve <hugo@hugovil.com> wrote:
> >
> > On Thu, 21 Sep 2023 11:24:24 -0500
> > Rob Herring <robh@kernel.org> wrote:
> >
> > > On Wed, Sep 20, 2023 at 11:20:14AM -0400, Hugo Villeneuve wrote:
> > > > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > > >
> > > > The NXP-specific "irda-mode-ports" property lacks a proper vendor
> > > > prefix. Add "nxp," prefix to comply with DT best practises.
> > >
> > > The opposite direction would be worth carrying in the driver, but I
> > > don't think adding a vendor prefix is. I would just leave this as-is.
> > >
> > > Rob
> >
> > Hi Rob,
> > I am not following you, can you clarify?
>
> Just keep the property as-is and don't add a 'nxp,' prefixed version.
> It's not worth carrying the fallback in the driver.
>
> If you were dropping a vendor prefix from a property, then that's
> worth it because there might be other users added.
>
> Rob
Hi Rob,
ok, then I will drop this patch as well as the other titled
'serial: sc16is7xx: recognize "nxp,irda-mode-ports" DT property' for
V2.
Hugo.
next prev parent reply other threads:[~2023-09-27 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 15:20 [PATCH 0/4] serial: sc16is7xx: device tree improvements Hugo Villeneuve
2023-09-20 15:20 ` [PATCH 1/4] serial: sc16is7xx: use device_property APIs when configuring irda mode Hugo Villeneuve
2023-09-20 15:20 ` [PATCH 2/4] serial: sc16is7xx: recognize "nxp,irda-mode-ports" DT property Hugo Villeneuve
2023-09-20 15:20 ` [PATCH 3/4] dt-bindings: sc16is7xx: add vendor prefix to irda-mode-ports property Hugo Villeneuve
2023-09-21 10:29 ` m.brock
2023-09-21 13:37 ` Hugo Villeneuve
2023-09-21 13:47 ` Conor Dooley
2023-09-21 16:24 ` Rob Herring
2023-09-21 16:32 ` Hugo Villeneuve
2023-09-22 19:52 ` Rob Herring
2023-09-27 14:28 ` Hugo Villeneuve [this message]
2023-09-20 15:20 ` [PATCH 4/4] dt-bindings: sc16is7xx: convert to YAML Hugo Villeneuve
2023-09-20 23:13 ` Rob Herring
2023-09-21 16:22 ` Hugo Villeneuve
2023-09-21 13:45 ` Conor Dooley
2023-09-21 15:30 ` Hugo Villeneuve
2023-09-22 11:35 ` Conor Dooley
2023-09-22 13:08 ` Hugo Villeneuve
2023-09-21 15:33 ` Rob Herring
2023-09-21 16:27 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230927102818.27b0beff6006392e91380ecd@hugovil.com \
--to=hugo@hugovil.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®