* [PATCH v1] misc: fastrpc: Clean buffers on remote invocation failures
@ 2023-08-31 6:41 Ekansh Gupta
2023-09-28 13:08 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Ekansh Gupta @ 2023-08-31 6:41 UTC (permalink / raw)
To: srinivas.kandagatla, linux-arm-msm
Cc: Ekansh Gupta, ekangupt, gregkh, linux-kernel, fastrpc.upstream
With current design, buffers and dma handles are not freed in case
of remote invocation failures returned from DSP. This could result
in buffer leakings and dma handle pointing to wrong memory in the
fastrpc kernel. Adding changes to clean buffers and dma handles
even when remote invocation to DSP returns failures.
Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
---
drivers/misc/fastrpc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
index 9666d28..299375f 100644
--- a/drivers/misc/fastrpc.c
+++ b/drivers/misc/fastrpc.c
@@ -1176,11 +1176,6 @@ static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel,
if (err)
goto bail;
- /* Check the response from remote dsp */
- err = ctx->retval;
- if (err)
- goto bail;
-
if (ctx->nscalars) {
/* make sure that all memory writes by DSP are seen by CPU */
dma_rmb();
@@ -1190,6 +1185,11 @@ static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel,
goto bail;
}
+ /* Check the response from remote dsp */
+ err = ctx->retval;
+ if (err)
+ goto bail;
+
bail:
if (err != -ERESTARTSYS && err != -ETIMEDOUT) {
/* We are done with this compute context */
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v1] misc: fastrpc: Clean buffers on remote invocation failures
2023-08-31 6:41 [PATCH v1] misc: fastrpc: Clean buffers on remote invocation failures Ekansh Gupta
@ 2023-09-28 13:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2023-09-28 13:08 UTC (permalink / raw)
To: Ekansh Gupta
Cc: srinivas.kandagatla, linux-arm-msm, ekangupt, linux-kernel,
fastrpc.upstream
On Thu, Aug 31, 2023 at 12:11:22PM +0530, Ekansh Gupta wrote:
> With current design, buffers and dma handles are not freed in case
> of remote invocation failures returned from DSP. This could result
> in buffer leakings and dma handle pointing to wrong memory in the
> fastrpc kernel. Adding changes to clean buffers and dma handles
> even when remote invocation to DSP returns failures.
>
> Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
What commit id does this fix?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-28 13:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-31 6:41 [PATCH v1] misc: fastrpc: Clean buffers on remote invocation failures Ekansh Gupta
2023-09-28 13:08 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®