* [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache
@ 2023-09-30 23:46 Mark Brown
2023-10-02 7:02 ` Neil Armstrong
2023-10-02 7:11 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2023-09-30 23:46 UTC (permalink / raw)
To: Jagan Teki, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter
Cc: dri-devel, linux-kernel, Mark Brown
The maple tree register cache is based on a much more modern data structure
than the rbtree cache and makes optimisation choices which are probably
more appropriate for modern systems than those made by the rbtree cache.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/gpu/drm/bridge/chipone-icn6211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
index d205e755e524..82d23e4df09e 100644
--- a/drivers/gpu/drm/bridge/chipone-icn6211.c
+++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
@@ -197,7 +197,7 @@ static const struct regmap_config chipone_regmap_config = {
.val_bits = 8,
.rd_table = &chipone_dsi_readable_table,
.wr_table = &chipone_dsi_writeable_table,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
.max_register = MIPI_ATE_STATUS(1),
};
---
base-commit: 6465e260f48790807eef06b583b38ca9789b6072
change-id: 20230929-drm-chipone-maple-1d5e37ce5ed0
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache
2023-09-30 23:46 [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache Mark Brown
@ 2023-10-02 7:02 ` Neil Armstrong
2023-10-02 7:11 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-10-02 7:02 UTC (permalink / raw)
To: Mark Brown, Jagan Teki, Andrzej Hajda, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter
Cc: dri-devel, linux-kernel
On 01/10/2023 01:46, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/gpu/drm/bridge/chipone-icn6211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> index d205e755e524..82d23e4df09e 100644
> --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> @@ -197,7 +197,7 @@ static const struct regmap_config chipone_regmap_config = {
> .val_bits = 8,
> .rd_table = &chipone_dsi_readable_table,
> .wr_table = &chipone_dsi_writeable_table,
> - .cache_type = REGCACHE_RBTREE,
> + .cache_type = REGCACHE_MAPLE,
> .max_register = MIPI_ATE_STATUS(1),
> };
>
>
> ---
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> change-id: 20230929-drm-chipone-maple-1d5e37ce5ed0
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache
2023-09-30 23:46 [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache Mark Brown
2023-10-02 7:02 ` Neil Armstrong
@ 2023-10-02 7:11 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-10-02 7:11 UTC (permalink / raw)
To: Jagan Teki, Andrzej Hajda, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
Mark Brown
Cc: dri-devel, linux-kernel
Hi,
On Sun, 01 Oct 2023 00:46:38 +0100, Mark Brown wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm/bridge: icn6211: Convert to use maple tree register cache
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=fb6f4f47dd4a71a0394d346eda7589dd9397c4bc
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-02 7:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-30 23:46 [PATCH] drm/bridge: icn6211: Convert to use maple tree register cache Mark Brown
2023-10-02 7:02 ` Neil Armstrong
2023-10-02 7:11 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®