* [PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get documentation
@ 2023-09-25 15:18 Kieran Bingham
2023-10-02 23:23 ` Florian Fainelli
0 siblings, 1 reply; 2+ messages in thread
From: Kieran Bingham @ 2023-09-25 15:18 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel, linux-rpi-kernel, Florian Fainelli
Cc: Kieran Bingham, Kieran Bingham,
Broadcom internal kernel review list, Maxime Ripard,
Greg Kroah-Hartman, Rob Herring, Joel Savitz, Yang Yingliang,
Yuan Can, Bartosz Golaszewski, Nicolas Saenz Julienne
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
The function documentation for devm_rpi_firmware_get() was missing
a description for the dev parameter.
Provide it and clear the warning produced here.
Fixes: f663204c9a1f ("firmware: raspberrypi: Introduce devm_rpi_firmware_get()")
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
drivers/firmware/raspberrypi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index f66efaa5196d..4cd290a60fba 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -378,6 +378,7 @@ EXPORT_SYMBOL_GPL(rpi_firmware_get);
/**
* devm_rpi_firmware_get - Get pointer to rpi_firmware structure.
+ * @dev: The firmware device structure
* @firmware_node: Pointer to the firmware Device Tree node.
*
* Returns NULL is the firmware device is not ready.
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get documentation
2023-09-25 15:18 [PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get documentation Kieran Bingham
@ 2023-10-02 23:23 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2023-10-02 23:23 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Kieran Bingham, linux-kernel,
linux-arm-kernel, linux-rpi-kernel, Florian Fainelli
Cc: Florian Fainelli, Kieran Bingham, Maxime Ripard,
Greg Kroah-Hartman, Rob Herring, Joel Savitz, Yang Yingliang,
Yuan Can, Bartosz Golaszewski, Nicolas Saenz Julienne
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
From: Florian Fainelli <f.fainelli@gmail.com>
On Mon, 25 Sep 2023 16:18:11 +0100, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote:
> From: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> The function documentation for devm_rpi_firmware_get() was missing
> a description for the dev parameter.
>
> Provide it and clear the warning produced here.
>
> Fixes: f663204c9a1f ("firmware: raspberrypi: Introduce devm_rpi_firmware_get()")
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/drivers/next, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-02 23:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-25 15:18 [PATCH] firmware: raspberrypi: Fix devm_rpi_firmware_get documentation Kieran Bingham
2023-10-02 23:23 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®