* [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value
@ 2023-10-05 16:47 Florian Fainelli
2023-10-09 10:01 ` Uwe Kleine-König
2023-10-12 13:55 ` Thierry Reding
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2023-10-05 16:47 UTC (permalink / raw)
To: linux-pwm
Cc: Florian Fainelli, Uwe Kleine-König, Thierry Reding,
Broadcom internal kernel review list,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE, open list
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
Check the clk_prepare_enable() return value and propagate it.
Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
This change depends upon:
https://lore.kernel.org/all/20231004175414.1738475-1-florian.fainelli@broadcom.com/
drivers/pwm/pwm-brcmstb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c
index a7d529bf76ad..de9cbda2e4ff 100644
--- a/drivers/pwm/pwm-brcmstb.c
+++ b/drivers/pwm/pwm-brcmstb.c
@@ -297,9 +297,7 @@ static int brcmstb_pwm_resume(struct device *dev)
{
struct brcmstb_pwm *p = dev_get_drvdata(dev);
- clk_prepare_enable(p->clk);
-
- return 0;
+ return clk_prepare_enable(p->clk);
}
#endif
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value
2023-10-05 16:47 [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value Florian Fainelli
@ 2023-10-09 10:01 ` Uwe Kleine-König
2023-10-12 13:55 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2023-10-09 10:01 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-pwm, Thierry Reding, Broadcom internal kernel review list,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE, open list
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
On Thu, Oct 05, 2023 at 09:47:27AM -0700, Florian Fainelli wrote:
> Check the clk_prepare_enable() return value and propagate it.
>
> Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value
2023-10-05 16:47 [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value Florian Fainelli
2023-10-09 10:01 ` Uwe Kleine-König
@ 2023-10-12 13:55 ` Thierry Reding
1 sibling, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2023-10-12 13:55 UTC (permalink / raw)
To: linux-pwm, Florian Fainelli
Cc: Uwe Kleine-König, Broadcom internal kernel review list,
linux-arm-kernel, linux-kernel
On Thu, 05 Oct 2023 09:47:27 -0700, Florian Fainelli wrote:
> Check the clk_prepare_enable() return value and propagate it.
>
>
Applied, thanks!
[1/1] pwm: brcmstb: Checked clk_prepare_enable() return value
commit: d559f11591900a283b2a0b1087d68992e6c2062a
Best regards,
--
Thierry Reding <thierry.reding@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-12 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-05 16:47 [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value Florian Fainelli
2023-10-09 10:01 ` Uwe Kleine-König
2023-10-12 13:55 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®