* [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test
@ 2023-10-08 3:17 liming.wu
2023-10-08 3:17 ` [PATCH v2 2/2] tools/virtio: Add hints when module is not installed liming.wu
0 siblings, 1 reply; 3+ messages in thread
From: liming.wu @ 2023-10-08 3:17 UTC (permalink / raw)
To: Michael S . Tsirkin, Jason Wang
Cc: kvm, virtualization, netdev, linux-kernel, Liming Wu
From: Liming Wu <liming.wu@jaguarmicro.com>
Fixes: 8bd2f71054bd ("virtio_ring: introduce dma sync api for virtqueue")
also add dma sync api for virtio test.
Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
---
tools/virtio/linux/dma-mapping.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
index 834a90bd3270..822ecaa8e4df 100644
--- a/tools/virtio/linux/dma-mapping.h
+++ b/tools/virtio/linux/dma-mapping.h
@@ -24,11 +24,23 @@ enum dma_data_direction {
#define dma_map_page(d, p, o, s, dir) (page_to_phys(p) + (o))
#define dma_map_single(d, p, s, dir) (virt_to_phys(p))
+#define dma_map_single_attrs(d, p, s, dir, a) (virt_to_phys(p))
#define dma_mapping_error(...) (0)
#define dma_unmap_single(d, a, s, r) do { (void)(d); (void)(a); (void)(s); (void)(r); } while (0)
#define dma_unmap_page(d, a, s, r) do { (void)(d); (void)(a); (void)(s); (void)(r); } while (0)
+#define sg_dma_address(sg) (0)
+#define dma_need_sync(v, a) (0)
+#define dma_unmap_single_attrs(d, a, s, r, t) do { \
+ (void)(d); (void)(a); (void)(s); (void)(r); (void)(t); \
+} while (0)
+#define dma_sync_single_range_for_cpu(d, a, o, s, r) do { \
+ (void)(d); (void)(a); (void)(o); (void)(s); (void)(r); \
+} while (0)
+#define dma_sync_single_range_for_device(d, a, o, s, r) do { \
+ (void)(d); (void)(a); (void)(o); (void)(s); (void)(r); \
+} while (0)
#define dma_max_mapping_size(...) SIZE_MAX
#endif
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2 2/2] tools/virtio: Add hints when module is not installed
2023-10-08 3:17 [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test liming.wu
@ 2023-10-08 3:17 ` liming.wu
0 siblings, 0 replies; 3+ messages in thread
From: liming.wu @ 2023-10-08 3:17 UTC (permalink / raw)
To: Michael S . Tsirkin, Jason Wang
Cc: kvm, virtualization, netdev, linux-kernel, Liming Wu
From: Liming Wu <liming.wu@jaguarmicro.com>
Need to insmod vhost_test.ko before run virtio_test.
Give some hints to users.
Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
---
tools/virtio/virtio_test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
index 028f54e6854a..13572a677c35 100644
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -135,6 +135,10 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
dev->buf = malloc(dev->buf_size);
assert(dev->buf);
dev->control = open("/dev/vhost-test", O_RDWR);
+
+ if (dev->control < 0)
+ fprintf(stderr,
+ "Install vhost_test module (./vhost_test/vhost_test.ko) first.\n");
assert(dev->control >= 0);
r = ioctl(dev->control, VHOST_SET_OWNER, NULL);
assert(r >= 0);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] tools/virtio: Add hints when module is not installed
@ 2023-09-27 15:20 Michael S. Tsirkin
2023-10-07 6:55 ` [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test liming.wu
0 siblings, 1 reply; 3+ messages in thread
From: Michael S. Tsirkin @ 2023-09-27 15:20 UTC (permalink / raw)
To: liming.wu
Cc: Jason Wang, kvm, virtualization, netdev, linux-kernel, 398776277
On Tue, Sep 26, 2023 at 01:00:20PM +0800, liming.wu@jaguarmicro.com wrote:
> From: Liming Wu <liming.wu@jaguarmicro.com>
>
> Need to insmod vhost_test.ko before run virtio_test.
> Give some hints to users.
>
> Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
> ---
> tools/virtio/virtio_test.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index 028f54e6854a..ce2c4d93d735 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -135,6 +135,10 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
> dev->buf = malloc(dev->buf_size);
> assert(dev->buf);
> dev->control = open("/dev/vhost-test", O_RDWR);
> +
> + if (dev->control < 0)
> + fprintf(stderr, "Install vhost_test module" \
> + "(./vhost_test/vhost_test.ko) firstly\n");
Thanks!
things to improve:
firstly -> first
add space before (
End sentence with a dot
align "" on the two lines
> assert(dev->control >= 0);
> r = ioctl(dev->control, VHOST_SET_OWNER, NULL);
> assert(r >= 0);
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test
2023-09-27 15:20 [PATCH " Michael S. Tsirkin
@ 2023-10-07 6:55 ` liming.wu
2023-10-07 6:55 ` [PATCH v2 2/2] tools/virtio: Add hints when module is not installed liming.wu
0 siblings, 1 reply; 3+ messages in thread
From: liming.wu @ 2023-10-07 6:55 UTC (permalink / raw)
To: Michael S . Tsirkin, Jason Wang
Cc: kvm, virtualization, netdev, linux-kernel, Liming Wu
From: Liming Wu <liming.wu@jaguarmicro.com>
Fixes: 8bd2f71054bd ("virtio_ring: introduce dma sync api for virtqueue")
also add dma sync api for virtio test.
Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
---
tools/virtio/linux/dma-mapping.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tools/virtio/linux/dma-mapping.h b/tools/virtio/linux/dma-mapping.h
index 834a90bd3270..822ecaa8e4df 100644
--- a/tools/virtio/linux/dma-mapping.h
+++ b/tools/virtio/linux/dma-mapping.h
@@ -24,11 +24,23 @@ enum dma_data_direction {
#define dma_map_page(d, p, o, s, dir) (page_to_phys(p) + (o))
#define dma_map_single(d, p, s, dir) (virt_to_phys(p))
+#define dma_map_single_attrs(d, p, s, dir, a) (virt_to_phys(p))
#define dma_mapping_error(...) (0)
#define dma_unmap_single(d, a, s, r) do { (void)(d); (void)(a); (void)(s); (void)(r); } while (0)
#define dma_unmap_page(d, a, s, r) do { (void)(d); (void)(a); (void)(s); (void)(r); } while (0)
+#define sg_dma_address(sg) (0)
+#define dma_need_sync(v, a) (0)
+#define dma_unmap_single_attrs(d, a, s, r, t) do { \
+ (void)(d); (void)(a); (void)(s); (void)(r); (void)(t); \
+} while (0)
+#define dma_sync_single_range_for_cpu(d, a, o, s, r) do { \
+ (void)(d); (void)(a); (void)(o); (void)(s); (void)(r); \
+} while (0)
+#define dma_sync_single_range_for_device(d, a, o, s, r) do { \
+ (void)(d); (void)(a); (void)(o); (void)(s); (void)(r); \
+} while (0)
#define dma_max_mapping_size(...) SIZE_MAX
#endif
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH v2 2/2] tools/virtio: Add hints when module is not installed
2023-10-07 6:55 ` [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test liming.wu
@ 2023-10-07 6:55 ` liming.wu
0 siblings, 0 replies; 3+ messages in thread
From: liming.wu @ 2023-10-07 6:55 UTC (permalink / raw)
To: Michael S . Tsirkin, Jason Wang
Cc: kvm, virtualization, netdev, linux-kernel, Liming Wu
From: Liming Wu <liming.wu@jaguarmicro.com>
Need to insmod vhost_test.ko before run virtio_test.
Give some hints to users.
Signed-off-by: Liming Wu <liming.wu@jaguarmicro.com>
---
tools/virtio/virtio_test.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
index 028f54e6854a..13572a677c35 100644
--- a/tools/virtio/virtio_test.c
+++ b/tools/virtio/virtio_test.c
@@ -135,6 +135,10 @@ static void vdev_info_init(struct vdev_info* dev, unsigned long long features)
dev->buf = malloc(dev->buf_size);
assert(dev->buf);
dev->control = open("/dev/vhost-test", O_RDWR);
+
+ if (dev->control < 0)
+ fprintf(stderr,
+ "Install vhost_test module (/vhost_test/vhost_test.ko) first.\n");
assert(dev->control >= 0);
r = ioctl(dev->control, VHOST_SET_OWNER, NULL);
assert(r >= 0);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-08 3:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-08 3:17 [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test liming.wu
2023-10-08 3:17 ` [PATCH v2 2/2] tools/virtio: Add hints when module is not installed liming.wu
-- strict thread matches above, loose matches on Subject: below --
2023-09-27 15:20 [PATCH " Michael S. Tsirkin
2023-10-07 6:55 ` [PATCH v2 1/2] tools/virtio: Add dma sync api for virtio test liming.wu
2023-10-07 6:55 ` [PATCH v2 2/2] tools/virtio: Add hints when module is not installed liming.wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®