* [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset
@ 2023-10-10 3:25 Huang Rui
2023-10-10 5:06 ` Akihiko Odaki
2023-10-10 10:20 ` Dmitry Osipenko
0 siblings, 2 replies; 4+ messages in thread
From: Huang Rui @ 2023-10-10 3:25 UTC (permalink / raw)
To: dri-devel, virtualization, linux-kernel, David Airlie,
Gerd Hoffmann, Gurchetan Singh, Chia-I Wu, Daniel Vetter,
Akihiko Odaki, Dmitry Osipenko, Marc-André Lureau
Cc: Alex Deucher, Xenia Ragiadakou, Stefano Stabellini,
Honglei Huang, Julia Zhang, Chen Jiqian, Huang Rui
These definitions are used fro qemu, and qemu imports this marco in the
headers to enable gfxstream or venus for virtio gpu. So it should add it
even kernel doesn't use this.
Signed-off-by: Huang Rui <ray.huang@amd.com>
---
Changes V1 -> V2:
- Add all capsets including gfxstream and venus in kernel header (Dmitry Osipenko)
v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.huang@amd.com/
include/uapi/linux/virtio_gpu.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
index f556fde07b76..327792658bdc 100644
--- a/include/uapi/linux/virtio_gpu.h
+++ b/include/uapi/linux/virtio_gpu.h
@@ -309,6 +309,8 @@ struct virtio_gpu_cmd_submit {
#define VIRTIO_GPU_CAPSET_VIRGL 1
#define VIRTIO_GPU_CAPSET_VIRGL2 2
+#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
+#define VIRTIO_GPU_CAPSET_VENUS 4
/* VIRTIO_GPU_CMD_GET_CAPSET_INFO */
struct virtio_gpu_get_capset_info {
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset
2023-10-10 3:25 [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset Huang Rui
@ 2023-10-10 5:06 ` Akihiko Odaki
2023-10-10 10:20 ` Dmitry Osipenko
1 sibling, 0 replies; 4+ messages in thread
From: Akihiko Odaki @ 2023-10-10 5:06 UTC (permalink / raw)
To: Huang Rui, dri-devel, virtualization, linux-kernel, David Airlie,
Gerd Hoffmann, Gurchetan Singh, Chia-I Wu, Daniel Vetter,
Dmitry Osipenko, Marc-André Lureau
Cc: Alex Deucher, Xenia Ragiadakou, Stefano Stabellini,
Honglei Huang, Julia Zhang, Chen Jiqian
On 2023/10/10 12:25, Huang Rui wrote:
> These definitions are used fro qemu, and qemu imports this marco in the
> headers to enable gfxstream or venus for virtio gpu. So it should add it
> even kernel doesn't use this.
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>
> Changes V1 -> V2:
> - Add all capsets including gfxstream and venus in kernel header (Dmitry Osipenko)
>
> v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.huang@amd.com/
>
> include/uapi/linux/virtio_gpu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
> index f556fde07b76..327792658bdc 100644
> --- a/include/uapi/linux/virtio_gpu.h
> +++ b/include/uapi/linux/virtio_gpu.h
> @@ -309,6 +309,8 @@ struct virtio_gpu_cmd_submit {
>
> #define VIRTIO_GPU_CAPSET_VIRGL 1
> #define VIRTIO_GPU_CAPSET_VIRGL2 2
> +#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
> +#define VIRTIO_GPU_CAPSET_VENUS 4
>
> /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */
> struct virtio_gpu_get_capset_info {
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset
2023-10-10 3:25 [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset Huang Rui
2023-10-10 5:06 ` Akihiko Odaki
@ 2023-10-10 10:20 ` Dmitry Osipenko
2023-10-10 11:09 ` Huang Rui
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Osipenko @ 2023-10-10 10:20 UTC (permalink / raw)
To: Huang Rui, dri-devel, virtualization, linux-kernel, David Airlie,
Gerd Hoffmann, Gurchetan Singh, Chia-I Wu, Daniel Vetter,
Akihiko Odaki, Marc-André Lureau
Cc: Alex Deucher, Xenia Ragiadakou, Stefano Stabellini,
Honglei Huang, Julia Zhang, Chen Jiqian
Hi,
On 10/10/23 06:25, Huang Rui wrote:
> These definitions are used fro qemu, and qemu imports this marco in the
> headers to enable gfxstream or venus for virtio gpu. So it should add it
> even kernel doesn't use this.
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
>
> Changes V1 -> V2:
> - Add all capsets including gfxstream and venus in kernel header (Dmitry Osipenko)
>
> v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.huang@amd.com/
>
> include/uapi/linux/virtio_gpu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
> index f556fde07b76..327792658bdc 100644
> --- a/include/uapi/linux/virtio_gpu.h
> +++ b/include/uapi/linux/virtio_gpu.h
> @@ -309,6 +309,8 @@ struct virtio_gpu_cmd_submit {
>
> #define VIRTIO_GPU_CAPSET_VIRGL 1
> #define VIRTIO_GPU_CAPSET_VIRGL2 2
> +#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
> +#define VIRTIO_GPU_CAPSET_VENUS 4
>
> /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */
> struct virtio_gpu_get_capset_info {
By the "all" capsets, I meant to pick up all definitions from crosvm.
There should be VIRTIO_GPU_CAPSET_DRM at minimum, could you please add it?
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset
2023-10-10 10:20 ` Dmitry Osipenko
@ 2023-10-10 11:09 ` Huang Rui
0 siblings, 0 replies; 4+ messages in thread
From: Huang Rui @ 2023-10-10 11:09 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: dri-devel, virtualization, linux-kernel, David Airlie,
Gerd Hoffmann, Gurchetan Singh, Chia-I Wu, Daniel Vetter,
Akihiko Odaki, Marc-André Lureau, Deucher, Alexander,
Ragiadakou, Xenia, Stabellini, Stefano, Huang, Honglei1, Zhang,
Julia, Chen, Jiqian
On Tue, Oct 10, 2023 at 06:20:03PM +0800, Dmitry Osipenko wrote:
> Hi,
>
> On 10/10/23 06:25, Huang Rui wrote:
> > These definitions are used fro qemu, and qemu imports this marco in the
> > headers to enable gfxstream or venus for virtio gpu. So it should add it
> > even kernel doesn't use this.
> >
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > ---
> >
> > Changes V1 -> V2:
> > - Add all capsets including gfxstream and venus in kernel header (Dmitry Osipenko)
> >
> > v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.huang@amd.com/
> >
> > include/uapi/linux/virtio_gpu.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h
> > index f556fde07b76..327792658bdc 100644
> > --- a/include/uapi/linux/virtio_gpu.h
> > +++ b/include/uapi/linux/virtio_gpu.h
> > @@ -309,6 +309,8 @@ struct virtio_gpu_cmd_submit {
> >
> > #define VIRTIO_GPU_CAPSET_VIRGL 1
> > #define VIRTIO_GPU_CAPSET_VIRGL2 2
> > +#define VIRTIO_GPU_CAPSET_GFXSTREAM 3
> > +#define VIRTIO_GPU_CAPSET_VENUS 4
> >
> > /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */
> > struct virtio_gpu_get_capset_info {
>
> By the "all" capsets, I meant to pick up all definitions from crosvm.
> There should be VIRTIO_GPU_CAPSET_DRM at minimum, could you please add it?
>
Sure. Thanks for the reminder.
Best Regards,
Ray
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-10 11:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-10 3:25 [PATCH v2] drm/virtio: add definitions for gfxstream and venus capset Huang Rui
2023-10-10 5:06 ` Akihiko Odaki
2023-10-10 10:20 ` Dmitry Osipenko
2023-10-10 11:09 ` Huang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®