* [PATCH][next] sched/headers: remove comment referring to cpu_load since this has been removed
@ 2023-10-10 15:57 Colin Ian King
2023-10-10 21:32 ` [tip: sched/core] sched/headers: Remove comment referring to rq::cpu_load, " tip-bot2 for Colin Ian King
2023-10-10 21:47 ` tip-bot2 for Colin Ian King
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2023-10-10 15:57 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Daniel Bristot de Oliveira, Valentin Schneider
Cc: kernel-janitors, linux-kernel
There is a comment that refers to cpu_load, however, this cpu_load was
removed with commit 55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
back in 2019. The comment does not make sense with respect to this
removed array, so remove the comment.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
kernel/sched/sched.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index faf9031422e1..65cad0e5729e 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -948,10 +948,6 @@ struct rq {
/* runqueue lock: */
raw_spinlock_t __lock;
- /*
- * nr_running and cpu_load should be in the same cacheline because
- * remote CPUs use both these fields when doing load calculation.
- */
unsigned int nr_running;
#ifdef CONFIG_NUMA_BALANCING
unsigned int nr_numa_running;
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: sched/core] sched/headers: Remove comment referring to rq::cpu_load, since this has been removed
2023-10-10 15:57 [PATCH][next] sched/headers: remove comment referring to cpu_load since this has been removed Colin Ian King
@ 2023-10-10 21:32 ` tip-bot2 for Colin Ian King
2023-10-10 21:47 ` tip-bot2 for Colin Ian King
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Colin Ian King @ 2023-10-10 21:32 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Colin Ian King, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 2616fdce9b8c7815d5578b28aea98595ebd0f290
Gitweb: https://git.kernel.org/tip/2616fdce9b8c7815d5578b28aea98595ebd0f290
Author: Colin Ian King <colin.i.king@gmail.com>
AuthorDate: Tue, 10 Oct 2023 16:57:44 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 10 Oct 2023 23:29:14 +02:00
sched/headers: Remove comment referring to rq::cpu_load, since this has been removed
There is a comment that refers to cpu_load, however, this cpu_load was
removed with:
55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
... back in 2019. The comment does not make sense with respect to this
removed array, so remove the comment.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20231010155744.1381065-1-colin.i.king@gmail.com
---
kernel/sched/sched.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index faf9031..65cad0e 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -948,10 +948,6 @@ struct rq {
/* runqueue lock: */
raw_spinlock_t __lock;
- /*
- * nr_running and cpu_load should be in the same cacheline because
- * remote CPUs use both these fields when doing load calculation.
- */
unsigned int nr_running;
#ifdef CONFIG_NUMA_BALANCING
unsigned int nr_numa_running;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip: sched/core] sched/headers: Remove comment referring to rq::cpu_load, since this has been removed
2023-10-10 15:57 [PATCH][next] sched/headers: remove comment referring to cpu_load since this has been removed Colin Ian King
2023-10-10 21:32 ` [tip: sched/core] sched/headers: Remove comment referring to rq::cpu_load, " tip-bot2 for Colin Ian King
@ 2023-10-10 21:47 ` tip-bot2 for Colin Ian King
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Colin Ian King @ 2023-10-10 21:47 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Colin Ian King, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: b19fdb16fb2167c6bc9ee8fbc0c1d2d4fd3e2eb8
Gitweb: https://git.kernel.org/tip/b19fdb16fb2167c6bc9ee8fbc0c1d2d4fd3e2eb8
Author: Colin Ian King <colin.i.king@gmail.com>
AuthorDate: Tue, 10 Oct 2023 16:57:44 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 10 Oct 2023 23:42:20 +02:00
sched/headers: Remove comment referring to rq::cpu_load, since this has been removed
There is a comment that refers to cpu_load, however, this cpu_load was
removed with:
55627e3cd22c ("sched/core: Remove rq->cpu_load[]")
... back in 2019. The comment does not make sense with respect to this
removed array, so remove the comment.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20231010155744.1381065-1-colin.i.king@gmail.com
---
kernel/sched/sched.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index faf9031..65cad0e 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -948,10 +948,6 @@ struct rq {
/* runqueue lock: */
raw_spinlock_t __lock;
- /*
- * nr_running and cpu_load should be in the same cacheline because
- * remote CPUs use both these fields when doing load calculation.
- */
unsigned int nr_running;
#ifdef CONFIG_NUMA_BALANCING
unsigned int nr_numa_running;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-10 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-10 15:57 [PATCH][next] sched/headers: remove comment referring to cpu_load since this has been removed Colin Ian King
2023-10-10 21:32 ` [tip: sched/core] sched/headers: Remove comment referring to rq::cpu_load, " tip-bot2 for Colin Ian King
2023-10-10 21:47 ` tip-bot2 for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®