From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] smp: fix __smp_processor_id() backup macro
Date: Sat, 14 Oct 2023 15:12:21 -0700 [thread overview]
Message-ID: <20231014151221.46096b7fc17ccaeb691ff5d0@linux-foundation.org> (raw)
In-Reply-To: <b12bdef9-d5c0-49cf-aea2-ff7b56220fdc@p183>
On Sat, 14 Oct 2023 19:14:15 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Every __smp_processor_id usage doesn't have arguments and
> every raw_smp_processor_id usage doesn't have arguments,
> therefore "#define __smp_processor_id(x)" can not possibly work.
>
> ...
>
> --- a/include/linux/smp.h
> +++ b/include/linux/smp.h
> @@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void)
> * regular asm read for the stable.
> */
> #ifndef __smp_processor_id
> -#define __smp_processor_id(x) raw_smp_processor_id(x)
> +#define __smp_processor_id() raw_smp_processor_id()
> #endif
>
It's been that way for at least 4 years. Presumably this is never used
and should be removed?
next prev parent reply other threads:[~2023-10-14 22:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 16:14 Alexey Dobriyan
2023-10-14 22:12 ` Andrew Morton [this message]
2023-10-15 9:55 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231014151221.46096b7fc17ccaeb691ff5d0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®