From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] smp: fix __smp_processor_id() backup macro
Date: Sun, 15 Oct 2023 12:55:17 +0300 [thread overview]
Message-ID: <c22be6b2-5d80-4168-95cc-f86a79d8cb39@p183> (raw)
In-Reply-To: <20231014151221.46096b7fc17ccaeb691ff5d0@linux-foundation.org>
On Sat, Oct 14, 2023 at 03:12:21PM -0700, Andrew Morton wrote:
> On Sat, 14 Oct 2023 19:14:15 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> > Every __smp_processor_id usage doesn't have arguments and
> > every raw_smp_processor_id usage doesn't have arguments,
> > therefore "#define __smp_processor_id(x)" can not possibly work.
> >
> > ...
> >
> > --- a/include/linux/smp.h
> > +++ b/include/linux/smp.h
> > @@ -261,7 +261,7 @@ static inline int get_boot_cpu_id(void)
> > * regular asm read for the stable.
> > */
> > #ifndef __smp_processor_id
> > -#define __smp_processor_id(x) raw_smp_processor_id(x)
> > +#define __smp_processor_id() raw_smp_processor_id()
> > #endif
> >
>
> It's been that way for at least 4 years. Presumably this is never used
> and should be removed?
Deleting breaks compilation immediately.
C89 6.8.3 §4 says
"The number of arguments in an invocation of a function-like
macro shall agree with the number of parameters in the macro
definition, ..."
C99 relaxes this in 6.10.3 §4
the number of arguments (including those arguments
consisting of no preprocesing tokens) ... shall equal
the number of parameters in the macro definition.
So, "#define M()" works with M() only, but "#define M(a)" worked with
M(1) and started working as M() which is very funny.
In other words changelog is wrong: it can and does work (sort of by
accident).
prev parent reply other threads:[~2023-10-15 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-14 16:14 Alexey Dobriyan
2023-10-14 22:12 ` Andrew Morton
2023-10-15 9:55 ` Alexey Dobriyan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c22be6b2-5d80-4168-95cc-f86a79d8cb39@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®