From: Wenchao Hao <haowenchao2@huawei.com>
To: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <louhongxiang@huawei.com>,
Wenchao Hao <haowenchao2@huawei.com>
Subject: [PATCH v2 2/2] scsi: Add comment of target_destroy in scsi_host_template
Date: Mon, 16 Oct 2023 10:08:47 +0800 [thread overview]
Message-ID: <20231016020847.1270258-3-haowenchao2@huawei.com> (raw)
In-Reply-To: <20231016020847.1270258-1-haowenchao2@huawei.com>
Add comment to tell callback function target_destroy of
scsi_host_template is called in atomic context.
Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
---
include/scsi/scsi_host.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index 49f768d0ff37..2e8d77441064 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -245,6 +245,9 @@ struct scsi_host_template {
* midlayer calls this point so that the driver may deallocate
* and terminate any references to the target.
*
+ * Note: this callback in called with spin_lock shost->host_lock held,
+ * so donot call functions might cause schedule
+ *
* Status: OPTIONAL
*/
void (* target_destroy)(struct scsi_target *);
--
2.32.0
next prev parent reply other threads:[~2023-10-16 2:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 2:08 [PATCH v2 0/2] cleanup patch Wenchao Hao
2023-10-16 2:08 ` [PATCH v2 1/2] scsi: core: cleanup scsi_dev_queue_ready() Wenchao Hao
2023-10-17 21:15 ` Bart Van Assche
2023-10-18 2:22 ` Wenchao Hao
2023-10-16 2:08 ` Wenchao Hao [this message]
2023-10-17 21:04 ` [PATCH v2 2/2] scsi: Add comment of target_destroy in scsi_host_template Bart Van Assche
2023-10-18 2:24 ` Wenchao Hao
2023-10-17 17:01 ` [PATCH v2 0/2] cleanup patch Wenchao Hao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016020847.1270258-3-haowenchao2@huawei.com \
--to=haowenchao2@huawei.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®