* [PATCH] nvmet-fc: Remove unused function
@ 2023-10-19 2:56 Jiapeng Chong
2023-10-19 5:02 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-10-19 2:56 UTC (permalink / raw)
To: james.smart
Cc: hch, sagi, kch, linux-nvme, linux-kernel, Jiapeng Chong, Abaci Robot
The function are defined in the fc.c file, but not called
elsewhere, so delete the unused function.
drivers/nvme/target/fc.c:177:1: warning: unused function 'nvmet_fc_iodnum'.
drivers/nvme/target/fc.c:183:1: warning: unused function 'nvmet_fc_fodnum'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6936
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/nvme/target/fc.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
index bd59990b5250..433517bbd3ac 100644
--- a/drivers/nvme/target/fc.c
+++ b/drivers/nvme/target/fc.c
@@ -172,20 +172,6 @@ struct nvmet_fc_tgt_assoc {
struct rcu_head rcu;
};
-
-static inline int
-nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr)
-{
- return (iodptr - iodptr->tgtport->iod);
-}
-
-static inline int
-nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr)
-{
- return (fodptr - fodptr->queue->fod);
-}
-
-
/*
* Association and Connection IDs:
*
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nvmet-fc: Remove unused function
2023-10-19 2:56 [PATCH] nvmet-fc: Remove unused function Jiapeng Chong
@ 2023-10-19 5:02 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2023-10-19 5:02 UTC (permalink / raw)
To: Jiapeng Chong
Cc: james.smart, hch, sagi, kch, linux-nvme, linux-kernel, Abaci Robot
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-19 5:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-19 2:56 [PATCH] nvmet-fc: Remove unused function Jiapeng Chong
2023-10-19 5:02 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®