* [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS
@ 2023-10-20 13:19 Arnd Bergmann
2023-10-20 13:28 ` Neil Armstrong
2023-10-20 13:35 ` Jerome Brunet
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-10-20 13:19 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Yu Tu
Cc: Arnd Bergmann, Martin Blumenstingl, Dmitry Rokosov, Jian Hu,
linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without this, the newly added driver fails to link:
aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/clk/meson/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
index c5303e4c16043..3c28560b0faba 100644
--- a/drivers/clk/meson/Kconfig
+++ b/drivers/clk/meson/Kconfig
@@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
tristate "S4 SoC PLL clock controllers support"
depends on ARM64
default y
+ select COMMON_CLK_MESON_CLKC_UTILS
select COMMON_CLK_MESON_MPLL
select COMMON_CLK_MESON_PLL
select COMMON_CLK_MESON_REGMAP
--
2.39.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS
2023-10-20 13:19 [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS Arnd Bergmann
@ 2023-10-20 13:28 ` Neil Armstrong
2023-10-20 13:35 ` Jerome Brunet
1 sibling, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2023-10-20 13:28 UTC (permalink / raw)
To: Arnd Bergmann, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Yu Tu
Cc: Arnd Bergmann, Martin Blumenstingl, Dmitry Rokosov, Jian Hu,
linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel
On 20/10/2023 15:19, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this, the newly added driver fails to link:
>
> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
>
> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/clk/meson/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index c5303e4c16043..3c28560b0faba 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
> tristate "S4 SoC PLL clock controllers support"
> depends on ARM64
> default y
> + select COMMON_CLK_MESON_CLKC_UTILS
> select COMMON_CLK_MESON_MPLL
> select COMMON_CLK_MESON_PLL
> select COMMON_CLK_MESON_REGMAP
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS
2023-10-20 13:19 [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS Arnd Bergmann
2023-10-20 13:28 ` Neil Armstrong
@ 2023-10-20 13:35 ` Jerome Brunet
2023-10-23 10:27 ` Arnd Bergmann
1 sibling, 1 reply; 4+ messages in thread
From: Jerome Brunet @ 2023-10-20 13:35 UTC (permalink / raw)
To: Arnd Bergmann, Neil Armstrong, Michael Turquette, Stephen Boyd,
Kevin Hilman, Yu Tu
Cc: Arnd Bergmann, Martin Blumenstingl, Dmitry Rokosov, Jian Hu,
linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel
On Fri 20 Oct 2023 at 15:19, Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this, the newly added driver fails to link:
>
> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
>
> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/clk/meson/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index c5303e4c16043..3c28560b0faba 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
> tristate "S4 SoC PLL clock controllers support"
> depends on ARM64
> default y
> + select COMMON_CLK_MESON_CLKC_UTILS
> select COMMON_CLK_MESON_MPLL
> select COMMON_CLK_MESON_PLL
> select COMMON_CLK_MESON_REGMAP
Thx Arnd and sorry about this.
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
Stephen, do you mind taking this directly ?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS
2023-10-20 13:35 ` Jerome Brunet
@ 2023-10-23 10:27 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2023-10-23 10:27 UTC (permalink / raw)
To: Jerome Brunet, Arnd Bergmann, Neil Armstrong, Michael Turquette,
Stephen Boyd, Kevin Hilman, Yu Tu
Cc: Martin Blumenstingl, Dmitry Rokosov, Jian Hu, linux-amlogic,
linux-clk, linux-arm-kernel, linux-kernel
On Fri, Oct 20, 2023, at 15:35, Jerome Brunet wrote:
> On Fri 20 Oct 2023 at 15:19, Arnd Bergmann <arnd@kernel.org> wrote:
>
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Without this, the newly added driver fails to link:
>>
>> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
>> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
>>
>> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/clk/meson/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
>> index c5303e4c16043..3c28560b0faba 100644
>> --- a/drivers/clk/meson/Kconfig
>> +++ b/drivers/clk/meson/Kconfig
>> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
>> tristate "S4 SoC PLL clock controllers support"
>> depends on ARM64
>> default y
>> + select COMMON_CLK_MESON_CLKC_UTILS
>> select COMMON_CLK_MESON_MPLL
>> select COMMON_CLK_MESON_PLL
>> select COMMON_CLK_MESON_REGMAP
>
> Thx Arnd and sorry about this.
>
> Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
>
> Stephen, do you mind taking this directly ?
I ran into the same bug with drivers/clk/meson/s4-peripherals.c,
sending a v2 of my patch to fix both at the same time, assuming
v1 has not been applied yet (it's not in today's linux-next).
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-23 10:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-20 13:19 [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS Arnd Bergmann
2023-10-20 13:28 ` Neil Armstrong
2023-10-20 13:35 ` Jerome Brunet
2023-10-23 10:27 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome