[PATCH] staging: rtl8192e: renamed variable HTIOTActIsDisableMCSTwoSpatialStream

[PATCH] staging: rtl8192e: renamed variable HTIOTActIsDisableMCSTwoSpatialStream

[Gary Rookard]

Renamed from Pascal/Code to Snake case the variable
HTIOTActIsDisableTwoSpatialStream,
HTIOTActIsDisableMCSTwoSpatialStream ->
	ht_iot_act_is_disable_mcs_two_spatial_stream.

Linux kernel coding style (cleanup), checkpatch Avoid CamelCase.
Driver rtl8192e compiles.

Signed-off-by: Gary Rookard <garyrookard@fastmail.org>
---
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 8868672131a1..e9d369df9a70 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -217,7 +217,7 @@ static bool ht_iot_act_is_disable_mcs15(struct rtllib_device *ieee)
 	return false;
 }
 
-static bool HTIOTActIsDisableMCSTwoSpatialStream(struct rtllib_device *ieee)
+static bool ht_iot_act_is_disable_mcs_two_spatial_stream(struct rtllib_device *ieee)
 {
 	return false;
 }
@@ -704,7 +704,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
 		if (bIOTAction)
 			ht_info->iot_action |= HT_IOT_ACT_DISABLE_MCS15;
 
-		bIOTAction = HTIOTActIsDisableMCSTwoSpatialStream(ieee);
+		bIOTAction = ht_iot_act_is_diable_mcs_two_spatial_stream(ieee);
 		if (bIOTAction)
 			ht_info->iot_action |= HT_IOT_ACT_DISABLE_ALL_2SS;
 
-- 
2.41.0

Re: [PATCH] staging: rtl8192e: renamed variable HTIOTActIsDisableMCSTwoSpatialStream

[kernel test robot]

Hi Gary,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Gary-Rookard/staging-rtl8192e-renamed-variable-HTIOTActIsDisableMCSTwoSpatialStream/20231022-082912
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20231022002646.11861-1-garyrookard%40fastmail.org
patch subject: [PATCH] staging: rtl8192e: renamed variable HTIOTActIsDisableMCSTwoSpatialStream
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20231022/202310220944.r88EaZm2-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231022/202310220944.r88EaZm2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310220944.r88EaZm2-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/staging/rtl8192e/rtl819x_HTProc.c: In function 'HTResetSelfAndSavePeerSetting':
>> drivers/staging/rtl8192e/rtl819x_HTProc.c:707:30: error: implicit declaration of function 'ht_iot_act_is_diable_mcs_two_spatial_stream'; did you mean 'ht_iot_act_is_disable_mcs_two_spatial_stream'? [-Werror=implicit-function-declaration]
     707 |                 bIOTAction = ht_iot_act_is_diable_mcs_two_spatial_stream(ieee);
         |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |                              ht_iot_act_is_disable_mcs_two_spatial_stream
   drivers/staging/rtl8192e/rtl819x_HTProc.c: At top level:
>> drivers/staging/rtl8192e/rtl819x_HTProc.c:220:13: warning: 'ht_iot_act_is_disable_mcs_two_spatial_stream' defined but not used [-Wunused-function]
     220 | static bool ht_iot_act_is_disable_mcs_two_spatial_stream(struct rtllib_device *ieee)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +707 drivers/staging/rtl8192e/rtl819x_HTProc.c

   657	
   658	void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,
   659					   struct rtllib_network *pNetwork)
   660	{
   661		struct rt_hi_throughput *ht_info = ieee->ht_info;
   662		u8	bIOTAction = 0;
   663	
   664		/* unmark enable_ht flag here is the same reason why unmarked in
   665		 * function rtllib_softmac_new_net. WB 2008.09.10
   666		 */
   667		if (pNetwork->bssht.bd_support_ht) {
   668			ht_info->current_ht_support = true;
   669			ht_info->ePeerHTSpecVer = pNetwork->bssht.bd_ht_spec_ver;
   670	
   671			if (pNetwork->bssht.bd_ht_cap_len > 0 &&
   672			    pNetwork->bssht.bd_ht_cap_len <= sizeof(ht_info->PeerHTCapBuf))
   673				memcpy(ht_info->PeerHTCapBuf,
   674				       pNetwork->bssht.bd_ht_cap_buf,
   675				       pNetwork->bssht.bd_ht_cap_len);
   676	
   677			if (pNetwork->bssht.bd_ht_info_len > 0 &&
   678			    pNetwork->bssht.bd_ht_info_len <=
   679			    sizeof(ht_info->PeerHTInfoBuf))
   680				memcpy(ht_info->PeerHTInfoBuf,
   681				       pNetwork->bssht.bd_ht_info_buf,
   682				       pNetwork->bssht.bd_ht_info_len);
   683	
   684			if (ht_info->reg_rt2rt_aggregation) {
   685				ht_info->current_rt2rt_aggregation =
   686					 pNetwork->bssht.bd_rt2rt_aggregation;
   687				ht_info->current_rt2rt_long_slot_time =
   688					 pNetwork->bssht.bd_rt2rt_long_slot_time;
   689				ht_info->RT2RT_HT_Mode = pNetwork->bssht.rt2rt_ht_mode;
   690			} else {
   691				ht_info->current_rt2rt_aggregation = false;
   692				ht_info->current_rt2rt_long_slot_time = false;
   693				ht_info->RT2RT_HT_Mode = (enum rt_ht_capability)0;
   694			}
   695	
   696			HTIOTPeerDetermine(ieee);
   697	
   698			ht_info->iot_action = 0;
   699			bIOTAction = HTIOTActIsDisableMCS14(ieee, pNetwork->bssid);
   700			if (bIOTAction)
   701				ht_info->iot_action |= HT_IOT_ACT_DISABLE_MCS14;
   702	
   703			bIOTAction = HTIOTActIsDisableMCS15(ieee);
   704			if (bIOTAction)
   705				ht_info->iot_action |= HT_IOT_ACT_DISABLE_MCS15;
   706	
 > 707			bIOTAction = ht_iot_act_is_diable_mcs_two_spatial_stream(ieee);
   708			if (bIOTAction)
   709				ht_info->iot_action |= HT_IOT_ACT_DISABLE_ALL_2SS;
   710	
   711			bIOTAction = HTIOTActIsDisableEDCATurbo(ieee, pNetwork->bssid);
   712			if (bIOTAction)
   713				ht_info->iot_action |= HT_IOT_ACT_DISABLE_EDCA_TURBO;
   714	
   715			bIOTAction = HTIOTActIsMgntUseCCK6M(ieee, pNetwork);
   716			if (bIOTAction)
   717				ht_info->iot_action |= HT_IOT_ACT_MGNT_USE_CCK_6M;
   718			bIOTAction = HTIOTActIsCCDFsync(ieee);
   719			if (bIOTAction)
   720				ht_info->iot_action |= HT_IOT_ACT_CDD_FSYNC;
   721		} else {
   722			ht_info->current_ht_support = false;
   723			ht_info->current_rt2rt_aggregation = false;
   724			ht_info->current_rt2rt_long_slot_time = false;
   725			ht_info->RT2RT_HT_Mode = (enum rt_ht_capability)0;
   726	
   727			ht_info->iot_action = 0;
   728			ht_info->iot_ra_func = 0;
   729		}
   730	}
   731	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki