* [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER
@ 2023-10-23 11:55 Arnd Bergmann
2023-10-23 13:02 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Arnd Bergmann @ 2023-10-23 11:55 UTC (permalink / raw)
To: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Konrad Dybcio,
Luca Weiss
Cc: Arnd Bergmann, Jessica Zhang, Sam Ravnborg, Linus Walleij,
dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
As with several other panel drivers, this fails to link without the DP
helper library:
ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
Select the same symbols that the others already use.
Fixes: 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/panel/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 99e14dc212ecb..a4ac4b47777fe 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
depends on OF
depends on DRM_MIPI_DSI
depends on BACKLIGHT_CLASS_DEVICE
+ select DRM_DISPLAY_DP_HELPER
+ select DRM_DISPLAY_HELPER
help
Say Y here if you want to enable support for Raydium RM692E5-based
display panels, such as the one found in the Fairphone 5 smartphone.
--
2.39.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER
2023-10-23 11:55 [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER Arnd Bergmann
@ 2023-10-23 13:02 ` Neil Armstrong
2023-10-23 13:25 ` Neil Armstrong
2024-01-12 9:29 ` Neil Armstrong
2 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2023-10-23 13:02 UTC (permalink / raw)
To: Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Konrad Dybcio,
Luca Weiss
Cc: Arnd Bergmann, Jessica Zhang, Sam Ravnborg, Linus Walleij,
dri-devel, linux-kernel
On 23/10/2023 13:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> As with several other panel drivers, this fails to link without the DP
> helper library:
>
> ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
> panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
>
> Select the same symbols that the others already use.
>
> Fixes: 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/panel/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 99e14dc212ecb..a4ac4b47777fe 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> + select DRM_DISPLAY_DP_HELPER
> + select DRM_DISPLAY_HELPER
> help
> Say Y here if you want to enable support for Raydium RM692E5-based
> display panels, such as the one found in the Fairphone 5 smartphone.
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER
2023-10-23 11:55 [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER Arnd Bergmann
2023-10-23 13:02 ` Neil Armstrong
@ 2023-10-23 13:25 ` Neil Armstrong
2023-10-23 13:35 ` Konrad Dybcio
2023-12-28 7:46 ` Luca Weiss
2024-01-12 9:29 ` Neil Armstrong
2 siblings, 2 replies; 6+ messages in thread
From: Neil Armstrong @ 2023-10-23 13:25 UTC (permalink / raw)
To: Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Konrad Dybcio,
Luca Weiss
Cc: Arnd Bergmann, Jessica Zhang, Sam Ravnborg, Linus Walleij,
dri-devel, linux-kernel
Hi,
On 23/10/2023 13:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> As with several other panel drivers, this fails to link without the DP
> helper library:
>
> ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
> panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
>
> Select the same symbols that the others already use.
>
> Fixes: 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/panel/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 99e14dc212ecb..a4ac4b47777fe 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
> depends on OF
> depends on DRM_MIPI_DSI
> depends on BACKLIGHT_CLASS_DEVICE
> + select DRM_DISPLAY_DP_HELPER
> + select DRM_DISPLAY_HELPER
> help
> Say Y here if you want to enable support for Raydium RM692E5-based
> display panels, such as the one found in the Fairphone 5 smartphone.
Will apply once drm-misc-next-fixes is synced with the last drm-misc-next PR for v6.7.
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER
2023-10-23 13:25 ` Neil Armstrong
@ 2023-10-23 13:35 ` Konrad Dybcio
2023-12-28 7:46 ` Luca Weiss
1 sibling, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-10-23 13:35 UTC (permalink / raw)
To: neil.armstrong, Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Luca Weiss
Cc: Arnd Bergmann, Jessica Zhang, Sam Ravnborg, Linus Walleij,
dri-devel, linux-kernel
On 23.10.2023 15:25, Neil Armstrong wrote:
> Hi,
>
> On 23/10/2023 13:55, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> As with several other panel drivers, this fails to link without the DP
>> helper library:
>>
>> ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
>> panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
>>
>> Select the same symbols that the others already use.
>>
>> Fixes: 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/gpu/drm/panel/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
>> index 99e14dc212ecb..a4ac4b47777fe 100644
>> --- a/drivers/gpu/drm/panel/Kconfig
>> +++ b/drivers/gpu/drm/panel/Kconfig
>> @@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
>> depends on OF
>> depends on DRM_MIPI_DSI
>> depends on BACKLIGHT_CLASS_DEVICE
>> + select DRM_DISPLAY_DP_HELPER
>> + select DRM_DISPLAY_HELPER
>> help
>> Say Y here if you want to enable support for Raydium RM692E5-based
>> display panels, such as the one found in the Fairphone 5 smartphone.
>
> Will apply once drm-misc-next-fixes is synced with the last drm-misc-next PR for v6.7.
Thanks Arnd, Neil.
Sounds like this helper should be extracted from DP specific code
in the future though, no?
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER
2023-10-23 13:25 ` Neil Armstrong
2023-10-23 13:35 ` Konrad Dybcio
@ 2023-12-28 7:46 ` Luca Weiss
1 sibling, 0 replies; 6+ messages in thread
From: Luca Weiss @ 2023-12-28 7:46 UTC (permalink / raw)
To: neil.armstrong, Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Daniel Vetter, Konrad Dybcio
Cc: Arnd Bergmann, Jessica Zhang, Sam Ravnborg, Linus Walleij,
dri-devel, linux-kernel
On Mon Oct 23, 2023 at 3:25 PM CEST, Neil Armstrong wrote:
> Hi,
>
> On 23/10/2023 13:55, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > As with several other panel drivers, this fails to link without the DP
> > helper library:
> >
> > ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
> > panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
> >
> > Select the same symbols that the others already use.
> >
> > Fixes: 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/gpu/drm/panel/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> > index 99e14dc212ecb..a4ac4b47777fe 100644
> > --- a/drivers/gpu/drm/panel/Kconfig
> > +++ b/drivers/gpu/drm/panel/Kconfig
> > @@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
> > depends on OF
> > depends on DRM_MIPI_DSI
> > depends on BACKLIGHT_CLASS_DEVICE
> > + select DRM_DISPLAY_DP_HELPER
> > + select DRM_DISPLAY_HELPER
> > help
> > Say Y here if you want to enable support for Raydium RM692E5-based
> > display panels, such as the one found in the Fairphone 5 smartphone.
>
> Will apply once drm-misc-next-fixes is synced with the last drm-misc-next PR for v6.7.
Hi Neil,
I think this patch is still pending, I don't see it in linux-next.
It was also reported by a buildbot today
https://lore.kernel.org/lkml/202312281138.PHn1Js8S-lkp@intel.com/
Regards
Luca
>
> Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER
2023-10-23 11:55 [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER Arnd Bergmann
2023-10-23 13:02 ` Neil Armstrong
2023-10-23 13:25 ` Neil Armstrong
@ 2024-01-12 9:29 ` Neil Armstrong
2 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2024-01-12 9:29 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
David Airlie, Daniel Vetter, Konrad Dybcio, Luca Weiss,
Arnd Bergmann
Cc: Arnd Bergmann, Jessica Zhang, Sam Ravnborg, Linus Walleij,
dri-devel, linux-kernel
Hi,
On Mon, 23 Oct 2023 13:55:58 +0200, Arnd Bergmann wrote:
> As with several other panel drivers, this fails to link without the DP
> helper library:
>
> ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
> panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
>
> Select the same symbols that the others already use.
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)
[1/1] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=589830b13ac21bddf99b9bc5a4ec17813d0869ef
--
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-01-12 9:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-23 11:55 [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER Arnd Bergmann
2023-10-23 13:02 ` Neil Armstrong
2023-10-23 13:25 ` Neil Armstrong
2023-10-23 13:35 ` Konrad Dybcio
2023-12-28 7:46 ` Luca Weiss
2024-01-12 9:29 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®