mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to yaml
@ 2023-11-01 20:27 Nik Bune
  2023-11-01 20:33 ` Nik Bune
  0 siblings, 1 reply; 3+ messages in thread
From: Nik Bune @ 2023-11-01 20:27 UTC (permalink / raw)
  To: wim, linux, robh+dt, krzysztof.kozlowski+dt, conor+dt, skhan, juhosg
  Cc: Nik Bune, linux-watchdog, devicetree, linux-kernel

Convert txt file to yaml. Add maintainers from git blame. Drop qca,ar9330-wdt from example of compatible property and leave only qca,ar7130-wdt, as description of property mentioned must be qca,ar7130-wdt.

Signed-off-by: Nik Bune <n2h9z4@gmail.com>
---
 .../bindings/watchdog/qca,ar7130-wdt.yaml     | 33 +++++++++++++++++++
 .../bindings/watchdog/qca-ar7130-wdt.txt      | 13 --------
 2 files changed, 33 insertions(+), 13 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/watchdog/qca,ar7130-wdt.yaml
 delete mode 100644 Documentation/devicetree/bindings/watchdog/qca-ar7130-wdt.txt

diff --git a/Documentation/devicetree/bindings/watchdog/qca,ar7130-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qca,ar7130-wdt.yaml
new file mode 100644
index 000000000000..82040ca10eda
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/qca,ar7130-wdt.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/qca,ar7130-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Atheros AR7130 Watchdog Timer (WDT) Controller
+
+maintainers:
+  - Gabor Juhos <juhosg@openwrt.org>
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    const: qca,ar7130-wdt
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    watchdog@18060008 {
+        compatible = "qca,ar7130-wdt";
+        reg = <0x18060008 0x8>;
+    };
diff --git a/Documentation/devicetree/bindings/watchdog/qca-ar7130-wdt.txt b/Documentation/devicetree/bindings/watchdog/qca-ar7130-wdt.txt
deleted file mode 100644
index 7a89e5f85415..000000000000
--- a/Documentation/devicetree/bindings/watchdog/qca-ar7130-wdt.txt
+++ /dev/null
@@ -1,13 +0,0 @@
-* Qualcomm Atheros AR7130 Watchdog Timer (WDT) Controller
-
-Required properties:
-- compatible: must be "qca,ar7130-wdt"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-
-Example:
-
-wdt@18060008 {
-	compatible = "qca,ar9330-wdt", "qca,ar7130-wdt";
-	reg = <0x18060008 0x8>;
-};
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to yaml
  2023-11-01 20:27 [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to yaml Nik Bune
@ 2023-11-01 20:33 ` Nik Bune
  2023-11-01 21:03   ` Guenter Roeck
  0 siblings, 1 reply; 3+ messages in thread
From: Nik Bune @ 2023-11-01 20:33 UTC (permalink / raw)
  To: n2h9z4
  Cc: krzysztof.kozlowski+dt, robh, conor+dt, devicetree, linux-kernel,
	linux-watchdog, linux, skhan, wim

Changes in v2: updated commit message. 

v1 patch: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231031201602.28827-1-n2h9z4@gmail.com/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to yaml
  2023-11-01 20:33 ` Nik Bune
@ 2023-11-01 21:03   ` Guenter Roeck
  0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2023-11-01 21:03 UTC (permalink / raw)
  To: Nik Bune
  Cc: krzysztof.kozlowski+dt, robh, conor+dt, devicetree, linux-kernel,
	linux-watchdog, skhan, wim

On 11/1/23 13:33, Nik Bune wrote:
> Changes in v2: updated commit message.
> 
> v1 patch: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231031201602.28827-1-n2h9z4@gmail.com/


Unfortunately, you didn't run checkpatch on your uudate, meaning it missed

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)

Indeed, your patch now provides a single-line commit description with more than
200 characters.

I don't think "Keep it in one line" was meant to ask you to do that.
The original description was substantially shorter and did fit into 75 characters.

Guenter


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-11-01 21:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-01 20:27 [PATCH v2] dt-bindings: watchdog: qca,ar7130-wdt: convert txt to yaml Nik Bune
2023-11-01 20:33 ` Nik Bune
2023-11-01 21:03   ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®