* [PATCH] ASoC: sti-uniperf: Use default pcm_config instead
@ 2023-11-06 12:51 Keguang Zhang
2023-11-13 14:05 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Keguang Zhang @ 2023-11-06 12:51 UTC (permalink / raw)
To: Arnaud Pouliquen, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: alsa-devel, linux-kernel, Keguang Zhang
The sti-uniperf pcm_config is the same as the default pcm_config.
Since commit 43556516fffe ("ASoC: soc-generic-dmaengine-pcm:
Use default config when none is given"), passing a NULL pointer
could let this driver use the default config.
Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
---
sound/soc/sti/sti_uniperif.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c
index 2c21a86421e6..ba824f14a39c 100644
--- a/sound/soc/sti/sti_uniperif.c
+++ b/sound/soc/sti/sti_uniperif.c
@@ -461,10 +461,6 @@ static int sti_uniperiph_cpu_dai_of(struct device_node *node,
return 0;
}
-static const struct snd_dmaengine_pcm_config dmaengine_pcm_config = {
- .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config,
-};
-
static int sti_uniperiph_probe(struct platform_device *pdev)
{
struct sti_uniperiph_data *priv;
@@ -493,8 +489,7 @@ static int sti_uniperiph_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- return devm_snd_dmaengine_pcm_register(&pdev->dev,
- &dmaengine_pcm_config, 0);
+ return devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
}
static struct platform_driver sti_uniperiph_driver = {
---
base-commit: ffc253263a1375a65fa6c9f62a893e9767fbebfa
change-id: 20231106-sti-uniperf-a22e2ef92e6c
Best regards,
--
Keguang Zhang <keguang.zhang@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: sti-uniperf: Use default pcm_config instead
2023-11-06 12:51 [PATCH] ASoC: sti-uniperf: Use default pcm_config instead Keguang Zhang
@ 2023-11-13 14:05 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2023-11-13 14:05 UTC (permalink / raw)
To: Arnaud Pouliquen, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Keguang Zhang
Cc: alsa-devel, linux-kernel
On Mon, 06 Nov 2023 20:51:03 +0800, Keguang Zhang wrote:
> The sti-uniperf pcm_config is the same as the default pcm_config.
>
> Since commit 43556516fffe ("ASoC: soc-generic-dmaengine-pcm:
> Use default config when none is given"), passing a NULL pointer
> could let this driver use the default config.
>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: sti-uniperf: Use default pcm_config instead
commit: bb341f75a05238ccd35b1ec1eb1849a3955eebb3
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-13 14:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-06 12:51 [PATCH] ASoC: sti-uniperf: Use default pcm_config instead Keguang Zhang
2023-11-13 14:05 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®