* [PATCH] bcachefs: make bch2_target_to_text_sb static
@ 2023-11-06 2:34 Jiapeng Chong
2023-11-06 3:08 ` Kent Overstreet
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-11-06 2:34 UTC (permalink / raw)
To: kent.overstreet
Cc: bfoster, linux-bcachefs, linux-kernel, Jiapeng Chong, Abaci Robot
The bch2_target_to_text_sb are not used outside the file disk_groups.c,
so the modification is defined as static.
fs/bcachefs/disk_groups.c:583:6: warning: no previous prototype for ‘bch2_target_to_text_sb’.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7144
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/bcachefs/disk_groups.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bcachefs/disk_groups.c b/fs/bcachefs/disk_groups.c
index d613695abf9f..1f334124055b 100644
--- a/fs/bcachefs/disk_groups.c
+++ b/fs/bcachefs/disk_groups.c
@@ -580,7 +580,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v)
}
}
-void bch2_target_to_text_sb(struct printbuf *out, struct bch_sb *sb, unsigned v)
+static void bch2_target_to_text_sb(struct printbuf *out, struct bch_sb *sb, unsigned v)
{
struct target t = target_decode(v);
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bcachefs: make bch2_target_to_text_sb static
2023-11-06 2:34 [PATCH] bcachefs: make bch2_target_to_text_sb static Jiapeng Chong
@ 2023-11-06 3:08 ` Kent Overstreet
0 siblings, 0 replies; 2+ messages in thread
From: Kent Overstreet @ 2023-11-06 3:08 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: bfoster, linux-bcachefs, linux-kernel, Abaci Robot
On Mon, Nov 06, 2023 at 10:34:01AM +0800, Jiapeng Chong wrote:
> The bch2_target_to_text_sb are not used outside the file disk_groups.c,
> so the modification is defined as static.
>
> fs/bcachefs/disk_groups.c:583:6: warning: no previous prototype for ‘bch2_target_to_text_sb’.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7144
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thanks, applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-06 3:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-06 2:34 [PATCH] bcachefs: make bch2_target_to_text_sb static Jiapeng Chong
2023-11-06 3:08 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®