From: Peter Zijlstra <peterz@infradead.org>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] sched: Don't account execution time for task group
Date: Mon, 6 Nov 2023 13:49:12 +0100 [thread overview]
Message-ID: <20231106124912.GM8262@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20231031125928.235685-2-yajun.deng@linux.dev>
On Tue, Oct 31, 2023 at 08:59:26PM +0800, Yajun Deng wrote:
> The rt entity can be a task group. We will account execution time for
> each task. For consistency, we don't need to account execution time for
> task group.
>
> Pass a parameter to update_current_exec_runtime, let the caller decide
> whether account execution time.
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 6aaf0a3d6081..79cf80d73822 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1018,7 +1018,8 @@ static void update_curr_rt(struct rq *rq)
>
> trace_sched_stat_runtime(curr, delta_exec, 0);
>
> - update_current_exec_runtime(curr, now, delta_exec);
> + update_current_exec_runtime(curr, now, delta_exec,
> + rt_entity_is_task(rt_se));
>
> if (!rt_bandwidth_enabled())
> return;
ok, I think I've managed to confuse myself again.
But at this point rt_se := &rq->curr->rt, which is *always* a task, no?
next prev parent reply other threads:[~2023-11-06 12:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 12:59 [PATCH v3 0/3] Use update_current_exec_runtime simplify code Yajun Deng
2023-10-31 12:59 ` [PATCH v3 1/3] sched: Don't account execution time for task group Yajun Deng
2023-11-06 12:49 ` Peter Zijlstra [this message]
2023-11-07 3:49 ` Yajun Deng
2023-10-31 12:59 ` [PATCH v3 2/3] sched: Don't trace stat runtime " Yajun Deng
2023-10-31 12:59 ` [PATCH v3 3/3] sched/fair: Simplify update_curr() Yajun Deng
2023-11-06 12:35 ` [PATCH v3 0/3] Use update_current_exec_runtime simplify code Peter Zijlstra
2023-11-07 3:39 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106124912.GM8262@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®