* kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces)
@ 2023-11-08 5:55 kernel test robot
2023-11-08 14:48 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2023-11-08 5:55 UTC (permalink / raw)
To: Waiman Long; +Cc: oe-kbuild-all, linux-kernel, Steven Rostedt (Google)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 305230142ae0637213bf6e04f6d9f10bbcb74af8
commit: c0a581d7126c0bbc96163276f585fd7b4e4d8d0e tracing: Disable interrupt or preemption before acquiring arch_spinlock_t
date: 1 year, 1 month ago
config: loongarch-randconfig-r123-20231107 (https://download.01.org/0day-ci/archive/20231108/202311081340.3k72KKdg-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231108/202311081340.3k72KKdg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311081340.3k72KKdg-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
kernel/trace/trace.c:406:28: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
kernel/trace/trace.c:406:28: sparse: expected struct trace_export **list
kernel/trace/trace.c:406:28: sparse: got struct trace_export [noderef] __rcu **
kernel/trace/trace.c:420:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
kernel/trace/trace.c:420:33: sparse: expected struct trace_export **list
kernel/trace/trace.c:420:33: sparse: got struct trace_export [noderef] __rcu **
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
kernel/trace/trace.c:2879:38: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct event_filter *filter @@ got struct event_filter [noderef] __rcu *filter @@
kernel/trace/trace.c:2879:38: sparse: expected struct event_filter *filter
kernel/trace/trace.c:2879:38: sparse: got struct event_filter [noderef] __rcu *filter
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:360:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/trace/trace.c:360:9: sparse: struct trace_export [noderef] __rcu *
kernel/trace/trace.c:360:9: sparse: struct trace_export *
kernel/trace/trace.c:375:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/trace/trace.c:375:9: sparse: struct trace_export [noderef] __rcu *
kernel/trace/trace.c:375:9: sparse: struct trace_export *
vim +2430 kernel/trace/trace.c
2410
2411 static int trace_save_cmdline(struct task_struct *tsk)
2412 {
2413 unsigned tpid, idx;
2414
2415 /* treat recording of idle task as a success */
2416 if (!tsk->pid)
2417 return 1;
2418
2419 tpid = tsk->pid & (PID_MAX_DEFAULT - 1);
2420
2421 /*
2422 * It's not the end of the world if we don't get
2423 * the lock, but we also don't want to spin
2424 * nor do we want to disable interrupts,
2425 * so if we miss here, then better luck next time.
2426 *
2427 * This is called within the scheduler and wake up, so interrupts
2428 * had better been disabled and run queue lock been held.
2429 */
> 2430 lockdep_assert_preemption_disabled();
2431 if (!arch_spin_trylock(&trace_cmdline_lock))
2432 return 0;
2433
2434 idx = savedcmd->map_pid_to_cmdline[tpid];
2435 if (idx == NO_CMDLINE_MAP) {
2436 idx = (savedcmd->cmdline_idx + 1) % savedcmd->cmdline_num;
2437
2438 savedcmd->map_pid_to_cmdline[tpid] = idx;
2439 savedcmd->cmdline_idx = idx;
2440 }
2441
2442 savedcmd->map_cmdline_to_pid[idx] = tsk->pid;
2443 set_cmdline(idx, tsk->comm);
2444
2445 arch_spin_unlock(&trace_cmdline_lock);
2446
2447 return 1;
2448 }
2449
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces)
2023-11-08 5:55 kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
@ 2023-11-08 14:48 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2023-11-08 14:48 UTC (permalink / raw)
To: kernel test robot
Cc: Waiman Long, oe-kbuild-all, linux-kernel, Sui Jingfeng, dri-devel
On Wed, 8 Nov 2023 13:55:21 +0800
kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 305230142ae0637213bf6e04f6d9f10bbcb74af8
> commit: c0a581d7126c0bbc96163276f585fd7b4e4d8d0e tracing: Disable interrupt or preemption before acquiring arch_spinlock_t
> date: 1 year, 1 month ago
> config: loongarch-randconfig-r123-20231107 (https://download.01.org/0day-ci/archive/20231108/202311081340.3k72KKdg-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 13.2.0
> reproduce: (https://download.01.org/0day-ci/archive/20231108/202311081340.3k72KKdg-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311081340.3k72KKdg-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> kernel/trace/trace.c:406:28: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
> kernel/trace/trace.c:406:28: sparse: expected struct trace_export **list
> kernel/trace/trace.c:406:28: sparse: got struct trace_export [noderef] __rcu **
> kernel/trace/trace.c:420:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
> kernel/trace/trace.c:420:33: sparse: expected struct trace_export **list
> kernel/trace/trace.c:420:33: sparse: got struct trace_export [noderef] __rcu **
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
>
> vim +2430 kernel/trace/trace.c
>
> 2410
> 2411 static int trace_save_cmdline(struct task_struct *tsk)
> 2412 {
> 2413 unsigned tpid, idx;
> 2414
> 2415 /* treat recording of idle task as a success */
> 2416 if (!tsk->pid)
> 2417 return 1;
> 2418
> 2419 tpid = tsk->pid & (PID_MAX_DEFAULT - 1);
> 2420
> 2421 /*
> 2422 * It's not the end of the world if we don't get
> 2423 * the lock, but we also don't want to spin
> 2424 * nor do we want to disable interrupts,
> 2425 * so if we miss here, then better luck next time.
> 2426 *
> 2427 * This is called within the scheduler and wake up, so interrupts
> 2428 * had better been disabled and run queue lock been held.
> 2429 */
> > 2430 lockdep_assert_preemption_disabled();
The above is a generic lockdep utility. Sounds to me that this is a bug in
the loongarch code that doesn't handle this properly.
-- Steve
> 2431 if (!arch_spin_trylock(&trace_cmdline_lock))
> 2432 return 0;
> 2433
> 2434 idx = savedcmd->map_pid_to_cmdline[tpid];
> 2435 if (idx == NO_CMDLINE_MAP) {
> 2436 idx = (savedcmd->cmdline_idx + 1) % savedcmd->cmdline_num;
> 2437
> 2438 savedcmd->map_pid_to_cmdline[tpid] = idx;
> 2439 savedcmd->cmdline_idx = idx;
> 2440 }
> 2441
> 2442 savedcmd->map_cmdline_to_pid[idx] = tsk->pid;
> 2443 set_cmdline(idx, tsk->comm);
> 2444
> 2445 arch_spin_unlock(&trace_cmdline_lock);
> 2446
> 2447 return 1;
> 2448 }
> 2449
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces)
@ 2023-07-01 23:01 kernel test robot
2023-07-06 15:47 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2023-07-01 23:01 UTC (permalink / raw)
To: Waiman Long; +Cc: oe-kbuild-all, linux-kernel, Steven Rostedt (Google)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dfab92f27c600fea3cadc6e2cb39f092024e1fef
commit: c0a581d7126c0bbc96163276f585fd7b4e4d8d0e tracing: Disable interrupt or preemption before acquiring arch_spinlock_t
date: 9 months ago
config: loongarch-randconfig-r073-20230627 (https://download.01.org/0day-ci/archive/20230702/202307020600.1oOCL8pD-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230702/202307020600.1oOCL8pD-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307020600.1oOCL8pD-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
kernel/trace/trace.c:406:28: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
kernel/trace/trace.c:406:28: sparse: expected struct trace_export **list
kernel/trace/trace.c:406:28: sparse: got struct trace_export [noderef] __rcu **
kernel/trace/trace.c:420:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
kernel/trace/trace.c:420:33: sparse: expected struct trace_export **list
kernel/trace/trace.c:420:33: sparse: got struct trace_export [noderef] __rcu **
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
>> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
kernel/trace/trace.c:2430:9: sparse: expected void *ptr
kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
kernel/trace/trace.c:2879:38: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct event_filter *filter @@ got struct event_filter [noderef] __rcu *filter @@
kernel/trace/trace.c:2879:38: sparse: expected struct event_filter *filter
kernel/trace/trace.c:2879:38: sparse: got struct event_filter [noderef] __rcu *filter
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
kernel/trace/trace.c:7354:20: sparse: expected void *ptr
kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
kernel/trace/trace.c:360:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/trace/trace.c:360:9: sparse: struct trace_export [noderef] __rcu *
kernel/trace/trace.c:360:9: sparse: struct trace_export *
kernel/trace/trace.c:375:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
kernel/trace/trace.c:375:9: sparse: struct trace_export [noderef] __rcu *
kernel/trace/trace.c:375:9: sparse: struct trace_export *
vim +2430 kernel/trace/trace.c
2410
2411 static int trace_save_cmdline(struct task_struct *tsk)
2412 {
2413 unsigned tpid, idx;
2414
2415 /* treat recording of idle task as a success */
2416 if (!tsk->pid)
2417 return 1;
2418
2419 tpid = tsk->pid & (PID_MAX_DEFAULT - 1);
2420
2421 /*
2422 * It's not the end of the world if we don't get
2423 * the lock, but we also don't want to spin
2424 * nor do we want to disable interrupts,
2425 * so if we miss here, then better luck next time.
2426 *
2427 * This is called within the scheduler and wake up, so interrupts
2428 * had better been disabled and run queue lock been held.
2429 */
> 2430 lockdep_assert_preemption_disabled();
2431 if (!arch_spin_trylock(&trace_cmdline_lock))
2432 return 0;
2433
2434 idx = savedcmd->map_pid_to_cmdline[tpid];
2435 if (idx == NO_CMDLINE_MAP) {
2436 idx = (savedcmd->cmdline_idx + 1) % savedcmd->cmdline_num;
2437
2438 savedcmd->map_pid_to_cmdline[tpid] = idx;
2439 savedcmd->cmdline_idx = idx;
2440 }
2441
2442 savedcmd->map_cmdline_to_pid[idx] = tsk->pid;
2443 set_cmdline(idx, tsk->comm);
2444
2445 arch_spin_unlock(&trace_cmdline_lock);
2446
2447 return 1;
2448 }
2449
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces)
2023-07-01 23:01 kernel test robot
@ 2023-07-06 15:47 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2023-07-06 15:47 UTC (permalink / raw)
To: kernel test robot; +Cc: Waiman Long, oe-kbuild-all, linux-kernel
On Sun, 2 Jul 2023 07:01:54 +0800
kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: dfab92f27c600fea3cadc6e2cb39f092024e1fef
> commit: c0a581d7126c0bbc96163276f585fd7b4e4d8d0e tracing: Disable interrupt or preemption before acquiring arch_spinlock_t
> date: 9 months ago
> config: loongarch-randconfig-r073-20230627 (https://download.01.org/0day-ci/archive/20230702/202307020600.1oOCL8pD-lkp@intel.com/config)
> compiler: loongarch64-linux-gcc (GCC) 12.3.0
> reproduce: (https://download.01.org/0day-ci/archive/20230702/202307020600.1oOCL8pD-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202307020600.1oOCL8pD-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> kernel/trace/trace.c:406:28: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
> kernel/trace/trace.c:406:28: sparse: expected struct trace_export **list
> kernel/trace/trace.c:406:28: sparse: got struct trace_export [noderef] __rcu **
> kernel/trace/trace.c:420:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct trace_export **list @@ got struct trace_export [noderef] __rcu ** @@
> kernel/trace/trace.c:420:33: sparse: expected struct trace_export **list
> kernel/trace/trace.c:420:33: sparse: got struct trace_export [noderef] __rcu **
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got unsigned int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got unsigned int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
> >> kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got int [noderef] __percpu * @@
> kernel/trace/trace.c:2430:9: sparse: expected void *ptr
> kernel/trace/trace.c:2430:9: sparse: got int [noderef] __percpu *
> kernel/trace/trace.c:2879:38: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct event_filter *filter @@ got struct event_filter [noderef] __rcu *filter @@
> kernel/trace/trace.c:2879:38: sparse: expected struct event_filter *filter
> kernel/trace/trace.c:2879:38: sparse: got struct event_filter [noderef] __rcu *filter
> kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
> kernel/trace/trace.c:7354:20: sparse: expected void *ptr
> kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
> kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
> kernel/trace/trace.c:7354:20: sparse: expected void *ptr
> kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
> kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
> kernel/trace/trace.c:7354:20: sparse: expected void *ptr
> kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
> kernel/trace/trace.c:7354:20: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void *ptr @@ got struct ring_buffer_event *[noderef] __percpu * @@
> kernel/trace/trace.c:7354:20: sparse: expected void *ptr
> kernel/trace/trace.c:7354:20: sparse: got struct ring_buffer_event *[noderef] __percpu *
> kernel/trace/trace.c:360:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
> kernel/trace/trace.c:360:9: sparse: struct trace_export [noderef] __rcu *
> kernel/trace/trace.c:360:9: sparse: struct trace_export *
> kernel/trace/trace.c:375:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
> kernel/trace/trace.c:375:9: sparse: struct trace_export [noderef] __rcu *
> kernel/trace/trace.c:375:9: sparse: struct trace_export *
>
> vim +2430 kernel/trace/trace.c
>
> 2410
> 2411 static int trace_save_cmdline(struct task_struct *tsk)
> 2412 {
> 2413 unsigned tpid, idx;
> 2414
> 2415 /* treat recording of idle task as a success */
> 2416 if (!tsk->pid)
> 2417 return 1;
> 2418
> 2419 tpid = tsk->pid & (PID_MAX_DEFAULT - 1);
> 2420
> 2421 /*
> 2422 * It's not the end of the world if we don't get
> 2423 * the lock, but we also don't want to spin
> 2424 * nor do we want to disable interrupts,
> 2425 * so if we miss here, then better luck next time.
> 2426 *
> 2427 * This is called within the scheduler and wake up, so interrupts
> 2428 * had better been disabled and run queue lock been held.
> 2429 */
> > 2430 lockdep_assert_preemption_disabled();
So this looks to me to be a bug in the way loongarch handles per cpu
variables, and any new access to this_cpu_read() is likely to trigger this
warning.
-- Steve
> 2431 if (!arch_spin_trylock(&trace_cmdline_lock))
> 2432 return 0;
> 2433
> 2434 idx = savedcmd->map_pid_to_cmdline[tpid];
> 2435 if (idx == NO_CMDLINE_MAP) {
> 2436 idx = (savedcmd->cmdline_idx + 1) %
> savedcmd->cmdline_num; 2437
> 2438 savedcmd->map_pid_to_cmdline[tpid] = idx;
> 2439 savedcmd->cmdline_idx = idx;
> 2440 }
> 2441
> 2442 savedcmd->map_cmdline_to_pid[idx] = tsk->pid;
> 2443 set_cmdline(idx, tsk->comm);
> 2444
> 2445 arch_spin_unlock(&trace_cmdline_lock);
> 2446
> 2447 return 1;
> 2448 }
> 2449
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-08 14:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-08 5:55 kernel/trace/trace.c:2430:9: sparse: sparse: incorrect type in argument 1 (different address spaces) kernel test robot
2023-11-08 14:48 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2023-07-01 23:01 kernel test robot
2023-07-06 15:47 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®