mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] power: supply: cw2015: correct time_to_empty units in sysfs
@ 2023-11-11 22:17 Jan Palus
  2023-11-16  0:35 ` Sebastian Reichel
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Palus @ 2023-11-11 22:17 UTC (permalink / raw)
  To: Tobias Schrammm, Sebastian Reichel, linux-pm, linux-kernel; +Cc: Jan Palus

RRT_ALRT register holds remaining battery time in minutes therefore it
needs to be scaled accordingly when exposing TIME_TO_EMPTY via sysfs
expressed in seconds

Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
Signed-off-by: Jan Palus <jpalus@fastmail.com>
---
 drivers/power/supply/cw2015_battery.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index bb29e9ebd24a..99f3ccdc30a6 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -491,7 +491,7 @@ static int cw_battery_get_property(struct power_supply *psy,
 
 	case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW:
 		if (cw_battery_valid_time_to_empty(cw_bat))
-			val->intval = cw_bat->time_to_empty;
+			val->intval = cw_bat->time_to_empty * 60;
 		else
 			val->intval = 0;
 		break;
-- 
2.42.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] power: supply: cw2015: correct time_to_empty units in sysfs
  2023-11-11 22:17 [PATCH] power: supply: cw2015: correct time_to_empty units in sysfs Jan Palus
@ 2023-11-16  0:35 ` Sebastian Reichel
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2023-11-16  0:35 UTC (permalink / raw)
  To: Tobias Schrammm, Sebastian Reichel, linux-pm, linux-kernel, Jan Palus


On Sat, 11 Nov 2023 23:17:04 +0100, Jan Palus wrote:
> RRT_ALRT register holds remaining battery time in minutes therefore it
> needs to be scaled accordingly when exposing TIME_TO_EMPTY via sysfs
> expressed in seconds
> 
> 

Applied, thanks!

[1/1] power: supply: cw2015: correct time_to_empty units in sysfs
      commit: f37669119423ca852ca855b24732f25c0737aa57

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-16  0:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-11 22:17 [PATCH] power: supply: cw2015: correct time_to_empty units in sysfs Jan Palus
2023-11-16  0:35 ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®