From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-nilfs@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 11/20] nilfs2: Convert nilfs_page_mkwrite() to use a folio
Date: Tue, 14 Nov 2023 17:44:27 +0900 [thread overview]
Message-ID: <20231114084436.2755-12-konishi.ryusuke@gmail.com> (raw)
In-Reply-To: <20231114084436.2755-1-konishi.ryusuke@gmail.com>
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Using the new folio APIs saves seven hidden calls to compound_head().
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
---
fs/nilfs2/file.c | 28 +++++++++++++++-------------
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/fs/nilfs2/file.c b/fs/nilfs2/file.c
index 740ce26d1e76..bec33b89a075 100644
--- a/fs/nilfs2/file.c
+++ b/fs/nilfs2/file.c
@@ -45,34 +45,36 @@ int nilfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)
{
struct vm_area_struct *vma = vmf->vma;
- struct page *page = vmf->page;
+ struct folio *folio = page_folio(vmf->page);
struct inode *inode = file_inode(vma->vm_file);
struct nilfs_transaction_info ti;
+ struct buffer_head *bh, *head;
int ret = 0;
if (unlikely(nilfs_near_disk_full(inode->i_sb->s_fs_info)))
return VM_FAULT_SIGBUS; /* -ENOSPC */
sb_start_pagefault(inode->i_sb);
- lock_page(page);
- if (page->mapping != inode->i_mapping ||
- page_offset(page) >= i_size_read(inode) || !PageUptodate(page)) {
- unlock_page(page);
+ folio_lock(folio);
+ if (folio->mapping != inode->i_mapping ||
+ folio_pos(folio) >= i_size_read(inode) ||
+ !folio_test_uptodate(folio)) {
+ folio_unlock(folio);
ret = -EFAULT; /* make the VM retry the fault */
goto out;
}
/*
- * check to see if the page is mapped already (no holes)
+ * check to see if the folio is mapped already (no holes)
*/
- if (PageMappedToDisk(page))
+ if (folio_test_mappedtodisk(folio))
goto mapped;
- if (page_has_buffers(page)) {
- struct buffer_head *bh, *head;
+ head = folio_buffers(folio);
+ if (head) {
int fully_mapped = 1;
- bh = head = page_buffers(page);
+ bh = head;
do {
if (!buffer_mapped(bh)) {
fully_mapped = 0;
@@ -81,11 +83,11 @@ static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)
} while (bh = bh->b_this_page, bh != head);
if (fully_mapped) {
- SetPageMappedToDisk(page);
+ folio_set_mappedtodisk(folio);
goto mapped;
}
}
- unlock_page(page);
+ folio_unlock(folio);
/*
* fill hole blocks
@@ -105,7 +107,7 @@ static vm_fault_t nilfs_page_mkwrite(struct vm_fault *vmf)
nilfs_transaction_commit(inode->i_sb);
mapped:
- wait_for_stable_page(page);
+ folio_wait_stable(folio);
out:
sb_end_pagefault(inode->i_sb);
return vmf_fs_error(ret);
--
2.34.1
next prev parent reply other threads:[~2023-11-14 8:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:44 [PATCH 00/20] nilfs2: Folio conversions for file paths Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 01/20] nilfs2: Add nilfs_end_folio_io() Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 02/20] nilfs2: Convert nilfs_abort_logs to use folios Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 03/20] nilfs2: Convert nilfs_segctor_complete_write " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 04/20] nilfs2: Convert nilfs_forget_buffer to use a folio Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 05/20] nilfs2: Convert to nilfs_folio_buffers_clean() Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 06/20] nilfs2: Convert nilfs_writepage() to use a folio Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 07/20] nilfs2: Convert nilfs_mdt_write_page() " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 08/20] nilfs2: Convert to nilfs_clear_folio_dirty() Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 09/20] nilfs2: Convert to __nilfs_clear_folio_dirty() Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 10/20] nilfs2: Convert nilfs_segctor_prepare_write to use folios Ryusuke Konishi
2023-11-14 8:44 ` Ryusuke Konishi [this message]
2023-11-14 8:44 ` [PATCH 12/20] nilfs2: Convert nilfs_mdt_create_block to use a folio Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 13/20] nilfs2: Convert nilfs_mdt_submit_block " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 14/20] nilfs2: Convert nilfs_gccache_submit_read_data " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 15/20] nilfs2: Convert nilfs_btnode_create_block " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 16/20] nilfs2: Convert nilfs_btnode_submit_block " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 17/20] nilfs2: Convert nilfs_btnode_delete " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 18/20] nilfs2: Convert nilfs_btnode_prepare_change_key " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 19/20] nilfs2: Convert nilfs_btnode_commit_change_key " Ryusuke Konishi
2023-11-14 8:44 ` [PATCH 20/20] nilfs2: Convert nilfs_btnode_abort_change_key " Ryusuke Konishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231114084436.2755-12-konishi.ryusuke@gmail.com \
--to=konishi.ryusuke@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®