mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ryusuke Konishi <konishi.ryusuke@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-nilfs@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 18/20] nilfs2: Convert nilfs_btnode_prepare_change_key to use a folio
Date: Tue, 14 Nov 2023 17:44:34 +0900	[thread overview]
Message-ID: <20231114084436.2755-19-konishi.ryusuke@gmail.com> (raw)
In-Reply-To: <20231114084436.2755-1-konishi.ryusuke@gmail.com>

From: "Matthew Wilcox (Oracle)" <willy@infradead.org>

Saves three calls to compound_head().

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
---
 fs/nilfs2/btnode.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/nilfs2/btnode.c b/fs/nilfs2/btnode.c
index e077d4a7a11c..da3e4366625f 100644
--- a/fs/nilfs2/btnode.c
+++ b/fs/nilfs2/btnode.c
@@ -185,23 +185,23 @@ int nilfs_btnode_prepare_change_key(struct address_space *btnc,
 	ctxt->newbh = NULL;
 
 	if (inode->i_blkbits == PAGE_SHIFT) {
-		struct page *opage = obh->b_page;
-		lock_page(opage);
+		struct folio *ofolio = obh->b_folio;
+		folio_lock(ofolio);
 retry:
 		/* BUG_ON(oldkey != obh->b_folio->index); */
-		if (unlikely(oldkey != opage->index))
-			NILFS_PAGE_BUG(opage,
+		if (unlikely(oldkey != ofolio->index))
+			NILFS_PAGE_BUG(&ofolio->page,
 				       "invalid oldkey %lld (newkey=%lld)",
 				       (unsigned long long)oldkey,
 				       (unsigned long long)newkey);
 
 		xa_lock_irq(&btnc->i_pages);
-		err = __xa_insert(&btnc->i_pages, newkey, opage, GFP_NOFS);
+		err = __xa_insert(&btnc->i_pages, newkey, ofolio, GFP_NOFS);
 		xa_unlock_irq(&btnc->i_pages);
 		/*
-		 * Note: page->index will not change to newkey until
+		 * Note: folio->index will not change to newkey until
 		 * nilfs_btnode_commit_change_key() will be called.
-		 * To protect the page in intermediate state, the page lock
+		 * To protect the folio in intermediate state, the folio lock
 		 * is held.
 		 */
 		if (!err)
@@ -213,7 +213,7 @@ int nilfs_btnode_prepare_change_key(struct address_space *btnc,
 		if (!err)
 			goto retry;
 		/* fallback to copy mode */
-		unlock_page(opage);
+		folio_unlock(ofolio);
 	}
 
 	nbh = nilfs_btnode_create_block(btnc, newkey);
@@ -225,7 +225,7 @@ int nilfs_btnode_prepare_change_key(struct address_space *btnc,
 	return 0;
 
  failed_unlock:
-	unlock_page(obh->b_page);
+	folio_unlock(obh->b_folio);
 	return err;
 }
 
-- 
2.34.1


  parent reply	other threads:[~2023-11-14  8:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14  8:44 [PATCH 00/20] nilfs2: Folio conversions for file paths Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 01/20] nilfs2: Add nilfs_end_folio_io() Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 02/20] nilfs2: Convert nilfs_abort_logs to use folios Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 03/20] nilfs2: Convert nilfs_segctor_complete_write " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 04/20] nilfs2: Convert nilfs_forget_buffer to use a folio Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 05/20] nilfs2: Convert to nilfs_folio_buffers_clean() Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 06/20] nilfs2: Convert nilfs_writepage() to use a folio Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 07/20] nilfs2: Convert nilfs_mdt_write_page() " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 08/20] nilfs2: Convert to nilfs_clear_folio_dirty() Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 09/20] nilfs2: Convert to __nilfs_clear_folio_dirty() Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 10/20] nilfs2: Convert nilfs_segctor_prepare_write to use folios Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 11/20] nilfs2: Convert nilfs_page_mkwrite() to use a folio Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 12/20] nilfs2: Convert nilfs_mdt_create_block " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 13/20] nilfs2: Convert nilfs_mdt_submit_block " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 14/20] nilfs2: Convert nilfs_gccache_submit_read_data " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 15/20] nilfs2: Convert nilfs_btnode_create_block " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 16/20] nilfs2: Convert nilfs_btnode_submit_block " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 17/20] nilfs2: Convert nilfs_btnode_delete " Ryusuke Konishi
2023-11-14  8:44 ` Ryusuke Konishi [this message]
2023-11-14  8:44 ` [PATCH 19/20] nilfs2: Convert nilfs_btnode_commit_change_key " Ryusuke Konishi
2023-11-14  8:44 ` [PATCH 20/20] nilfs2: Convert nilfs_btnode_abort_change_key " Ryusuke Konishi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231114084436.2755-19-konishi.ryusuke@gmail.com \
    --to=konishi.ryusuke@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nilfs@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®