* [PATCH v2] arm64: dts: mt8173: Add G2Touch touchscreen node
@ 2023-11-15 4:35 Pin-yen Lin
2023-11-15 6:08 ` Chen-Yu Tsai
0 siblings, 1 reply; 2+ messages in thread
From: Pin-yen Lin @ 2023-11-15 4:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: linux-kernel, linux-mediatek, Chen-Yu Tsai, linux-arm-kernel,
devicetree, Pin-yen Lin
Lenovo Ideapad C330 Chromebook (MTK) uses G2Touch touchscreen as a
second source component.
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---
Changes in v2:
- Remove the label for the node
arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
index bdcd35cecad9..8836ac3c4233 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
@@ -29,6 +29,14 @@ touchscreen3: touchscreen@20 {
interrupt-parent = <&pio>;
interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
};
+
+ touchscreen@40 {
+ compatible = "hid-over-i2c";
+ reg = <0x40>;
+ hid-descr-addr = <0x0001>;
+ interrupt-parent = <&pio>;
+ interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
+ };
};
&i2c4 {
--
2.43.0.rc0.421.g78406f8d94-goog
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] arm64: dts: mt8173: Add G2Touch touchscreen node
2023-11-15 4:35 [PATCH v2] arm64: dts: mt8173: Add G2Touch touchscreen node Pin-yen Lin
@ 2023-11-15 6:08 ` Chen-Yu Tsai
0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2023-11-15 6:08 UTC (permalink / raw)
To: Pin-yen Lin, Matthias Brugger, AngeloGioacchino Del Regno
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-kernel,
linux-mediatek, linux-arm-kernel, devicetree
On Wed, Nov 15, 2023 at 12:35 PM Pin-yen Lin <treapking@chromium.org> wrote:
>
> Lenovo Ideapad C330 Chromebook (MTK) uses G2Touch touchscreen as a
> second source component.
>
> Signed-off-by: Pin-yen Lin <treapking@chromium.org>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
I assume this patch will get merged relatively soon. I can base my DT
probing work on top of it, instead of having roughly the same patch
in my series.
> ---
>
> Changes in v2:
> - Remove the label for the node
>
> arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> index bdcd35cecad9..8836ac3c4233 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtsi
> @@ -29,6 +29,14 @@ touchscreen3: touchscreen@20 {
> interrupt-parent = <&pio>;
> interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
> };
> +
> + touchscreen@40 {
> + compatible = "hid-over-i2c";
> + reg = <0x40>;
> + hid-descr-addr = <0x0001>;
> + interrupt-parent = <&pio>;
> + interrupts = <88 IRQ_TYPE_LEVEL_LOW>;
I assume Angelo might ask you to use interrupts-extended instead, but
I'd argue it's better to be consistent throughout the file.
> + };
> };
>
> &i2c4 {
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-15 6:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-15 4:35 [PATCH v2] arm64: dts: mt8173: Add G2Touch touchscreen node Pin-yen Lin
2023-11-15 6:08 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®