mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1 1/1] platform/x86: intel_telemetry: Fix kernel doc descriptions
@ 2023-11-20 15:07 Andy Shevchenko
  2023-11-21  8:11 ` Ilpo Järvinen
  0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-11-20 15:07 UTC (permalink / raw)
  To: Andy Shevchenko, platform-driver-x86, linux-kernel
  Cc: Rajneesh Bhardwaj, David E. Box, Hans de Goede,
	Ilpo Järvinen, Mark Gross, kernel test robot

LKP found issues with a kernel doc in the driver:

core.c:116: warning: Function parameter or member 'ioss_evtconfig' not described in 'telemetry_update_events'
core.c:188: warning: Function parameter or member 'ioss_evtconfig' not described in 'telemetry_get_eventconfig'

It looks like it were copy'n'paste typos when these descriptions
had been introduced. Fix the typos.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310070743.WALmRGSY-lkp@intel.com/
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/platform/x86/intel/telemetry/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel/telemetry/core.c b/drivers/platform/x86/intel/telemetry/core.c
index fdf55b5d6948..e4be40f73eeb 100644
--- a/drivers/platform/x86/intel/telemetry/core.c
+++ b/drivers/platform/x86/intel/telemetry/core.c
@@ -102,7 +102,7 @@ static const struct telemetry_core_ops telm_defpltops = {
 /**
  * telemetry_update_events() - Update telemetry Configuration
  * @pss_evtconfig: PSS related config. No change if num_evts = 0.
- * @pss_evtconfig: IOSS related config. No change if num_evts = 0.
+ * @ioss_evtconfig: IOSS related config. No change if num_evts = 0.
  *
  * This API updates the IOSS & PSS Telemetry configuration. Old config
  * is overwritten. Call telemetry_reset_events when logging is over
@@ -176,7 +176,7 @@ EXPORT_SYMBOL_GPL(telemetry_reset_events);
 /**
  * telemetry_get_eventconfig() - Returns the pss and ioss events enabled
  * @pss_evtconfig: Pointer to PSS related configuration.
- * @pss_evtconfig: Pointer to IOSS related configuration.
+ * @ioss_evtconfig: Pointer to IOSS related configuration.
  * @pss_len:	   Number of u32 elements allocated for pss_evtconfig array
  * @ioss_len:	   Number of u32 elements allocated for ioss_evtconfig array
  *
-- 
2.43.0.rc1.1.gbec44491f096


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] platform/x86: intel_telemetry: Fix kernel doc descriptions
  2023-11-20 15:07 [PATCH v1 1/1] platform/x86: intel_telemetry: Fix kernel doc descriptions Andy Shevchenko
@ 2023-11-21  8:11 ` Ilpo Järvinen
  0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2023-11-21  8:11 UTC (permalink / raw)
  To: platform-driver-x86, linux-kernel, Andy Shevchenko
  Cc: Rajneesh Bhardwaj, David E. Box, Hans de Goede, Mark Gross,
	kernel test robot

On Mon, 20 Nov 2023 17:07:56 +0200, Andy Shevchenko wrote:

> LKP found issues with a kernel doc in the driver:
> 
> core.c:116: warning: Function parameter or member 'ioss_evtconfig' not described in 'telemetry_update_events'
> core.c:188: warning: Function parameter or member 'ioss_evtconfig' not described in 'telemetry_get_eventconfig'
> 
> It looks like it were copy'n'paste typos when these descriptions
> had been introduced. Fix the typos.
> 
> [...]


Thank you for your contribution, it has been applied to my local
fixes branch. Note it will show up in the public
platform-drivers-x86/fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: intel_telemetry: Fix kernel doc descriptions
      commit: a6584711e64d9d12ab79a450ec3628fd35e4f476

--
 i.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-21  8:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-20 15:07 [PATCH v1 1/1] platform/x86: intel_telemetry: Fix kernel doc descriptions Andy Shevchenko
2023-11-21  8:11 ` Ilpo Järvinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®