* [PATCH] pinctrl: realtek: Fix logical error when finding descriptor
@ 2023-11-21 9:11 Tzuyi Chang
2023-11-24 9:39 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Tzuyi Chang @ 2023-11-21 9:11 UTC (permalink / raw)
To: Linus Walleij; +Cc: Dan Carpenter, linux-gpio, linux-kernel, Tzuyi Chang
The pin descriptor should be returned if the name has been found in the
descriptor table. Remove the negation in the if statement for accurate
retrieval.
Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
Signed-off-by: Tzuyi Chang <tychang@realtek.com>
---
drivers/pinctrl/realtek/pinctrl-rtd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realtek/pinctrl-rtd.c
index 9c7a1af4ba69..208896593b61 100644
--- a/drivers/pinctrl/realtek/pinctrl-rtd.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd.c
@@ -146,7 +146,7 @@ static int rtd_pinctrl_get_function_groups(struct pinctrl_dev *pcdev,
static const struct rtd_pin_desc *rtd_pinctrl_find_mux(struct rtd_pinctrl *data, unsigned int pin)
{
- if (!data->info->muxes[pin].name)
+ if (data->info->muxes[pin].name)
return &data->info->muxes[pin];
return NULL;
@@ -249,7 +249,7 @@ static const struct pinctrl_pin_desc
static const struct rtd_pin_config_desc
*rtd_pinctrl_find_config(struct rtd_pinctrl *data, unsigned int pin)
{
- if (!data->info->configs[pin].name)
+ if (data->info->configs[pin].name)
return &data->info->configs[pin];
return NULL;
--
2.42.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: realtek: Fix logical error when finding descriptor
2023-11-21 9:11 [PATCH] pinctrl: realtek: Fix logical error when finding descriptor Tzuyi Chang
@ 2023-11-24 9:39 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-11-24 9:39 UTC (permalink / raw)
To: Tzuyi Chang; +Cc: Dan Carpenter, linux-gpio, linux-kernel
On Tue, Nov 21, 2023 at 10:11 AM Tzuyi Chang <tychang@realtek.com> wrote:
> The pin descriptor should be returned if the name has been found in the
> descriptor table. Remove the negation in the if statement for accurate
> retrieval.
>
> Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
> Signed-off-by: Tzuyi Chang <tychang@realtek.com>
Patch applied for fixes!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-24 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-21 9:11 [PATCH] pinctrl: realtek: Fix logical error when finding descriptor Tzuyi Chang
2023-11-24 9:39 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®