From: Samuel Holland <samuel.holland@sifive.com>
To: Palmer Dabbelt <palmer@dabbelt.com>, linux-riscv@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Alexandre Ghiti <alexghiti@rivosinc.com>,
Samuel Holland <samuel.holland@sifive.com>
Subject: [PATCH v3 0/8] riscv: ASID-related and UP-related TLB flush enhancements
Date: Tue, 21 Nov 2023 17:07:11 -0800 [thread overview]
Message-ID: <20231122010815.3545294-1-samuel.holland@sifive.com> (raw)
While reviewing Alexandre Ghiti's "riscv: tlb flush improvements"
series[1], I noticed that most TLB flush functions end up as a call to
local_flush_tlb_all() when SMP is disabled. This series resolves that.
Along the way, I realized that we should be using single-ASID flushes
wherever possible, so I implemented that as well.
[1]: https://lore.kernel.org/linux-riscv/20231030133027.19542-1-alexghiti@rivosinc.com/
Changes in v3:
- Fixed a performance regression caused by executing sfence.vma in a
loop on implementations affected by SiFive CIP-1200
- Rebased on v6.7-rc1
Changes in v2:
- Move the SMP/UP merge earlier in the series to avoid build issues
- Make a copy of __flush_tlb_range() instead of adding ifdefs inside
- local_flush_tlb_all() is the only function used on !MMU (smpboot.c)
Samuel Holland (8):
riscv: mm: Combine the SMP and UP TLB flush code
riscv: Apply SiFive CIP-1200 workaround to single-ASID sfence.vma
riscv: Avoid TLB flush loops when affected by SiFive CIP-1200
riscv: mm: Introduce cntx2asid/cntx2version helper macros
riscv: mm: Use a fixed layout for the MM context ID
riscv: mm: Make asid_bits a local variable
riscv: mm: Preserve global TLB entries when switching contexts
riscv: mm: Always use ASID to flush MM contexts
arch/riscv/errata/sifive/errata.c | 3 ++
arch/riscv/include/asm/errata_list.h | 12 ++++++-
arch/riscv/include/asm/mmu.h | 3 ++
arch/riscv/include/asm/mmu_context.h | 2 --
arch/riscv/include/asm/tlbflush.h | 54 ++++++++++++++--------------
arch/riscv/mm/Makefile | 5 +--
arch/riscv/mm/context.c | 26 ++++++--------
arch/riscv/mm/tlbflush.c | 41 ++++++++-------------
8 files changed, 70 insertions(+), 76 deletions(-)
--
2.42.0
next reply other threads:[~2023-11-22 1:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 1:07 Samuel Holland [this message]
2023-11-22 1:07 ` [PATCH v3 1/8] riscv: mm: Combine the SMP and UP TLB flush code Samuel Holland
2023-11-22 1:07 ` [PATCH v3 2/8] riscv: Apply SiFive CIP-1200 workaround to single-ASID sfence.vma Samuel Holland
2023-11-22 1:07 ` [PATCH v3 3/8] riscv: Avoid TLB flush loops when affected by SiFive CIP-1200 Samuel Holland
2023-11-22 17:34 ` kernel test robot
2023-11-22 1:07 ` [PATCH v3 4/8] riscv: mm: Introduce cntx2asid/cntx2version helper macros Samuel Holland
2023-11-22 1:07 ` [PATCH v3 5/8] riscv: mm: Use a fixed layout for the MM context ID Samuel Holland
2023-11-22 1:07 ` [PATCH v3 6/8] riscv: mm: Make asid_bits a local variable Samuel Holland
2023-11-22 1:07 ` [PATCH v3 7/8] riscv: mm: Preserve global TLB entries when switching contexts Samuel Holland
2023-11-22 1:07 ` [PATCH v3 8/8] riscv: mm: Always use ASID to flush MM contexts Samuel Holland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122010815.3545294-1-samuel.holland@sifive.com \
--to=samuel.holland@sifive.com \
--cc=alexghiti@rivosinc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®