mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Lin <yu-hao.lin@nxp.com>
To: linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
	kvalo@kernel.org, francesco@dolcini.it,
	tsung-hsien.hsieh@nxp.com, David Lin <yu-hao.lin@nxp.com>
Subject: [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE for assoc req.
Date: Tue, 28 Nov 2023 16:31:07 +0800	[thread overview]
Message-ID: <20231128083115.613235-5-yu-hao.lin@nxp.com> (raw)
In-Reply-To: <20231128083115.613235-1-yu-hao.lin@nxp.com>

Remain on channel must be removed after authentication is done.
Otherwise WMM setting for assoiation request will be removed.

Signed-off-by: David Lin <yu-hao.lin@nxp.com>
---
 drivers/net/wireless/marvell/mwifiex/cfg80211.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
index a21310f3807c..b99de9f4ca14 100644
--- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
+++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
@@ -4306,6 +4306,8 @@ mwifiex_cfg80211_authenticate(struct wiphy *wiphy,
 		if (!ret) {
 			priv->roc_cfg.cookie = get_random_u32() | 1;
 			priv->roc_cfg.chan = *req->bss->channel;
+		} else {
+			return -EFAULT;
 		}
 	}
 
@@ -4418,6 +4420,16 @@ mwifiex_cfg80211_associate(struct wiphy *wiphy, struct net_device *dev,
 	if (priv->auth_flag && !(priv->auth_flag & HOST_MLME_AUTH_DONE))
 		return -EBUSY;
 
+	if (priv->roc_cfg.cookie) {
+		ret = mwifiex_remain_on_chan_cfg(priv, HostCmd_ACT_GEN_REMOVE,
+						 &priv->roc_cfg.chan, 0);
+		if (!ret)
+			memset(&priv->roc_cfg, 0,
+			       sizeof(struct mwifiex_roc_cfg));
+		else
+			return -EFAULT;
+	}
+
 	if (!mwifiex_stop_bg_scan(priv))
 		cfg80211_sched_scan_stopped_locked(priv->wdev.wiphy, 0);
 
-- 
2.25.1


  parent reply	other threads:[~2023-11-28  8:32 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28  8:31 [PATCH v7 00/12] wifi: mwifiex: added code to support host mlme David Lin
2023-11-28  8:31 ` [PATCH v7 01/12] " David Lin
2023-11-28 22:51   ` kernel test robot
2023-11-28  8:31 ` [PATCH v7 02/12] wifi: mwifiex: fixed group rekey issue for WPA3 David Lin
2023-12-01 10:15   ` Francesco Dolcini
2023-12-01 15:05     ` Jeff Johnson
2023-12-01 23:18       ` [EXT] " David Lin
2023-12-01 22:41     ` David Lin
2023-11-28  8:31 ` [PATCH v7 03/12] wifi: mwifiex: fixed reassocation " David Lin
2023-12-01 10:17   ` Francesco Dolcini
2023-12-01 22:44     ` [EXT] " David Lin
2023-11-28  8:31 ` David Lin [this message]
2023-12-01 10:18   ` [PATCH v7 04/12] wifi: mwifiex: fixed missing WMM IE for assoc req Francesco Dolcini
2023-12-01 22:47     ` [EXT] " David Lin
2023-12-14  2:16       ` Brian Norris
2023-12-14  2:20         ` David Lin
2023-11-28  8:31 ` [PATCH v7 05/12] wifi: mwifiex: supported host mlme for AP mode David Lin
2023-11-28  8:31 ` [PATCH v7 06/12] wifi: mwifiex: added mac address for AP config David Lin
2023-12-01 10:31   ` Francesco Dolcini
2023-12-01 22:50     ` [EXT] " David Lin
2023-12-03 16:13       ` Jeff Johnson
2023-12-04  1:56         ` David Lin
2023-11-28  8:31 ` [PATCH v7 07/12] wifi: mwifiex: fixed TLV error for station add cmd David Lin
2023-12-01 10:36   ` Francesco Dolcini
2023-12-01 22:52     ` [EXT] " David Lin
2023-11-28  8:31 ` [PATCH v7 08/12] wifi: mwifiex: fixed the way to handle assoc timeout David Lin
2023-12-01 10:37   ` Francesco Dolcini
2023-11-28  8:31 ` [PATCH v7 09/12] wifi: mwifiex: fixed the way to handle link lost David Lin
2023-12-01 10:38   ` Francesco Dolcini
2023-11-28  8:31 ` [PATCH v7 10/12] wifi: mwifiex: fixed AP issue without host mlme David Lin
2023-12-01 10:39   ` Francesco Dolcini
2023-11-28  8:31 ` [PATCH v7 11/12] wifi: mwifiex: misc modifications for review comments David Lin
2023-12-01 10:40   ` Francesco Dolcini
2023-11-28  8:31 ` [PATCH v7 12/12] wifi: mwifiex: fixed compile and coding errors David Lin
2023-12-01 10:43   ` Francesco Dolcini
2023-12-01 11:49 ` [PATCH v7 00/12] wifi: mwifiex: added code to support host mlme Francesco Dolcini
2023-12-01 12:25   ` Kalle Valo
2023-12-01 23:12     ` [EXT] " David Lin
2023-12-01 23:05   ` David Lin
2023-12-05 19:46     ` Francesco Dolcini
2023-12-06  1:49       ` David Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128083115.613235-5-yu-hao.lin@nxp.com \
    --to=yu-hao.lin@nxp.com \
    --cc=briannorris@chromium.org \
    --cc=francesco@dolcini.it \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tsung-hsien.hsieh@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®